Outbound notification webhook (MESH_NOTIFY_URL) on RX text — issue #17 (#20)

src/mesh/mesh.service.spec.ts

@@ -1,7 +1,7 @@
 import { create, fromBinary, toBinary } from '@bufbuild/protobuf';
 import * as P from '@meshtastic/protobufs';
 import { DatabaseSync } from 'node:sqlite';
-import { describe, expect, it } from 'vitest';
+import { beforeEach, describe, expect, it, vi } from 'vitest';
 import { BROADCAST_ADDR, extractFrames, frame } from './codec.js';
 import {
   KAMIL_NUM,
@@ -562,6 +562,116 @@ describe('MeshService message history', () => {
   });
 });
 
+describe('MeshService notify webhook', () => {
+  const fetchMock = vi.fn(async (..._args: unknown[]) => undefined);
+
+  beforeEach(() => fetchMock.mockClear());
+
+  it('POSTs {text, from} to MESH_NOTIFY_URL when an rx text lands on the notify channel (default 3)', async () => {
+    const bridge = await startBridge();
+    process.env.MESH_HOST = '127.0.0.1';
+    process.env.MESH_PORT = String(bridge.port);
+    process.env.MESH_NOTIFY_URL = 'http://notify.example/hook';
+    vi.stubGlobal('fetch', fetchMock);
+    const svc = new MeshService();
+    try {
+      svc.onModuleInit();
+      await waitFor(
+        () => bridge.sockets.length === 1 && svc.status().connected,
+      );
+
+      bridge.sockets[0].write(textPacketFrame(KAMIL_NUM, 42, 'ping', 3));
+
+      await waitFor(() => fetchMock.mock.calls.length === 1);
+      expect(fetchMock).toHaveBeenCalledTimes(1);
+      const [url, init] = fetchMock.mock.calls[0];
+      expect(url).toBe('http://notify.example/hook');
+      const opts = init as {
+        method?: string;
+        headers?: Record<string, string>;
+        body?: string;
+      };
+      expect(opts.method).toBe('POST');
+      expect(opts.headers?.['content-type']).toBe('application/json');
+      expect(JSON.parse(String(opts.body))).toEqual({
+        text: 'ping',
+        from: KAMIL_NUM,
+      });
+    } finally {
+      vi.unstubAllGlobals();
+      delete process.env.MESH_NOTIFY_URL;
+      svc.onModuleDestroy();
+      bridge.close();
+    }
+  });
+
+  it('does not call fetch for rx texts on other channels', async () => {
+    const bridge = await startBridge();
+    process.env.MESH_HOST = '127.0.0.1';
+    process.env.MESH_PORT = String(bridge.port);
+    process.env.MESH_NOTIFY_URL = 'http://notify.example/hook';
+    vi.stubGlobal('fetch', fetchMock);
+    const svc = new MeshService();
+    try {
+      svc.onModuleInit();
+      await waitFor(
+        () => bridge.sockets.length === 1 && svc.status().connected,
+      );
+
+      bridge.sockets[0].write(textPacketFrame(KAMIL_NUM, 42, 'ping', 2));
+
+      // the message is captured in history — but no webhook fires off-channel
+      await waitFor(() => svc.messages().length === 1);
+      expect(fetchMock).not.toHaveBeenCalled();
+    } finally {
+      vi.unstubAllGlobals();
+      delete process.env.MESH_NOTIFY_URL;
+      svc.onModuleDestroy();
+      bridge.close();
+    }
+  });
+
+  it('never calls fetch when MESH_NOTIFY_URL is unset or empty', async () => {
+    const bridge = await startBridge();
+    process.env.MESH_HOST = '127.0.0.1';
+    process.env.MESH_PORT = String(bridge.port);
+    delete process.env.MESH_NOTIFY_URL; // unset → disabled
+    vi.stubGlobal('fetch', fetchMock);
+    const svc = new MeshService();
+    try {
+      svc.onModuleInit();
+      await waitFor(
+        () => bridge.sockets.length === 1 && svc.status().connected,
+      );
+
+      bridge.sockets[0].write(textPacketFrame(KAMIL_NUM, 42, 'ping', 3));
+      await waitFor(() => svc.messages().length === 1);
+      expect(fetchMock).not.toHaveBeenCalled();
+
+      // empty string → also disabled (a fresh service re-reads the env)
+      process.env.MESH_NOTIFY_URL = '';
+      const svc2 = new MeshService();
+      try {
+        svc2.onModuleInit();
+        await waitFor(
+          () => bridge.sockets.length === 2 && svc2.status().connected,
+        );
+
+        bridge.sockets[1].write(textPacketFrame(KAMIL_NUM, 42, 'ping', 3));
+        await waitFor(() => svc2.messages().length === 1);
+      } finally {
+        delete process.env.MESH_NOTIFY_URL;
+        svc2.onModuleDestroy();
+      }
+      expect(fetchMock).not.toHaveBeenCalled();
+    } finally {
+      vi.unstubAllGlobals();
+      svc.onModuleDestroy();
+      bridge.close();
+    }
+  });
+});
+
 describe('MeshService injectMessage', () => {
   it('injects rx records that appear newest-first in messages()', () => {
     const svc = new MeshService();