Compare commits
5
Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
858b901b8d | ||
|
|
17d6cecab9 | ||
|
|
f05ddb304d | ||
|
|
eadae4dc4f | ||
|
|
67f48fb99c |
@@ -72,7 +72,7 @@ history/
|
|||||||
│ └── utils.ts # cn()
|
│ └── utils.ts # cn()
|
||||||
└── components/
|
└── components/
|
||||||
├── PresetPicker.tsx / NationSelect.tsx # home + nation pick screens
|
├── PresetPicker.tsx / NationSelect.tsx # home + nation pick screens
|
||||||
├── WorldMap.tsx # MapLibre basemap + choropleth + click popup + player highlight
|
├── WorldMap.tsx # MapLibre basemap + choropleth + click→dossier + hover tooltip + player highlight
|
||||||
├── NationPanel.tsx # a nation's stats/territory/diplomacy dossier
|
├── NationPanel.tsx # a nation's stats/territory/diplomacy dossier
|
||||||
├── ActionPanel.tsx # tabs: Action / Diplomacy / Advisor + pending-queue list (per-item trash button + confirm dialog) + "Jump forward"
|
├── ActionPanel.tsx # tabs: Action / Diplomacy / Advisor + pending-queue list (per-item trash button + confirm dialog) + "Jump forward"
|
||||||
├── EventFeed.tsx # scrolling event log (newest first)
|
├── EventFeed.tsx # scrolling event log (newest first)
|
||||||
@@ -140,6 +140,17 @@ history/
|
|||||||
(model down) surfaces as an HTTP 502 to the client (shown as a toast).
|
(model down) surfaces as an HTTP 502 to the client (shown as a toast).
|
||||||
- **Stable per-nation colors.** `shared.nationColor(id)` hashes a nation id → hue, shared by the
|
- **Stable per-nation colors.** `shared.nationColor(id)` hashes a nation id → hue, shared by the
|
||||||
server's `RegionMap` and any client coloring so the choropleth always agrees.
|
server's `RegionMap` and any client coloring so the choropleth always agrees.
|
||||||
|
- **Map click → dossier target (owner resolved from the RegionMap).** Clicking a map region does
|
||||||
|
NOT open a popup — it switches the dossier to that region's owning nation
|
||||||
|
(`setViewingId(ownerId)` in `GameScreen`); the manual "Inspect" selector and a map click both set
|
||||||
|
the same target and stay in sync. The owning nation is resolved from the authoritative `RegionMap`
|
||||||
|
by the feature's stable ISO_A3 code, which `applyRegions` stamps into `properties.regionId`
|
||||||
|
(properties survive into the rendered features) and the shared `regionOwner()` helper looks up.
|
||||||
|
It must **never** be read from the feature's top-level `id`: MapLibre repacks a GeoJSON source's
|
||||||
|
`id` into a numeric index when it stores the source, so at click/hover time `feature.id` is a
|
||||||
|
number, never the ISO_A3 (that repacking was the "no owner" bug, #6). Unowned regions (no
|
||||||
|
`RegionMap` entry) leave the current dossier target unchanged — never a broken dossier. The
|
||||||
|
hover path (a non-closeable tooltip with owner + key stats) uses the same resolution.
|
||||||
- **Deterministic stub.** `server/stub.ts` answers the model contract deterministically per
|
- **Deterministic stub.** `server/stub.ts` answers the model contract deterministically per
|
||||||
queued round item: each `action` item → one military/success event, each `diplomacy` item → one
|
queued round item: each `action` item → one military/success event, each `diplomacy` item → one
|
||||||
diplomatic/partial event, an empty round → one political "The world moves on" event. The player
|
diplomatic/partial event, an empty round → one political "The world moves on" event. The player
|
||||||
|
|||||||
@@ -2,6 +2,21 @@
|
|||||||
|
|
||||||
All notable changes to **History** are listed here, newest first.
|
All notable changes to **History** are listed here, newest first.
|
||||||
|
|
||||||
|
## v0.8.0 — 2026-10-11 20:29
|
||||||
|
|
||||||
|
- **Remove a saved game (#20)** — every saved game now has a delete control: a trash button on its card in the home screen's "Saved games" section opens a confirmation dialog ("Delete this game?" showing the scenario/turn/date) with Cancel and a destructive Delete. The new `DELETE /api/games/:id` route removes the game's row from SQLite and returns `{ deleted: true }` (404 if the id is unknown).
|
||||||
|
- **Redirect on a missing/deleted game (#20)** — loading a non-existent game id no longer leaves you stranded. A deep link to a missing game already fell back to home, and now a game that disappears *while its tab is open* (deleted from another tab or the same session) is pushed home too: the server broadcasts an SSE `error` event on delete, and the client's `useSse` gains an `onError` handler that returns the tab to the home screen (matching the existing "game not found" connect behavior).
|
||||||
|
- `PresetPicker` gained an `onDelete` prop, a per-card `data-game-id` attribute, the delete button, and the confirm dialog; `api.deleteGame(id)`, `Db.delete(id)`, and the shared `DeleteGameResponse` type were added to support it.
|
||||||
|
- **Unit + e2e tests** — new `Db.delete` test (removes by id; reports absence for unknown / already-gone ids) and two e2e specs: (a) deleting a saved game from the home screen (open → cancel leaves it; confirm removes the card, the response is `{deleted:true}`, and a follow-up `GET` is 404), and (b) deleting an open game (the live tab is pushed home via the SSE error, and a fresh deep-link to the deleted id lands on home).
|
||||||
|
|
||||||
|
## v0.7.0 — 2026-10-11 19:17
|
||||||
|
|
||||||
|
- Clicking a map region now switches the selected dossier to that region's owning nation instead of opening a popup (#7). The closeable click popup is gone; a hover tooltip (owner + key stats) is kept. The manual "Inspect" selector still works and stays in sync — both it and a map click drive the same dossier target.
|
||||||
|
- Fixed: a clicked owned region no longer reports "no owner" (#6). Root cause: MapLibre repacks a GeoJSON source's top-level `id` (the ISO_A3 string) into a numeric index when it stores the source, so the feature a click/hover handler receives has a *number* for `id` — the old `regions[f.id]` lookup resolved to nothing, and the popup read "No owner" even for owned regions (the choropleth fill still worked because it is stamped from the original `id` before `setData`). Fix: `applyRegions` now stamps the stable ISO_A3 code into `properties.regionId` (and `ownerId`), which survives into the rendered features, and both the click and hover handlers resolve the owning nation from that code via the authoritative RegionMap — never from the repacked `feature.id`.
|
||||||
|
- Unowned regions (no entry in the RegionMap) do not change the dossier when clicked — the current target is left in place (a deliberate, non-crashing choice rather than a special "unowned" dossier state).
|
||||||
|
- New shared helper `regionOwner(regions, isoA3)` in `@shared/protocol` (the pure, single source of truth for "ISO_A3 → owner record").
|
||||||
|
- **Unit tests** — new `regionOwner` tests (owned → owner record, unowned → undefined, empty/missing → undefined) plus a #6 regression guard that pins the exact MapLibre-repacked feature shape (numeric `id`, ISO_A3 in `properties.regionId`) and asserts resolution via `properties.regionId` works while the old `feature.id` path fails (44 tests, up from 39).
|
||||||
|
|
||||||
## v0.6.0 — 2026-10-11 18:27
|
## v0.6.0 — 2026-10-11 18:27
|
||||||
|
|
||||||
- Advisor fetches now show a "thinking" indicator (mirroring the turn's "Simulating…" hint) while the model responds, and the Ask-advisor button disables during the fetch; the top-bar status shows "Advisor thinking…" in the meantime. Fixes #15.
|
- Advisor fetches now show a "thinking" indicator (mirroring the turn's "Simulating…" hint) while the model responds, and the Ask-advisor button disables during the fetch; the top-bar status shows "Advisor thinking…" in the meantime. Fixes #15.
|
||||||
|
|||||||
@@ -560,3 +560,86 @@ test.describe('History — Advisor thinking indicator (#15)', () => {
|
|||||||
await expect(page.getByTestId('status-indicator')).toHaveText(/Idle/);
|
await expect(page.getByTestId('status-indicator')).toHaveText(/Idle/);
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Remove a saved game (#20): a saved game can be deleted from the home screen
|
||||||
|
* (with a confirmation dialog), and loading a non-existent / deleted game id
|
||||||
|
* (directly or via a stale open tab) returns the user to the home screen.
|
||||||
|
*/
|
||||||
|
test.describe('History — remove a saved game & redirect (#20)', () => {
|
||||||
|
test('deleting a saved game from the home screen removes it (with confirmation)', async ({
|
||||||
|
page,
|
||||||
|
}) => {
|
||||||
|
test.setTimeout(90000);
|
||||||
|
const id = await createUkGame(page);
|
||||||
|
await expect(page.getByTestId('world-map')).toBeVisible();
|
||||||
|
|
||||||
|
// Back to the home screen, where the just-created game appears in "Saved games".
|
||||||
|
await page.getByTestId('back-to-scenarios').click();
|
||||||
|
await expect(page.getByTestId('saved-games')).toBeVisible({ timeout: 15000 });
|
||||||
|
const card = page.locator(`[data-game-id="${id}"]`);
|
||||||
|
await expect(card).toBeVisible();
|
||||||
|
|
||||||
|
// Opening the confirm dialog…
|
||||||
|
await card.getByTestId('delete-game').click();
|
||||||
|
const dialog = page.getByTestId('delete-game-confirm-dialog');
|
||||||
|
await expect(dialog).toBeVisible();
|
||||||
|
|
||||||
|
// …and cancelling leaves the game in place.
|
||||||
|
await page.getByTestId('delete-game-cancel').click();
|
||||||
|
await expect(dialog).toHaveCount(0);
|
||||||
|
await expect(card).toBeVisible();
|
||||||
|
|
||||||
|
// Confirming the delete removes it: the DELETE succeeds, the card disappears,
|
||||||
|
// and a subsequent fetch reports the game gone.
|
||||||
|
await card.getByTestId('delete-game').click();
|
||||||
|
await expect(page.getByTestId('delete-game-confirm-dialog')).toBeVisible();
|
||||||
|
const [resp] = await Promise.all([
|
||||||
|
page.waitForResponse(
|
||||||
|
(r) =>
|
||||||
|
r.request().method() === 'DELETE' &&
|
||||||
|
new URL(r.url()).pathname === `/api/games/${id}`,
|
||||||
|
),
|
||||||
|
page.getByTestId('delete-game-confirm').click(),
|
||||||
|
]);
|
||||||
|
expect((await resp.json()) as { deleted: boolean }).toEqual({ deleted: true });
|
||||||
|
await expect(page.getByTestId('delete-game-confirm-dialog')).toHaveCount(0);
|
||||||
|
await expect(card).toHaveCount(0);
|
||||||
|
|
||||||
|
// The game is gone from the server too.
|
||||||
|
const status = await page.evaluate(async (gid) => {
|
||||||
|
const r = await fetch(`/api/games/${gid}`);
|
||||||
|
return r.status;
|
||||||
|
}, id);
|
||||||
|
expect(status).toBe(404);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('deleting an open game sends the active tab home; a deep link lands on home', async ({
|
||||||
|
page,
|
||||||
|
context,
|
||||||
|
}) => {
|
||||||
|
test.setTimeout(90000);
|
||||||
|
const id = await createUkGame(page);
|
||||||
|
await expect(page.getByTestId('world-map')).toBeVisible();
|
||||||
|
await expect(page.getByTestId('turn-count')).toHaveText('1');
|
||||||
|
const origin = await page.evaluate(() => location.origin);
|
||||||
|
|
||||||
|
// Delete the game straight through the API while its tab is open. The server
|
||||||
|
// broadcasts an SSE `error` and the client's useSse onError handler returns
|
||||||
|
// this live tab to the home screen.
|
||||||
|
const delStatus = await page.evaluate(
|
||||||
|
async (gid) => (await fetch(`/api/games/${gid}`, { method: 'DELETE' })).status,
|
||||||
|
id,
|
||||||
|
);
|
||||||
|
expect(delStatus).toBe(200);
|
||||||
|
await expect(page.getByTestId('preset-card').first()).toBeVisible({ timeout: 20000 });
|
||||||
|
await waitHash(page, '#/');
|
||||||
|
|
||||||
|
// A brand-new page deep-linking to the now-deleted id also lands on home.
|
||||||
|
const page2 = await context.newPage();
|
||||||
|
await page2.goto(`${origin}/#/game/${id}`);
|
||||||
|
await expect(page2.getByTestId('preset-card').first()).toBeVisible({ timeout: 20000 });
|
||||||
|
await waitHash(page2, '#/');
|
||||||
|
await page2.close();
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|||||||
+1
-1
@@ -1,6 +1,6 @@
|
|||||||
{
|
{
|
||||||
"name": "history",
|
"name": "history",
|
||||||
"version": "0.6.0",
|
"version": "0.8.0",
|
||||||
"private": true,
|
"private": true,
|
||||||
"type": "module",
|
"type": "module",
|
||||||
"description": "AI-driven alternate-history simulator — the LLM is the world engine (Pax Historia style).",
|
"description": "AI-driven alternate-history simulator — the LLM is the world engine (Pax Historia style).",
|
||||||
|
|||||||
@@ -72,4 +72,19 @@ describe('openDb', () => {
|
|||||||
expect(db.load('missing')).toBeNull();
|
expect(db.load('missing')).toBeNull();
|
||||||
db.close();
|
db.close();
|
||||||
});
|
});
|
||||||
|
|
||||||
|
it('delete removes a game by id and reports absence otherwise', () => {
|
||||||
|
const db = openDb(':memory:');
|
||||||
|
db.save(makeState('a'));
|
||||||
|
db.save(makeState('b'));
|
||||||
|
|
||||||
|
expect(db.delete('nope')).toBe(false); // unknown id
|
||||||
|
expect(db.delete('a')).toBe(true); // removes a
|
||||||
|
expect(db.load('a')).toBeNull();
|
||||||
|
expect(db.load('b')?.id).toBe('b');
|
||||||
|
expect([...db.listIds()].sort()).toEqual(['b']);
|
||||||
|
|
||||||
|
expect(db.delete('a')).toBe(false); // already gone
|
||||||
|
db.close();
|
||||||
|
});
|
||||||
});
|
});
|
||||||
|
|||||||
@@ -8,6 +8,7 @@ export interface Db {
|
|||||||
save(state: GameState): void;
|
save(state: GameState): void;
|
||||||
load(id: string): GameState | null;
|
load(id: string): GameState | null;
|
||||||
listIds(): string[];
|
listIds(): string[];
|
||||||
|
delete(id: string): boolean;
|
||||||
close(): void;
|
close(): void;
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -29,6 +30,7 @@ export function openDb(filePath: string): Db {
|
|||||||
);
|
);
|
||||||
const byId = db.prepare('SELECT data FROM games WHERE id = ?');
|
const byId = db.prepare('SELECT data FROM games WHERE id = ?');
|
||||||
const all = db.prepare('SELECT id FROM games ORDER BY updated_at DESC');
|
const all = db.prepare('SELECT id FROM games ORDER BY updated_at DESC');
|
||||||
|
const del = db.prepare('DELETE FROM games WHERE id = ?');
|
||||||
return {
|
return {
|
||||||
save(state) {
|
save(state) {
|
||||||
upsert.run(state.id, JSON.stringify(state), new Date().toISOString());
|
upsert.run(state.id, JSON.stringify(state), new Date().toISOString());
|
||||||
@@ -45,6 +47,9 @@ export function openDb(filePath: string): Db {
|
|||||||
listIds() {
|
listIds() {
|
||||||
return (all.all() as { id: string }[]).map((r) => r.id);
|
return (all.all() as { id: string }[]).map((r) => r.id);
|
||||||
},
|
},
|
||||||
|
delete(id) {
|
||||||
|
return del.run(id).changes > 0;
|
||||||
|
},
|
||||||
close() {
|
close() {
|
||||||
db.close();
|
db.close();
|
||||||
},
|
},
|
||||||
|
|||||||
@@ -156,6 +156,17 @@ app.get('/api/games/:id/map', (req, res) => {
|
|||||||
res.json({ regions: buildRegionMap(game) });
|
res.json({ regions: buildRegionMap(game) });
|
||||||
});
|
});
|
||||||
|
|
||||||
|
// Delete a saved game entirely. Fast, non-LLM. 404 if it doesn't exist; on
|
||||||
|
// success broadcast an SSE `error` to any other open tab watching it so it
|
||||||
|
// returns home (see the `event: error` handling in src/lib/sse.ts).
|
||||||
|
app.delete('/api/games/:id', (req, res) => {
|
||||||
|
const id = req.params.id;
|
||||||
|
const removed = db.delete(id);
|
||||||
|
if (!removed) return res.status(404).json({ error: 'game not found' });
|
||||||
|
broadcast(id, 'error', { message: 'game deleted' });
|
||||||
|
res.json({ deleted: true });
|
||||||
|
});
|
||||||
|
|
||||||
// Queue a free-text player action onto the pending round. No LLM call and no
|
// Queue a free-text player action onto the pending round. No LLM call and no
|
||||||
// turn advance — the round is only committed (in one turn) by "Jump forward".
|
// turn advance — the round is only committed (in one turn) by "Jump forward".
|
||||||
app.post('/api/games/:id/action', (req, res) => {
|
app.post('/api/games/:id/action', (req, res) => {
|
||||||
|
|||||||
+65
-1
@@ -1,6 +1,6 @@
|
|||||||
import { describe, expect, it } from 'vitest';
|
import { describe, expect, it } from 'vitest';
|
||||||
import { buildRegionMap } from './map';
|
import { buildRegionMap } from './map';
|
||||||
import { nationColor } from '../shared/protocol';
|
import { nationColor, regionOwner, type RegionMap } from '../shared/protocol';
|
||||||
import type { GameState } from '../shared/types';
|
import type { GameState } from '../shared/types';
|
||||||
|
|
||||||
const state: GameState = {
|
const state: GameState = {
|
||||||
@@ -33,6 +33,9 @@ const state: GameState = {
|
|||||||
version: 1,
|
version: 1,
|
||||||
};
|
};
|
||||||
|
|
||||||
|
// The RegionMap built from the fixture: the authoritative ISO_A3 → owner source.
|
||||||
|
const regions: RegionMap = buildRegionMap(state);
|
||||||
|
|
||||||
describe('buildRegionMap', () => {
|
describe('buildRegionMap', () => {
|
||||||
it('maps each ISO_A3 region to its owner + that nation\'s stable color', () => {
|
it('maps each ISO_A3 region to its owner + that nation\'s stable color', () => {
|
||||||
const m = buildRegionMap(state);
|
const m = buildRegionMap(state);
|
||||||
@@ -44,6 +47,67 @@ describe('buildRegionMap', () => {
|
|||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
describe('regionOwner', () => {
|
||||||
|
it('resolves an owned region\'s ISO_A3 to its owner record', () => {
|
||||||
|
expect(regionOwner(regions, 'GBR')).toEqual({
|
||||||
|
color: nationColor('uk'),
|
||||||
|
owner: 'UK',
|
||||||
|
ownerId: 'uk',
|
||||||
|
});
|
||||||
|
expect(regionOwner(regions, 'DEU')).toEqual({
|
||||||
|
color: nationColor('de'),
|
||||||
|
owner: 'DE',
|
||||||
|
ownerId: 'de',
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
it('returns undefined for an unowned region (no RegionMap entry)', () => {
|
||||||
|
expect(regionOwner(regions, 'FRA')).toBeUndefined();
|
||||||
|
expect(regionOwner(regions, 'USA')).toBeUndefined();
|
||||||
|
});
|
||||||
|
|
||||||
|
it('returns undefined for an empty or missing code', () => {
|
||||||
|
expect(regionOwner(regions, '')).toBeUndefined();
|
||||||
|
expect(regionOwner(regions, null)).toBeUndefined();
|
||||||
|
expect(regionOwner(regions, undefined)).toBeUndefined();
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
/**
|
||||||
|
* #6 regression guard. The click/hover handlers resolve the owning nation from a
|
||||||
|
* map feature. MapLibre repacks a GeoJSON source's top-level `id` (the ISO_A3
|
||||||
|
* string) into a *numeric index* when it stores the source, so a feature the map
|
||||||
|
* hands back at interaction time has a number for `id` and the ISO_A3 only lives
|
||||||
|
* in `properties.regionId`. This test pins the exact data shape and proves the
|
||||||
|
* fix: resolution via `properties.regionId` works, while the pre-fix path that
|
||||||
|
* read `feature.id` does not.
|
||||||
|
*/
|
||||||
|
describe('#6 — owner must be resolved from properties.regionId, not the repacked feature.id', () => {
|
||||||
|
// The shape MapLibre returns for a source feature after setData(): `id` is a
|
||||||
|
// number (here 0, as observed in the live map), and the ISO_A3 is preserved
|
||||||
|
// only in properties (the client stamps it as `regionId`).
|
||||||
|
const repackedFeature = {
|
||||||
|
id: 0,
|
||||||
|
properties: { name: 'DE', regionId: 'DEU' },
|
||||||
|
};
|
||||||
|
|
||||||
|
it('resolves the owner from properties.regionId (the fix)', () => {
|
||||||
|
const code = typeof repackedFeature.properties.regionId === 'string' ? repackedFeature.properties.regionId : '';
|
||||||
|
expect(regionOwner(regions, code)).toEqual({
|
||||||
|
color: nationColor('de'),
|
||||||
|
owner: 'DE',
|
||||||
|
ownerId: 'de',
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
it('the old path (feature.id as a string key) does NOT resolve — the bug', () => {
|
||||||
|
// String(0) === '0' is not a valid ISO_A3 key, so the pre-fix lookup failed
|
||||||
|
// and the click popup reported "No owner" even for owned regions.
|
||||||
|
expect(regions[String(repackedFeature.id)]).toBeUndefined();
|
||||||
|
expect(regionOwner(regions, String(repackedFeature.id))).toBeUndefined();
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
describe('nationColor', () => {
|
describe('nationColor', () => {
|
||||||
it('is deterministic per id and distinct across different ids', () => {
|
it('is deterministic per id and distinct across different ids', () => {
|
||||||
expect(nationColor('uk')).toBe(nationColor('uk'));
|
expect(nationColor('uk')).toBe(nationColor('uk'));
|
||||||
|
|||||||
@@ -56,6 +56,23 @@ export interface RegionOwner {
|
|||||||
}
|
}
|
||||||
export type RegionMap = Record<string, RegionOwner>;
|
export type RegionMap = Record<string, RegionOwner>;
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Look up the owner record for a map region from the authoritative RegionMap by
|
||||||
|
* its ISO_A3 code. Returns `undefined` for an empty/missing code or an unowned
|
||||||
|
* region. Pure + shared: the client resolves a clicked or hovered map feature by
|
||||||
|
* first reading the feature's stable ISO_A3 code (stored in `properties.regionId`
|
||||||
|
* by the client when it repacks the source — see WorldMap) and then calling this.
|
||||||
|
*
|
||||||
|
* The code must NOT be taken from the feature's top-level `id`: MapLibre repacks
|
||||||
|
* a GeoJSON source's `id` (an ISO_A3 string) into a numeric index when it stores
|
||||||
|
* the source, so at click/hover time `feature.id` is a number, never the ISO_A3
|
||||||
|
* — resolving from it is exactly the "no owner" bug (#6).
|
||||||
|
*/
|
||||||
|
export function regionOwner(regions: RegionMap, isoA3: string | null | undefined): RegionOwner | undefined {
|
||||||
|
if (!isoA3) return undefined;
|
||||||
|
return regions[isoA3];
|
||||||
|
}
|
||||||
|
|
||||||
/** Server -> client Server-Sent Events payload (see server/index.ts /sse). */
|
/** Server -> client Server-Sent Events payload (see server/index.ts /sse). */
|
||||||
export type SseMessage =
|
export type SseMessage =
|
||||||
| { type: 'state'; state: GameState }
|
| { type: 'state'; state: GameState }
|
||||||
@@ -124,6 +141,11 @@ export interface GameSummary {
|
|||||||
date: string;
|
date: string;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/** Response for deleting a saved game (see `DELETE /api/games/:id`). */
|
||||||
|
export interface DeleteGameResponse {
|
||||||
|
deleted: boolean;
|
||||||
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Deterministic, stable per-nation color for the choropleth. Hashes the nation id
|
* Deterministic, stable per-nation color for the choropleth. Hashes the nation id
|
||||||
* to a hue; sat/light tuned for the dark command-center theme. Pure + shared so
|
* to a hue; sat/light tuned for the dark command-center theme. Pure + shared so
|
||||||
|
|||||||
+30
@@ -309,6 +309,12 @@ export default function App() {
|
|||||||
useSse(game?.id ?? null, {
|
useSse(game?.id ?? null, {
|
||||||
onState: applyState,
|
onState: applyState,
|
||||||
onTurn: applyState,
|
onTurn: applyState,
|
||||||
|
// The game disappeared while this tab had it open — either deleted from
|
||||||
|
// another tab (the server broadcasts an SSE `error`) or a stale deep link to
|
||||||
|
// a missing game (the SSE connect emits `error`). Return this tab home.
|
||||||
|
onError: (msg) => {
|
||||||
|
if (/deleted|not found/i.test(msg)) latestRef.current?.goHome();
|
||||||
|
},
|
||||||
});
|
});
|
||||||
|
|
||||||
const play = useCallback(async (presetId: string) => {
|
const play = useCallback(async (presetId: string) => {
|
||||||
@@ -465,6 +471,29 @@ export default function App() {
|
|||||||
setAdvisors([]);
|
setAdvisors([]);
|
||||||
}, []);
|
}, []);
|
||||||
|
|
||||||
|
// Delete a saved game. Removes it from the "Saved games" list, clears it if it
|
||||||
|
// was the remembered active game, and heads home if it's the one currently
|
||||||
|
// shown. The server also broadcasts an SSE `error` to any *other* open tab of
|
||||||
|
// this game, which the `useSse` `onError` handler above turns into a go-home.
|
||||||
|
const runDeleteGame = useCallback(
|
||||||
|
async (id: string) => {
|
||||||
|
try {
|
||||||
|
await api.deleteGame(id);
|
||||||
|
} catch (e) {
|
||||||
|
toastError(e);
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
setSavedGames((prev) => prev.filter((g) => g.id !== id));
|
||||||
|
if (activeGameId === id) {
|
||||||
|
clearActiveGameId();
|
||||||
|
setActiveGameId(null);
|
||||||
|
}
|
||||||
|
if (game?.id === id) goHome();
|
||||||
|
toast.success('Game deleted');
|
||||||
|
},
|
||||||
|
[activeGameId, game, goHome],
|
||||||
|
);
|
||||||
|
|
||||||
// Expose the latest game + handlers to the mount-once hashchange listener.
|
// Expose the latest game + handlers to the mount-once hashchange listener.
|
||||||
latestRef.current = { game, goHome, loadGame };
|
latestRef.current = { game, goHome, loadGame };
|
||||||
|
|
||||||
@@ -509,6 +538,7 @@ export default function App() {
|
|||||||
savedGames={savedGames}
|
savedGames={savedGames}
|
||||||
activeGameId={activeGameId}
|
activeGameId={activeGameId}
|
||||||
onResume={resumeGame}
|
onResume={resumeGame}
|
||||||
|
onDelete={runDeleteGame}
|
||||||
/>
|
/>
|
||||||
</>
|
</>
|
||||||
);
|
);
|
||||||
|
|||||||
@@ -1,7 +1,16 @@
|
|||||||
import { Play } from 'lucide-react';
|
import { useState } from 'react';
|
||||||
|
import { Play, Trash2 } from 'lucide-react';
|
||||||
import { Badge } from './ui/badge';
|
import { Badge } from './ui/badge';
|
||||||
import { Button } from './ui/button';
|
import { Button } from './ui/button';
|
||||||
import { Card, CardContent, CardDescription, CardHeader, CardTitle } from './ui/card';
|
import { Card, CardContent, CardDescription, CardHeader, CardTitle } from './ui/card';
|
||||||
|
import {
|
||||||
|
Dialog,
|
||||||
|
DialogContent,
|
||||||
|
DialogDescription,
|
||||||
|
DialogFooter,
|
||||||
|
DialogHeader,
|
||||||
|
DialogTitle,
|
||||||
|
} from './ui/dialog';
|
||||||
import type { PresetMeta } from '@shared/types';
|
import type { PresetMeta } from '@shared/types';
|
||||||
import type { GameSummary } from '@shared/protocol';
|
import type { GameSummary } from '@shared/protocol';
|
||||||
|
|
||||||
@@ -15,12 +24,14 @@ interface Props {
|
|||||||
activeGameId?: string | null;
|
activeGameId?: string | null;
|
||||||
/** Resume a saved game by id (shared by the resume button and saved-games rows). */
|
/** Resume a saved game by id (shared by the resume button and saved-games rows). */
|
||||||
onResume?: (id: string) => void;
|
onResume?: (id: string) => void;
|
||||||
|
/** Delete a saved game by id (confirmed by a dialog in this component). */
|
||||||
|
onDelete?: (id: string) => void;
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Home screen: a grid of scenario cards (each with a Play button), a prominent
|
* Home screen: a grid of scenario cards (each with a Play button), a prominent
|
||||||
* "Resume last game" affordance, and a "Saved games" section listing prior
|
* "Resume last game" affordance, and a "Saved games" section listing prior
|
||||||
* games so the user can get back into one.
|
* games so the user can get back into one — or delete it.
|
||||||
*/
|
*/
|
||||||
export default function PresetPicker({
|
export default function PresetPicker({
|
||||||
presets,
|
presets,
|
||||||
@@ -29,8 +40,14 @@ export default function PresetPicker({
|
|||||||
savedGames = [],
|
savedGames = [],
|
||||||
activeGameId,
|
activeGameId,
|
||||||
onResume,
|
onResume,
|
||||||
|
onDelete,
|
||||||
}: Props) {
|
}: Props) {
|
||||||
const activeGame = activeGameId ? savedGames.find((g) => g.id === activeGameId) : undefined;
|
const activeGame = activeGameId ? savedGames.find((g) => g.id === activeGameId) : undefined;
|
||||||
|
// The game awaiting a delete confirmation (null = dialog closed).
|
||||||
|
const [confirmDeleteId, setConfirmDeleteId] = useState<string | null>(null);
|
||||||
|
const confirmDeleteTarget = confirmDeleteId
|
||||||
|
? savedGames.find((g) => g.id === confirmDeleteId)
|
||||||
|
: undefined;
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<div className="mx-auto max-w-6xl px-6 py-10">
|
<div className="mx-auto max-w-6xl px-6 py-10">
|
||||||
@@ -90,7 +107,7 @@ export default function PresetPicker({
|
|||||||
))}
|
))}
|
||||||
</div>
|
</div>
|
||||||
|
|
||||||
{/* Saved games: get back into any prior game. */}
|
{/* Saved games: get back into any prior game (or delete it). */}
|
||||||
{savedGames.length > 0 && (
|
{savedGames.length > 0 && (
|
||||||
<section className="mt-12" data-testid="saved-games">
|
<section className="mt-12" data-testid="saved-games">
|
||||||
<h2 className="mb-4 text-xl font-bold tracking-tight">Saved games</h2>
|
<h2 className="mb-4 text-xl font-bold tracking-tight">Saved games</h2>
|
||||||
@@ -100,13 +117,28 @@ export default function PresetPicker({
|
|||||||
key={g.id}
|
key={g.id}
|
||||||
className="flex flex-col"
|
className="flex flex-col"
|
||||||
data-testid="saved-game"
|
data-testid="saved-game"
|
||||||
|
data-game-id={g.id}
|
||||||
>
|
>
|
||||||
<CardHeader>
|
<CardHeader>
|
||||||
<div className="flex items-start justify-between gap-2">
|
<div className="flex items-start justify-between gap-2">
|
||||||
<CardTitle className="text-base">{g.presetTitle}</CardTitle>
|
<CardTitle className="text-base">{g.presetTitle}</CardTitle>
|
||||||
<Badge variant="secondary" className="shrink-0 text-xs">
|
<div className="flex shrink-0 items-center gap-1">
|
||||||
{g.date}
|
<Badge variant="secondary" className="text-xs">
|
||||||
</Badge>
|
{g.date}
|
||||||
|
</Badge>
|
||||||
|
<Button
|
||||||
|
variant="ghost"
|
||||||
|
size="icon-sm"
|
||||||
|
className="text-muted-foreground hover:text-destructive"
|
||||||
|
data-testid="delete-game"
|
||||||
|
aria-label={`Delete ${g.presetTitle}`}
|
||||||
|
title="Delete this game"
|
||||||
|
onClick={() => setConfirmDeleteId(g.id)}
|
||||||
|
disabled={loading}
|
||||||
|
>
|
||||||
|
<Trash2 />
|
||||||
|
</Button>
|
||||||
|
</div>
|
||||||
</div>
|
</div>
|
||||||
<CardDescription className="text-sm">Turn {g.turn}</CardDescription>
|
<CardDescription className="text-sm">Turn {g.turn}</CardDescription>
|
||||||
</CardHeader>
|
</CardHeader>
|
||||||
@@ -125,6 +157,40 @@ export default function PresetPicker({
|
|||||||
</div>
|
</div>
|
||||||
</section>
|
</section>
|
||||||
)}
|
)}
|
||||||
|
|
||||||
|
{/* Confirm before permanently deleting a saved game. */}
|
||||||
|
<Dialog open={confirmDeleteId !== null} onOpenChange={(o) => !o && setConfirmDeleteId(null)}>
|
||||||
|
<DialogContent className="max-w-sm" data-testid="delete-game-confirm-dialog">
|
||||||
|
<DialogHeader>
|
||||||
|
<DialogTitle>Delete this game?</DialogTitle>
|
||||||
|
<DialogDescription>
|
||||||
|
{confirmDeleteTarget
|
||||||
|
? `"${confirmDeleteTarget.presetTitle}" (turn ${confirmDeleteTarget.turn}, ${confirmDeleteTarget.date}) will be permanently removed. This cannot be undone.`
|
||||||
|
: 'This game will be permanently removed.'}
|
||||||
|
</DialogDescription>
|
||||||
|
</DialogHeader>
|
||||||
|
<DialogFooter>
|
||||||
|
<Button
|
||||||
|
variant="outline"
|
||||||
|
data-testid="delete-game-cancel"
|
||||||
|
onClick={() => setConfirmDeleteId(null)}
|
||||||
|
>
|
||||||
|
Cancel
|
||||||
|
</Button>
|
||||||
|
<Button
|
||||||
|
variant="destructive"
|
||||||
|
data-testid="delete-game-confirm"
|
||||||
|
onClick={() => {
|
||||||
|
const id = confirmDeleteId;
|
||||||
|
setConfirmDeleteId(null);
|
||||||
|
if (id) onDelete?.(id);
|
||||||
|
}}
|
||||||
|
>
|
||||||
|
Delete
|
||||||
|
</Button>
|
||||||
|
</DialogFooter>
|
||||||
|
</DialogContent>
|
||||||
|
</Dialog>
|
||||||
</div>
|
</div>
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|||||||
+59
-41
@@ -8,7 +8,7 @@ import 'maplibre-gl/dist/maplibre-gl.css';
|
|||||||
// Point it at a Vite-emitted copy of the worker module so it loads in prod.
|
// Point it at a Vite-emitted copy of the worker module so it loads in prod.
|
||||||
import workerUrl from 'maplibre-gl/dist/maplibre-gl-worker.mjs?url';
|
import workerUrl from 'maplibre-gl/dist/maplibre-gl-worker.mjs?url';
|
||||||
maplibregl.setWorkerUrl(workerUrl);
|
maplibregl.setWorkerUrl(workerUrl);
|
||||||
import type { RegionMap, RegionOwner } from '@shared/protocol';
|
import { regionOwner, type RegionMap, type RegionOwner } from '@shared/protocol';
|
||||||
import type { Nation } from '@shared/types';
|
import type { Nation } from '@shared/types';
|
||||||
import { cn } from '@/lib/utils';
|
import { cn } from '@/lib/utils';
|
||||||
|
|
||||||
@@ -101,21 +101,36 @@ function cameraForPreset(presetId: string): { center: [number, number]; zoom: nu
|
|||||||
* carries its owner's stable fill color, a subtle stroke, and a flag for the
|
* carries its owner's stable fill color, a subtle stroke, and a flag for the
|
||||||
* player's own regions (rendered as a brighter, thicker border by a dedicated
|
* player's own regions (rendered as a brighter, thicker border by a dedicated
|
||||||
* layer). Unknown owners fall back to a faint neutral fill — never an error.
|
* layer). Unknown owners fall back to a faint neutral fill — never an error.
|
||||||
|
*
|
||||||
|
* Crucially, the base GeoJSON feature's top-level `id` (the ISO_A3 code) is
|
||||||
|
* stamped into `properties.regionId`, and the owner's id into `properties.ownerId`.
|
||||||
|
* MapLibre repacks a GeoJSON source's top-level `id` into a numeric index when it
|
||||||
|
* stores it, so a later click/hover event exposes that number on
|
||||||
|
* `e.features[i].id` — the top-level `id` is *not* a reliable lookup key at
|
||||||
|
* interaction time (the root cause of #6). `properties`, however, survive into the
|
||||||
|
* rendered features, so the interaction handlers resolve the owning nation from
|
||||||
|
* `properties.regionId` via the RegionMap (see `regionOwner`).
|
||||||
*/
|
*/
|
||||||
function applyRegions(geo: FeatureCollection, regions: RegionMap, playerNationId: string): FeatureCollection {
|
function applyRegions(geo: FeatureCollection, regions: RegionMap, playerNationId: string): FeatureCollection {
|
||||||
const out: FeatureCollection = JSON.parse(JSON.stringify(geo));
|
const out: FeatureCollection = JSON.parse(JSON.stringify(geo));
|
||||||
for (const f of out.features) {
|
for (const f of out.features) {
|
||||||
f.properties = f.properties ?? {};
|
f.properties = f.properties ?? {};
|
||||||
const r = f.id ? regions[f.id as string] : undefined;
|
// The base GeoJSON `id` is the ISO_A3 code; keep it in a property that
|
||||||
|
// survives into the features MapLibre hands back on click/hover.
|
||||||
|
const code = f.id == null ? '' : String(f.id);
|
||||||
|
f.properties.regionId = code;
|
||||||
|
const r = code ? regions[code] : undefined;
|
||||||
if (r) {
|
if (r) {
|
||||||
f.properties.fill = r.color;
|
f.properties.fill = r.color;
|
||||||
f.properties.owner = r.owner;
|
f.properties.owner = r.owner;
|
||||||
|
f.properties.ownerId = r.ownerId;
|
||||||
f.properties.stroke = 'rgba(255,255,255,0.10)';
|
f.properties.stroke = 'rgba(255,255,255,0.10)';
|
||||||
f.properties.isPlayer = r.ownerId === playerNationId ? 1 : 0;
|
f.properties.isPlayer = r.ownerId === playerNationId ? 1 : 0;
|
||||||
} else {
|
} else {
|
||||||
f.properties.fill = 'rgba(148,163,184,0.05)';
|
f.properties.fill = 'rgba(148,163,184,0.05)';
|
||||||
f.properties.stroke = 'rgba(255,255,255,0.06)';
|
f.properties.stroke = 'rgba(255,255,255,0.06)';
|
||||||
f.properties.owner = '';
|
f.properties.owner = '';
|
||||||
|
f.properties.ownerId = '';
|
||||||
f.properties.isPlayer = 0;
|
f.properties.isPlayer = 0;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -150,35 +165,19 @@ function hoverHtml(countryName: string, region?: RegionOwner, nation?: Nation):
|
|||||||
</div>`;
|
</div>`;
|
||||||
}
|
}
|
||||||
|
|
||||||
/** Click popup: the full owning-nation profile with all four stats. */
|
|
||||||
function clickHtml(countryName: string, region?: RegionOwner, nation?: Nation): string {
|
|
||||||
if (!region || !nation) {
|
|
||||||
return `<div class="hm-popup"><div class="hm-popup-title">${esc(countryName || 'Unclaimed')}</div><div class="hm-popup-sub">No owner</div></div>`;
|
|
||||||
}
|
|
||||||
const stats = [
|
|
||||||
statRow('Mil', nation.stats.military),
|
|
||||||
statRow('Eco', nation.stats.economy),
|
|
||||||
statRow('Stab', nation.stats.stability),
|
|
||||||
statRow('Pop', nation.stats.population),
|
|
||||||
].join('');
|
|
||||||
const regions = nation.territory.length;
|
|
||||||
return `<div class="hm-popup">
|
|
||||||
<div class="hm-popup-title">${esc(countryName || region.owner)}</div>
|
|
||||||
<div class="hm-popup-owner hm-popup-owner-big"><span class="hm-chip" style="background:${region.color}"></span>${esc(region.owner)}</div>
|
|
||||||
<div class="hm-popup-sub">${regions} region${regions === 1 ? '' : 's'} · click focuses the dossier</div>
|
|
||||||
<div class="hm-stats">${stats}</div>
|
|
||||||
</div>`;
|
|
||||||
}
|
|
||||||
|
|
||||||
interface Props {
|
interface Props {
|
||||||
regions: RegionMap;
|
regions: RegionMap;
|
||||||
playerNationId: string;
|
playerNationId: string;
|
||||||
/** All nations, for hover/click stats and color chips. */
|
/** All nations, for the hover tooltip's owner stats and color chips. */
|
||||||
nations: Record<string, Nation>;
|
nations: Record<string, Nation>;
|
||||||
/** The active scenario id, for a sensible initial camera. */
|
/** The active scenario id, for a sensible initial camera. */
|
||||||
presetId: string;
|
presetId: string;
|
||||||
className?: string;
|
className?: string;
|
||||||
/** Called when a region is clicked, so the dossier can focus its owner. */
|
/**
|
||||||
|
* Called with a region's owning-nation id when that region is clicked, so the
|
||||||
|
* dossier switches to that nation. Not called for unowned regions (the dossier
|
||||||
|
* keeps its current target). See the component doc for the full behavior.
|
||||||
|
*/
|
||||||
onFocusNation?: (id: string) => void;
|
onFocusNation?: (id: string) => void;
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -187,10 +186,18 @@ interface Props {
|
|||||||
* nation. Rendered as a fixed, full-viewport background layer (z-0) behind the
|
* nation. Rendered as a fixed, full-viewport background layer (z-0) behind the
|
||||||
* floating HUD windows: a dark-navy basemap with subtle terrain, per-nation
|
* floating HUD windows: a dark-navy basemap with subtle terrain, per-nation
|
||||||
* stable fills (the choropleth is the star), thin borders, a brighter/thicker
|
* stable fills (the choropleth is the star), thin borders, a brighter/thicker
|
||||||
* border for the player, hover + click popups with
|
* border for the player, a hover tooltip (owner + key stats), a **click that
|
||||||
* owner + stats, a transient flash on territory changes, and a
|
* switches the dossier to the region's owning nation** (no popup — see #7), a
|
||||||
* per-scenario initial camera. Zoom and pan are driven directly by the user
|
* transient flash on territory changes, and a per-scenario initial camera.
|
||||||
* (MapLibre wheel/trackpad + drag) — no floating control and no external API.
|
*
|
||||||
|
* Ownership for a hovered/clicked region is resolved from the authoritative
|
||||||
|
* RegionMap by the feature's stable ISO_A3 code in `properties.regionId`
|
||||||
|
* (see `regionOwner` in @shared/protocol) — never from the feature's top-level
|
||||||
|
* `id`, which MapLibre repacks into a numeric index at interaction time (#6).
|
||||||
|
* Unowned regions (no RegionMap entry) simply do not change the dossier.
|
||||||
|
*
|
||||||
|
* Zoom and pan are driven directly by the user (MapLibre wheel/trackpad + drag)
|
||||||
|
* — no floating control and no external API.
|
||||||
*/
|
*/
|
||||||
export default function WorldMap({
|
export default function WorldMap({
|
||||||
regions,
|
regions,
|
||||||
@@ -243,7 +250,6 @@ export default function WorldMap({
|
|||||||
(containerRef.current as unknown as { __map?: maplibregl.Map }).__map = map;
|
(containerRef.current as unknown as { __map?: maplibregl.Map }).__map = map;
|
||||||
|
|
||||||
const hoverPopup = new maplibregl.Popup({ closeButton: false, closeOnClick: false, offset: 10 });
|
const hoverPopup = new maplibregl.Popup({ closeButton: false, closeOnClick: false, offset: 10 });
|
||||||
const clickPopup = new maplibregl.Popup({ closeButton: true, closeOnClick: true, offset: 12 });
|
|
||||||
let lastHoverId: string | null = null;
|
let lastHoverId: string | null = null;
|
||||||
|
|
||||||
const loadGeo = (): Promise<FeatureCollection> =>
|
const loadGeo = (): Promise<FeatureCollection> =>
|
||||||
@@ -300,24 +306,33 @@ export default function WorldMap({
|
|||||||
}
|
}
|
||||||
flashApiRef.current = animateFlash;
|
flashApiRef.current = animateFlash;
|
||||||
|
|
||||||
|
// The region a hovered/clicked feature belongs to is identified by its stable
|
||||||
|
// ISO_A3 code, read from `properties.regionId` (stamped by `applyRegions`).
|
||||||
|
// We must NOT use the feature's top-level `id`: MapLibre repacks a GeoJSON
|
||||||
|
// source's `id` into a numeric index when it stores the source, so the value
|
||||||
|
// exposed on `e.features[i].id` at interaction time is a number, never the
|
||||||
|
// ISO_A3 — resolving the owner from it is the "no owner" bug (#6).
|
||||||
const onHover = (e: maplibregl.MapLayerMouseEvent) => {
|
const onHover = (e: maplibregl.MapLayerMouseEvent) => {
|
||||||
const f = e.features?.[0];
|
const f = e.features?.[0];
|
||||||
if (!f) return;
|
if (!f) return;
|
||||||
const id = f.id == null ? null : String(f.id);
|
const p = f.properties as { name?: string; regionId?: string };
|
||||||
if (id && id !== lastHoverId) {
|
const code = typeof p?.regionId === 'string' ? p.regionId : '';
|
||||||
lastHoverId = id;
|
if (code && code !== lastHoverId) {
|
||||||
|
lastHoverId = code;
|
||||||
const geo = baseGeoRef.current;
|
const geo = baseGeoRef.current;
|
||||||
const feat = geo?.features.find((x) => x.id != null && String(x.id) === id);
|
// The base GeoJSON feature's top-level `id` IS the ISO_A3, so match on
|
||||||
|
// that to recover the feature for the hover-highlight outline (the
|
||||||
|
// feature MapLibre hands us has a repacked numeric `id` we can't use).
|
||||||
|
const feat = geo?.features.find((x) => x.id != null && String(x.id) === code);
|
||||||
(map.getSource(HOVER_SOURCE) as GeoSource | undefined)?.setData(
|
(map.getSource(HOVER_SOURCE) as GeoSource | undefined)?.setData(
|
||||||
feat ? { type: 'FeatureCollection', features: [JSON.parse(JSON.stringify(feat))] } : emptyFC(),
|
feat ? { type: 'FeatureCollection', features: [JSON.parse(JSON.stringify(feat))] } : emptyFC(),
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
const p = f.properties as { name?: string };
|
const region = regionOwner(regionsRef.current, code);
|
||||||
const region = id ? regionsRef.current[id] : undefined;
|
|
||||||
const nation = region ? nationsRef.current[region.ownerId] : undefined;
|
const nation = region ? nationsRef.current[region.ownerId] : undefined;
|
||||||
hoverPopup
|
hoverPopup
|
||||||
.setLngLat(e.lngLat)
|
.setLngLat(e.lngLat)
|
||||||
.setHTML(hoverHtml(p?.name ?? id ?? '', region, nation))
|
.setHTML(hoverHtml(p?.name ?? code, region, nation))
|
||||||
.addTo(map);
|
.addTo(map);
|
||||||
map.getCanvas().style.cursor = 'pointer';
|
map.getCanvas().style.cursor = 'pointer';
|
||||||
};
|
};
|
||||||
@@ -329,14 +344,17 @@ export default function WorldMap({
|
|||||||
map.getCanvas().style.cursor = '';
|
map.getCanvas().style.cursor = '';
|
||||||
};
|
};
|
||||||
|
|
||||||
|
// #7: a click does NOT open a popup — it switches the dossier to the region's
|
||||||
|
// owning nation. The owner is resolved from the stable ISO_A3 in
|
||||||
|
// `properties.regionId` via the RegionMap (never the repacked top-level
|
||||||
|
// `f.id`, #6). A region with no owner in the RegionMap (unowned territory)
|
||||||
|
// leaves the current dossier target unchanged — never a broken dossier.
|
||||||
const onClick = (e: maplibregl.MapLayerMouseEvent) => {
|
const onClick = (e: maplibregl.MapLayerMouseEvent) => {
|
||||||
const f = e.features?.[0];
|
const f = e.features?.[0];
|
||||||
if (!f) return;
|
if (!f) return;
|
||||||
const id = f.id == null ? null : String(f.id);
|
const p = f.properties as { regionId?: string };
|
||||||
const p = f.properties as { name?: string };
|
const code = typeof p?.regionId === 'string' ? p.regionId : '';
|
||||||
const region = id ? regionsRef.current[id] : undefined;
|
const region = regionOwner(regionsRef.current, code);
|
||||||
const nation = region ? nationsRef.current[region.ownerId] : undefined;
|
|
||||||
clickPopup.setLngLat(e.lngLat).setHTML(clickHtml(p?.name ?? id ?? '', region, nation)).addTo(map);
|
|
||||||
if (region?.ownerId) onFocusNationRef.current?.(region.ownerId);
|
if (region?.ownerId) onFocusNationRef.current?.(region.ownerId);
|
||||||
};
|
};
|
||||||
|
|
||||||
|
|||||||
@@ -7,6 +7,7 @@ import type {
|
|||||||
AddDiplomacyResponse,
|
AddDiplomacyResponse,
|
||||||
AdvisorResponse,
|
AdvisorResponse,
|
||||||
CreateGameResponse,
|
CreateGameResponse,
|
||||||
|
DeleteGameResponse,
|
||||||
GameSummary,
|
GameSummary,
|
||||||
RemoveQueueItemResponse,
|
RemoveQueueItemResponse,
|
||||||
TurnResponse,
|
TurnResponse,
|
||||||
@@ -33,6 +34,9 @@ export const api = {
|
|||||||
body: JSON.stringify({ presetId, playerNationId }),
|
body: JSON.stringify({ presetId, playerNationId }),
|
||||||
}),
|
}),
|
||||||
getGame: (id: string) => req<{ game: GameState }>(`/api/games/${id}`),
|
getGame: (id: string) => req<{ game: GameState }>(`/api/games/${id}`),
|
||||||
|
// Delete a saved game entirely. Fast, non-LLM. Returns { deleted: true }.
|
||||||
|
deleteGame: (id: string) =>
|
||||||
|
req<DeleteGameResponse>(`/api/games/${id}`, { method: 'DELETE' }),
|
||||||
// Every saved game as a lightweight summary, newest-updated first (for the
|
// Every saved game as a lightweight summary, newest-updated first (for the
|
||||||
// home screen's "Saved games" section / resume affordances).
|
// home screen's "Saved games" section / resume affordances).
|
||||||
listGames: () => req<{ games: GameSummary[] }>('/api/games'),
|
listGames: () => req<{ games: GameSummary[] }>('/api/games'),
|
||||||
|
|||||||
@@ -5,6 +5,12 @@ import type { TurnResult } from '@shared/protocol';
|
|||||||
interface SseHandlers {
|
interface SseHandlers {
|
||||||
onState?: (state: GameState) => void;
|
onState?: (state: GameState) => void;
|
||||||
onTurn?: (state: GameState, result: TurnResult) => void;
|
onTurn?: (state: GameState, result: TurnResult) => void;
|
||||||
|
/**
|
||||||
|
* Fired for a server-sent NAMED `event: error` (a MessageEvent with a JSON
|
||||||
|
* body `{ message }`) — e.g. the game was deleted or no longer exists. Pure
|
||||||
|
* connection errors (no data) are ignored and EventSource auto-reconnects.
|
||||||
|
*/
|
||||||
|
onError?: (message: string) => void;
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
@@ -37,8 +43,19 @@ export function useSse(id: string | null, handlers: SseHandlers): void {
|
|||||||
/* ignore malformed */
|
/* ignore malformed */
|
||||||
}
|
}
|
||||||
};
|
};
|
||||||
|
const onError = (e: Event) => {
|
||||||
|
if (e instanceof MessageEvent && e.data) {
|
||||||
|
try {
|
||||||
|
const d = JSON.parse(e.data) as { message?: string };
|
||||||
|
if (d.message) handlersRef.current.onError?.(d.message);
|
||||||
|
} catch {
|
||||||
|
/* ignore malformed */
|
||||||
|
}
|
||||||
|
}
|
||||||
|
};
|
||||||
es.addEventListener('state', onState);
|
es.addEventListener('state', onState);
|
||||||
es.addEventListener('turn', onTurn);
|
es.addEventListener('turn', onTurn);
|
||||||
|
es.addEventListener('error', onError);
|
||||||
return () => es.close();
|
return () => es.close();
|
||||||
}, [id]);
|
}, [id]);
|
||||||
}
|
}
|
||||||
|
|||||||
Reference in New Issue
Block a user