OpenCode/Flight-Ops
2
0
Fork 0
Code Issues Pull Requests Actions Activity

Reject duplicate queue legs — same route can no longer be queued twice (ISS-065, v0.34.0) #67

Merged
kamilkrzywda merged 1 commits from feat/queue-duplicate-guard into master 2026-09-21 04:31:54 +02:00
Conversation 0 Commits 1 Files Changed 7
+54 -2
kamilkrzywda commented 2026-09-21 04:23:15 +02:00
Owner
Copy Link
Copy Source

Fixes #65

queueLeg (lib/game/actions.ts) now refuses to append a destination that is already in the plane's flight queue ("{icao} is already in the flight queue"), and — while the plane is flying — re-queuing the active leg's destination ("already flying to {icao}"). Previously the same route could be queued any number of times, producing pointless repeated/zero-length hops when landing auto-chains queue[0].

No UI or OpenAPI changes (the endpoint already documents error responses). Unit: new cases in lib/game/actions.test.ts; e2e: duplicate-queue 409 assertion added to e2e/queue.spec.ts (verified by CI against the isolated dind stack).

Fixes #65 `queueLeg` (`lib/game/actions.ts`) now refuses to append a destination that is already in the plane's flight queue ("{icao} is already in the flight queue"), and — while the plane is flying — re-queuing the active leg's destination ("already flying to {icao}"). Previously the same route could be queued any number of times, producing pointless repeated/zero-length hops when landing auto-chains `queue[0]`. No UI or OpenAPI changes (the endpoint already documents error responses). Unit: new cases in `lib/game/actions.test.ts`; e2e: duplicate-queue 409 assertion added to `e2e/queue.spec.ts` (verified by CI against the isolated dind stack).
kamilkrzywda added 1 commit 2026-09-21 04:23:15 +02:00
Reject duplicate queue legs — same route can no longer be queued twice (ISS-065, v0.34.0)
CI / build + unit + e2e (pull_request) Successful in 8m43s
Details
394d51d827
kamilkrzywda scheduled this pull request to auto merge when all checks succeed 2026-09-21 04:23:21 +02:00
kamilkrzywda merged commit 847e74b7b8 into master 2026-09-21 04:31:54 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
kamilkrzywda (Kamil Krzywda) smysakowski
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenCode/Flight-Ops#67