OpenCode/Flight-Ops
2
0
Fork 0
Code Issues Pull Requests Actions Activity

v0.17.0 — ISS-008 toasts for errors/events + browser notifications #19

Merged
kamilkrzywda merged 2 commits from feat/toasts-and-notifications into master 2026-09-19 17:33:14 +02:00
Conversation 0 Commits 2 Files Changed 13
+685 -27
kamilkrzywda commented 2026-09-19 16:58:46 +02:00
Owner
Copy Link
Copy Source

What (issue #8)

Error messages like "insufficient funds: a ATR 72-600 costs 200000, you have 62721" should appear as toasts in the bottom-right corner; more event messages (e.g. plane landing); browser notifications when the window is not focused.

Toasts

  • New lib/useToasts.ts hook: {toasts, push(kind:'error'|'info', msg), dismiss(id)}, 5 s auto-dismiss, queue capped at 4
  • New components/Toasts.tsx <ToastStack> — fixed bottom-right; items [data-testid="toast"] with toast-error (red border) / toast-info (slate) variants + per-toast dismiss button
  • Action errors now toast: RightPane runAction catch calls the new optional onError prop and keeps the inline right-error; LeftPane sim-control failures (previously console.error-only) wired to the same callback

Event messages (no server event feed exists — client-side snapshot diffing, no API changes)

  • New pure lib/deriveEvents.ts: diffSnapshots(prev|null, next) → info events from existing fields only:
    • {model} landed at {airport} (flying→available)
    • Package delivered: +€X / Package expired: A → B / New package available: A → B
    • Bought {model} / Sold {model} (plane id-set diff)
  • Shell (app/page.tsx) diffs each polled snapshot and pushes info toasts

Browser notifications

  • "Enable notifications" button in the LeftPane Time section (explicit Notification.requestPermission() on click; label reflects granted/blocked/unsupported)
  • When document.hidden and permission is granted, events also fire new Notification('Flight Ops', {body})

E2E (new e2e/toasts.spec.ts)

One test, two parts: (A) select the priciest model in Market (ATR 72-600, €200k > starting cash), buy → expect a visible toast matching /insufficient funds/ + inline error still shown; (B) notifications opt-in button behavior (soft — headless may deny).

Version

  • package.json → 0.17.0; CHANGELOG.md entry at top

Checks (local)

  • tsc --noEmit clean; unit 273/273 green (was 261); playwright test --list = 36 tests in 10 files
  • e2e not run locally by design — CI verifies against the isolated stack
## What (issue #8) *Error messages like "insufficient funds: a ATR 72-600 costs 200000, you have 62721" should appear as toasts in the bottom-right corner; more event messages (e.g. plane landing); browser notifications when the window is not focused.* **Toasts** - New `lib/useToasts.ts` hook: `{toasts, push(kind:'error'|'info', msg), dismiss(id)}`, 5 s auto-dismiss, queue capped at 4 - New `components/Toasts.tsx` `<ToastStack>` — fixed bottom-right; items `[data-testid="toast"]` with `toast-error` (red border) / `toast-info` (slate) variants + per-toast dismiss button - Action errors now toast: RightPane `runAction` catch calls the new optional `onError` prop **and** keeps the inline `right-error`; LeftPane sim-control failures (previously console.error-only) wired to the same callback **Event messages** (no server event feed exists — client-side snapshot diffing, no API changes) - New pure `lib/deriveEvents.ts`: `diffSnapshots(prev|null, next)` → info events from existing fields only: - `{model} landed at {airport}` (flying→available) - `Package delivered: +€X` / `Package expired: A → B` / `New package available: A → B` - `Bought {model}` / `Sold {model}` (plane id-set diff) - Shell (`app/page.tsx`) diffs each polled snapshot and pushes info toasts **Browser notifications** - "Enable notifications" button in the LeftPane Time section (explicit `Notification.requestPermission()` on click; label reflects granted/blocked/unsupported) - When `document.hidden` and permission is granted, events also fire `new Notification('Flight Ops', {body})` ## E2E (new `e2e/toasts.spec.ts`) One test, two parts: (A) select the priciest model in Market (ATR 72-600, €200k > starting cash), buy → expect a visible toast matching /insufficient funds/ + inline error still shown; (B) notifications opt-in button behavior (soft — headless may deny). ## Version - `package.json` → **0.17.0**; `CHANGELOG.md` entry at top ## Checks (local) - `tsc --noEmit` clean; unit 273/273 green (was 261); `playwright test --list` = 36 tests in 10 files - e2e not run locally by design — CI verifies against the isolated stack
kamilkrzywda added 1 commit 2026-09-19 16:58:47 +02:00
feat: v0.17.0 — ISS-008 toasts for errors/events + browser notifications
CI / build + unit + e2e (pull_request) Failing after 6m59s
Details
d8dc785757
kamilkrzywda added 1 commit 2026-09-19 17:23:29 +02:00
fix: v0.17.0 — sim-control POST retries + permission-aware notifications e2e
CI / build + unit + e2e (pull_request) Successful in 6m52s
Details
51d4f21d6b
kamilkrzywda merged commit 0467b54c70 into master 2026-09-19 17:33:14 +02:00
kamilkrzywda deleted branch feat/toasts-and-notifications 2026-09-19 17:33:14 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
kamilkrzywda (Kamil Krzywda) smysakowski
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenCode/Flight-Ops#19