OpenCode/Flight-Ops
2
0
Fork 0
Code Issues Pull Requests Actions Activity

v0.12.3 — remove unreliable curved-route e2e assertion (tile-simplified geometry) #12

Merged
kamilkrzywda merged 1 commits from fix/remove-unreliable-route-line-e2e-assertion into master 2026-09-19 09:47:19 +02:00
Conversation 0 Commits 1 Files Changed 3
+12 -17
kamilkrzywda commented 2026-09-19 09:46:25 +02:00
Owner
Copy Link
Copy Source

What

Removes ONLY the step-4 curved-route assertion from e2e/map-interactions.spec.ts ("plane markers move while flying…"): it polled querySourceFeatures('routes') expecting >2 coordinates, but MapLibre returns tile-simplified geometry at low zoom (2 coords instead of 25) — the check fails in CI and against the live instance even though the arc renders correctly (verified: v0.12.2 slerp code present in the live bundle; user visually confirmed curves).

All other steps of that test are kept (grounded draws no line, marker moves across polls, plane popup with status + route) — they're the only e2e coverage for map-side plane behavior. The great-circle arc stays fully unit-tested (lib/mapData.test.ts: 25 coords, exact endpoints, curvature).

Version

  • package.json → 0.12.3
  • CHANGELOG.md — v0.12.3 entry

Checks (local)

  • tsc --noEmit clean
  • unit: 234/234 passed
  • e2e not re-run locally (requires deploy); CI on this PR verifies against the isolated stack
## What Removes ONLY the step-4 curved-route assertion from `e2e/map-interactions.spec.ts` ("plane markers move while flying…"): it polled `querySourceFeatures('routes')` expecting >2 coordinates, but MapLibre returns **tile-simplified geometry at low zoom** (2 coords instead of 25) — the check fails in CI *and* against the live instance even though the arc renders correctly (verified: v0.12.2 slerp code present in the live bundle; user visually confirmed curves). All other steps of that test are kept (grounded draws no line, marker moves across polls, plane popup with status + route) — they're the only e2e coverage for map-side plane behavior. The great-circle arc stays fully unit-tested (`lib/mapData.test.ts`: 25 coords, exact endpoints, curvature). ## Version - `package.json` → **0.12.3** - `CHANGELOG.md` — v0.12.3 entry ## Checks (local) - `tsc --noEmit` clean - unit: 234/234 passed - e2e not re-run locally (requires deploy); CI on this PR verifies against the isolated stack
kamilkrzywda added 1 commit 2026-09-19 09:46:25 +02:00
test: v0.12.3 — remove unreliable curved-route e2e assertion (querySourceFeatures returns tile-simplified geometry at low zoom, so coordinate counts are not a valid signal; arc stays unit-tested in lib/mapData.test.ts) db998a9dfb
kamilkrzywda merged commit db998a9dfb into master 2026-09-19 09:47:19 +02:00
kamilkrzywda deleted branch fix/remove-unreliable-route-line-e2e-assertion 2026-09-19 09:47:19 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
kamilkrzywda (Kamil Krzywda) smysakowski
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenCode/Flight-Ops#12