OpenCode/Flight-Ops
2
0
Fork 0
Code Issues Pull Requests Actions Activity

test: v0.12.3 — remove unreliable curved-route e2e assertion (querySourceFeatures returns tile-simplified geometry at low zoom, so coordinate counts are not a valid signal; arc stays unit-tested in lib/mapData.test.ts)

Browse Source
This commit was merged in pull request #12.
This commit is contained in:
kamilkrzywda
2026-09-19 07:39:28 +00:00
parent 79cf5a05e2
commit db998a9dfb
3 changed files with 12 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
e2e/map-interactions.spec.ts
+7 -16
View File
@@ -170,7 +170,7 @@ test('airport popup shows name, ICAO, local time and generated weather', async (
expect(wText).toMatch(/\d+ kt/); // wind speed in knots
});
test('plane markers move while flying, the current leg draws a route line, and the plane popup shows status + route', async ({ page }) => {
test('plane markers move while flying and the plane popup shows status + route', async ({ page }) => {
test.setTimeout(600_000); // self-heal from a far airport (~4 min worst case at 60×) + main flight + cleanup
await page.goto('/');
@@ -238,21 +238,12 @@ test('plane markers move while flying, the current leg draws a route line, and t
const p2 = (await getState(page)).planes.find((p) => p.id === 'plane-starter')!;
expect(haversineKm(p1.lat, p1.lon, p2.lat, p2.lon)).toBeGreaterThan(0);
// 4) The route line for this flight exists in the routes source (v0.12.0: one line
// per flying plane's current leg, keyed by planeId) and is a CURVED arc — >2
// coordinates along the great circle, not a straight two-point chord (v0.12.2).
await expect
.poll(async () => {
const feats = (await sourceFeatures(page, 'routes')) as Array<{
properties: Record<string, unknown>;
geometry?: { type: string; coordinates: [number, number][] };
}>;
const f = feats.find((x) => x.properties.planeId === 'plane-starter');
return !!f && (f.geometry?.coordinates.length ?? 0) > 2;
}, { timeout: 15_000, message: 'waiting for the curved route line in the routes source' })
.toBe(true);
// (No map-side assertion on the drawn leg here: MapLibre's querySourceFeatures returns
// tile-simplified geometry at low zoom, so coordinate counts from it are unreliable —
// the v0.12.2 curved-arc check failed in CI and live while the arc rendered correctly.
// The arc itself stays covered by unit tests: lib/mapData.test.ts.)
// 5) Click the flying plane → status popup with model, status, fuel and the leg.
// 4) Click the flying plane → status popup with model, status, fuel and the leg.
// Fetch + project in one evaluate so the click lands on a fresh position (the
// marker drifts only ~1 px/s of screen space at scale 60).
const pt = await page.evaluate(async () => {
@@ -279,7 +270,7 @@ test('plane markers move while flying, the current leg draws a route line, and t
// The popup's route line is the plane's own leg: origin name → destination name.
await expect(page.getByTestId('plane-route')).toContainText(`${live.locationName} → ${live.destName}`);
// 6) Let the flight finish, then fly home so the live instance stays in its
// 5) Let the flight finish, then fly home so the live instance stays in its
// onboarding state (starter grounded at EDDF) for the other specs. The loaded
// package is delivered on arrival (in-deadline).
await expect