Remove insecure NODE_TLS_REJECT_UNAUTHORIZED=0 TLS workaround (follow-up to #56) #57

Merged
kamilkrzywda merged 1 commits from feat/meshmonitor-connection into main 2026-10-13 03:13:22 +02:00
Owner

What

PR #56 (MeshMonitor connection, v0.22.0) was merged from f6b884d, but a follow-up commit 25f99f0 that removes the NODE_TLS_REJECT_UNAUTHORIZED=0 workaround was only ever committed locally and was never pushed before the merge — so it is not in main yet.

The MeshMonitor gateway (https://meshmonitor.kkhost.pl) uses a valid Let's Encrypt certificate (issuer O = Let's Encrypt, CN = YE1), verified with a normal (no -k) request → HTTP 200. So the NODE_TLS_REJECT_UNAUTHORIZED=0 flag is unnecessary and a security downgrade (it disabled TLS cert verification for all outbound connections in the container, including the LLM and opencode services).

This PR brings in that single commit: drops the flag + 'self-signed' comments from docker-compose.yml and src/main.ts, and corrects the v0.22.0 CHANGELOG wording. No version bump — it completes the v0.22.0 MeshMonitor connection work.

Verified: npm run build clean; npm test 245/245 green.

## What PR #56 (MeshMonitor connection, v0.22.0) was merged from `f6b884d`, but a follow-up commit `25f99f0` that **removes the `NODE_TLS_REJECT_UNAUTHORIZED=0`** workaround was only ever committed locally and was never pushed before the merge — so it is **not** in `main` yet. The MeshMonitor gateway (`https://meshmonitor.kkhost.pl`) uses a **valid Let's Encrypt certificate** (issuer `O = Let's Encrypt, CN = YE1`), verified with a normal (no `-k`) request → HTTP 200. So the `NODE_TLS_REJECT_UNAUTHORIZED=0` flag is **unnecessary** and a **security downgrade** (it disabled TLS cert verification for *all* outbound connections in the container, including the LLM and opencode services). This PR brings in that single commit: drops the flag + 'self-signed' comments from `docker-compose.yml` and `src/main.ts`, and corrects the v0.22.0 CHANGELOG wording. No version bump — it completes the v0.22.0 MeshMonitor connection work. Verified: `npm run build` clean; `npm test` 245/245 green.
kamilkrzywda added 1 commit 2026-10-13 03:13:07 +02:00
Remove insecure NODE_TLS_REJECT_UNAUTHORIZED=0 TLS workaround
CI / build + unit (pull_request) Successful in 46s
25f99f04ad
The MeshMonitor gateway uses a valid Let's Encrypt certificate, so
standard TLS certificate verification already works — no workaround
needed. The flag was a security downgrade: it disabled cert verification
for ALL outbound connections in the container (including the LLM and
opencode services), not just the gateway.

- docker-compose.yml: drop NODE_TLS_REJECT_UNAUTHORIZED env line + comment
- src/main.ts: drop process.env.NODE_TLS_REJECT_UNAUTHORIZED + comments
- CHANGELOG.md: correct the v0.22.0 Docker bullet wording

Part of the already-open MeshMonitor connection work (PR #56): no version
bump, no new changelog section.

Co-Authored-By: OpenCode <noreply@opencode.ai>
kamilkrzywda merged commit a7df87a5a1 into main 2026-10-13 03:13:22 +02:00
Sign in to join this conversation.
No Reviewers
No labels
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenCode/MeshBot#57