Compare commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
023cd3eef3 | ||
|
|
c5a2815c01 | ||
|
|
55e59d4963 | ||
|
|
9d4c9594af | ||
|
|
d375f2a943 | ||
|
|
931b42bb1e | ||
|
|
2b2e494023 | ||
|
|
4ae932befe | ||
|
|
ff57f3eae1 | ||
|
|
b7b2044d84 | ||
|
|
e62f831ee5 | ||
|
|
bd18bdfd8a | ||
|
|
c33f4613b5 | ||
|
|
88b617f8b7 | ||
|
|
34e7bfe0bb |
@@ -1,5 +1,50 @@
|
|||||||
# Changelog
|
# Changelog
|
||||||
|
|
||||||
|
## v0.19.0 — 2026-09-25 18:03
|
||||||
|
|
||||||
|
- New LLM client module (`src/llm`): `LlmService` speaks the OpenAI-compatible chat-completions API of the local server at `LLM_API_BASE` (default `http://192.168.1.70:1111/v1`, no auth) using native fetch only — no new dependencies. Plain feature module (`LlmModule`), wired into `app.module.ts`; no Mesh/Schedule dependency.
|
||||||
|
- Methods: `listModels()` (GET `/models` → `data[].id` strings), `chat(messages, opts?)` (POST `/chat/completions` with `{ model, messages, ...opts }` → `choices[0].message.content`; non-2xx throws an Error carrying the HTTP status and a short body snippet; malformed responses without content throw too), and `summarize(text)` — thin wrapper over `chat()` with system prompt "Summarize the following text concisely." (the stated primary use).
|
||||||
|
- Env: `LLM_API_BASE` (default `http://192.168.1.70:1111/v1`), `LLM_MODEL` (default `qwen3.8-27b`), `LLM_TIMEOUT_MS` (default `60000` — the local 27B model can be slow; applied via `AbortSignal.timeout`).
|
||||||
|
- Tests: +4 specs — listModels parses ids, chat passes model/messages/opts through and returns content, chat throws on non-2xx with status in the message, summarize sends system prompt + user text.
|
||||||
|
|
||||||
|
## v0.18.1 — 2026-09-25 17:30
|
||||||
|
|
||||||
|
- Command replies now ride `MeshService.respond(id, reply)` instead of direct `sendText` routing: when a handler returns a non-empty string and the trigger has a packet id, the reply is auto-routed (rx → DM back to the original sender unless the original was a broadcast; tx → its destination) on the **original message's channel** with `replyId = id`, so the recipient app renders it as a threaded quote of the triggering packet. `COMMAND_CHANNEL` is now only the trigger/listen gate — the reply channel comes from the record.
|
||||||
|
- Defensive fallback: when the trigger has no packet id (never happens in production — `MeshService` always passes `pkt.id`), the legacy sendText routing on `COMMAND_CHANNEL` (directed DM or broadcast) still sends the reply out. Failure handling unchanged: a failing handler or respond only logs a warn, never crashes.
|
||||||
|
- Tests: 121 → 124 specs — unit cases now mock `mesh.respond` (id present → `respond(id, reply)` with no sendText; id absent → legacy DM/broadcast fallback on the command channel), plus a failing-respond swallow case; e2e over the fake bridge asserts wire-level threading for both shapes: `#ping` broadcast on ch2 → `#pong!` broadcast on ch2 with `replyId` = ping packet id, and `#ping` DM → `#pong!` DM to the sender on ch2 with `replyId` set. All gate tests (case/whitespace/channel/env override) kept.
|
||||||
|
- The wire-decode test helper `outboundPackets()` moved from `mesh.service.spec.ts` into `fake-bridge.ts` so both specs share it.
|
||||||
|
- Docs: AGENTS.md "Other" bullet and MESHTASTIC.md describe the respond() auto-routing + threading; README env list unchanged (`COMMAND_CHANNEL` still exists, now meaning trigger channel only).
|
||||||
|
|
||||||
|
## v0.18.0 — 2026-09-25 17:08
|
||||||
|
|
||||||
|
- New channel-index-2 auto-responder (`src/commands`): an event-driven `CommandService` reacts to decoded rx text on `COMMAND_CHANNEL` (env, default `2`) and dispatches exact `#command` matches (case-sensitive, surrounding whitespace trimmed) through a single-registration-point registry — handlers registered in the constructor via `register(name, fn)` receive `{ text, from?, id? }` and return a reply string or void (= no reply). First command: `#ping` → replies `#pong!`.
|
||||||
|
- Reply routing v1: directed DM back to the sender when present, else broadcast — always on `COMMAND_CHANNEL`, via the existing `MeshService.sendText(to, text, undefined, channel)` path. No threading/`replyId` in v1. A failing handler or send only logs a warn; it never crashes the app.
|
||||||
|
- Wiring: `MeshService` gains an optional third constructor param (`commands?`) plus a public `attachCommands()` — the rx handler calls `this.commands?.onRx(channel, text, from, id)` right after `notifyRx()`, fire-and-forget like the notifier. DI note: a constructor-level MeshService ↔ CommandService cycle leaves one side null in NestJS 12's injector (verified empirically), so `CommandModule` provides `CommandService` via a factory that injects `MeshService` and attaches itself as a side effect — no `forwardRef`, no module cycle.
|
||||||
|
- Tests: 106 → 121 specs — directed/broadcast replies on ch2, non-command-channel and non-command text ignored, case-sensitive exact match, whitespace trimming, `COMMAND_CHANNEL` override, void handler = no reply, extensibility (second registered command), failing handler/send swallowed; end-to-end over the fake bridge (`#ping` on ch2 answered with a directed `#pong!` tx record, ch3 not answered); DI spec asserts both sides of the wiring resolve to real instances.
|
||||||
|
- Docs: AGENTS.md "Other" bullet + MESHTASTIC.md "Channels & sending" describe the auto-responder; README env list gains `COMMAND_CHANNEL`.
|
||||||
|
|
||||||
|
## v0.17.0 — 2026-09-25 16:18
|
||||||
|
|
||||||
|
- The mesh→agent notify gate is now a comma-separated multi-channel list: `MESH_NOTIFY_CHANNEL` (default `3`) parses to channel indices, each entry trimmed, empty/invalid entries ignored (`"3,0"` → `[3, 0]`).
|
||||||
|
- ch0 DM-only filtering: ch0 is the shared default channel where other users talk — only directed messages (both sender and recipient present) notify there; ch0 broadcasts and undirected traffic are ignored. Synthetic injections (`POST /api/messages`, `injectMessage`) ride ch0 by design and stay exempt from the rule, so they still notify when 0 is in the list.
|
||||||
|
- `notifyRx()` gains optional params: `to?` (the packet's destination, now passed through from the rx handler) and an `injected` flag; the field is renamed `notifyChannel` → `notifyChannels`. Self-echo filter unchanged.
|
||||||
|
- Tests: 102 → 106 specs — multi-list match/non-match, ch0 broadcast ignored even with 0 in the list, ch0 directed DM notified, ch0 injection notified via a multi-list, invalid env entries ignored.
|
||||||
|
- Docs: AGENTS.md + MESHTASTIC.md "Notifications" describe the list semantics and the ch0 DM-only rule; README env bullet/forwarded/notifier lines and the controller's `GET /api/forwarded` description kept in sync. Local `.env` (gitignored) now `MESH_NOTIFY_CHANNEL=3,0`.
|
||||||
|
|
||||||
|
## v0.16.0 — 2026-09-25 15:49
|
||||||
|
|
||||||
|
- New `GET /api/forwarded`: the last 100 rx texts that passed the notify gate and were forwarded to opencode, newest first as `{ id, from?, text, channel, at }[]` — the id is the packet id (real rx) or generated record id (injected), `from` omitted when there is no sender. Backed by an in-memory ring buffer in `MeshService`, recorded in `notifyRx()` at hand-off: after the channel gate (`MESH_NOTIFY_CHANNEL`) and self-echo filter pass, right before the `OpencodeService.notify()` call; an unwired notifier records nothing (a notifier disabled internally still counts — MeshService cannot see its enabled flag). In-memory only, reset on restart. Purpose: a replying agent gets exactly the notified subset with packet ids instead of scanning all of `/api/messages`.
|
||||||
|
- Tests: 96 → 102 specs — ring records on a gated forward (shape + newest-first via `forwarded()`), no record on channel mismatch / self-echo / unwired notifier, injected messages count when they pass the gate (`from` omitted when absent), cap at 100 with oldest evicted.
|
||||||
|
- Docs: README endpoint bullet + curl example; AGENTS.md endpoints list kept in sync with the controller.
|
||||||
|
|
||||||
|
## v0.15.0 — 2026-09-25 15:40
|
||||||
|
|
||||||
|
- New `POST /api/respond` endpoint and MCP `respond(messageId, content)` tool: reply to an earlier message by packet id with automatic routing — the caller never thinks about where it goes. rx records are answered as a DM back to the original sender unless the original was a broadcast (then the reply is a broadcast), tx records go to their own destination, injected messages without a sender get a broadcast. The reply always rides the record's channel and carries `replyId = messageId`, so the recipient app renders it as a threaded quote of that packet. Returns `{ id }`; 400 on invalid messageId/content, 404 when no message has the given id (in memory or in SQLite), 503 when the bridge is down; MCP tool errors carry the same messages.
|
||||||
|
- Captured rx history records now persist their destination (`to: pkt.to`) — no schema change needed: the `to_node` column already existed for tx rows and flush/seed already round-tripped it, so captured packets simply fill it in too. This is what lets a reply tell a DM from a broadcast original.
|
||||||
|
- The opencode notifier wrapper now includes the packet id: msg = `New mesh message (id <packetId>)[ from node <n>]: "<text>" — please react to it.` — the id is the rx packet's id, or the generated record id for injected messages; the `from node` part is still omitted when absent.
|
||||||
|
- Tests: 88 → 96 specs. New: captured-rx row persists `to_node`; six `respond` service specs (rx DM → directed send back to sender on the original channel with wire-level replyId, broadcast original → broadcast reply, tx record → its destination/channel, SQLite fallback when the record is outside the in-memory buffer, 404 memory+DB miss, 400 validation matrix); MCP `respond` wiring spec (routing + unknown-id/out-of-range/empty-content tool errors) and the tool list grows to ten.
|
||||||
|
- Docs: README gains the endpoint bullet, a curl example, the MCP tool entry and the updated notifier wrapper format; AGENTS.md endpoints/MCP/notifier lines kept in sync with the controller.
|
||||||
|
|
||||||
## v0.14.0 — 2026-09-25 14:11
|
## v0.14.0 — 2026-09-25 14:11
|
||||||
|
|
||||||
- The standalone Python notify forwarder (`ops/forwarder`, compose service `forwarder`) is gone: its logic now lives in-process as a new `src/opencode` module — an `@Injectable()` `OpencodeService` registered in `MeshModule` and injected into `MeshService`. When an RX text lands on channel `MESH_NOTIFY_CHANNEL` (default 3), `MeshService.notifyRx()` calls `void this.opencode.notify(text, from)` instead of the old webhook POST; the channel gate and self-echo filter stay in `MeshService`, everything else (workspace/session resolution, message POST, retries) moved into the service.
|
- The standalone Python notify forwarder (`ops/forwarder`, compose service `forwarder`) is gone: its logic now lives in-process as a new `src/opencode` module — an `@Injectable()` `OpencodeService` registered in `MeshModule` and injected into `MeshService`. When an RX text lands on channel `MESH_NOTIFY_CHANNEL` (default 3), `MeshService.notifyRx()` calls `void this.opencode.notify(text, from)` instead of the old webhook POST; the channel gate and self-echo filter stay in `MeshService`, everything else (workspace/session resolution, message POST, retries) moved into the service.
|
||||||
|
|||||||
+3
-1
@@ -22,7 +22,9 @@ Rules for how mesh-bot communicates over Meshtastic and how the agent should rea
|
|||||||
|
|
||||||
- All bot sends ride channel index 3 ("test") by design (`MESH_SEND_CHANNEL`, default "3") — never the primary channel.
|
- All bot sends ride channel index 3 ("test") by design (`MESH_SEND_CHANNEL`, default "3") — never the primary channel.
|
||||||
- Broadcasts show up in `/api/messages` as `failed` / `NO_RESPONSE` on this firmware — known quirk, not a real failure; the message was transmitted.
|
- Broadcasts show up in `/api/messages` as `failed` / `NO_RESPONSE` on this firmware — known quirk, not a real failure; the message was transmitted.
|
||||||
|
- Channel index 2 carries the bot's auto-responder (`COMMAND_CHANNEL`, default 2): exact `#command` texts (case-sensitive) on that channel get an automatic reply routed through `MeshService.respond()` — DM back to the original sender, broadcast when the original was a broadcast — riding the original message's channel as a threaded quote (`replyId` = the trigger packet id). Currently only `#ping` → `#pong!`. This is a mechanical echo for testing the mesh path; it is not the agent and does not mean the owner has seen anything.
|
||||||
|
|
||||||
## Notifications (mesh → agent)
|
## Notifications (mesh → agent)
|
||||||
|
|
||||||
- RX text on the notify channel (`MESH_NOTIFY_CHANNEL`, default 3) is pushed in-process to the live opencode session by `OpencodeService` (workspace/session resolved per request from the opencode API; disabled without `OPENCODE_USER`/`OPENCODE_PASS`). Messages from our own node are never notified (self-echo filter, v0.11.2).
|
- RX text on a channel in the notify list (`MESH_NOTIFY_CHANNEL`, comma-separated indices, default 3) is pushed in-process to the live opencode session by `OpencodeService` (workspace/session resolved per request from the opencode API; disabled without `OPENCODE_USER`/`OPENCODE_PASS`). Messages from our own node are never notified (self-echo filter, v0.11.2).
|
||||||
|
- Channel 0 is the shared default channel where other users talk: it carries real DMs when both sender and recipient are present, and the bot listens there too — but only directed messages trigger notifications; ch0 broadcasts are ignored. Synthetic injected messages (channel 0) are exempt from this rule.
|
||||||
|
|||||||
@@ -27,10 +27,12 @@ All API endpoints live under the `/api` prefix:
|
|||||||
|
|
||||||
- `GET /api/status` — `{ connected, myNodeNum, host, port }`
|
- `GET /api/status` — `{ connected, myNodeNum, host, port }`
|
||||||
- `POST /api/send` — body `{ "text": "...", "to"?: <node number | node name | "!b" | "broadcast">, "replyId"?: <packet id> }`, returns `{ id }`. Numbers pass through as-is (integer in 1..0xffffffff); names resolve like `GET /api/nodes/:id` (exact long/short name, then unique substring) — unknown or ambiguous targets are a 400. Optional `replyId` (integer in 1..0xffffffff) references an earlier message's packet id from `GET /api/messages` — when set, the recipient app renders the text as a threaded reply/quote of that packet
|
- `POST /api/send` — body `{ "text": "...", "to"?: <node number | node name | "!b" | "broadcast">, "replyId"?: <packet id> }`, returns `{ id }`. Numbers pass through as-is (integer in 1..0xffffffff); names resolve like `GET /api/nodes/:id` (exact long/short name, then unique substring) — unknown or ambiguous targets are a 400. Optional `replyId` (integer in 1..0xffffffff) references an earlier message's packet id from `GET /api/messages` — when set, the recipient app renders the text as a threaded reply/quote of that packet
|
||||||
|
- `POST /api/respond` — body `{ "messageId": <packet id>, "content": "..." }`, returns `{ id }`. Reply to an earlier message by packet id (from `GET /api/messages`) with automatic routing: rx records are answered as a DM back to the original sender unless the original was a broadcast (then the reply is a broadcast), tx records go to their destination, injected messages without a sender get a broadcast. The reply always rides the record's channel and carries `replyId = messageId`, so the recipient app renders it as a threaded quote of that packet. 400 on invalid messageId/content, 404 when no message has the given id (in memory or in SQLite), 503 when the bridge is down
|
||||||
- `GET /api/channels` — the device's Meshtastic channels as `{ index, name, uplinkEnabled, downlinkEnabled }[]` (psk/keys are redacted; empty until the initial sync completes)
|
- `GET /api/channels` — the device's Meshtastic channels as `{ index, name, uplinkEnabled, downlinkEnabled }[]` (psk/keys are redacted; empty until the initial sync completes)
|
||||||
- `GET /api/device` — device info captured during the initial sync: `{ myNodeNum, firmwareVersion?, metadata?, localConfig: {<section>: ...}, moduleConfig: {<module>: ...} }`. Key material is never exposed (security publicKey/privateKey/adminKey and network wifiPsk are replaced with `"REDACTED"`); in-memory only, reset on every bridge reconnect
|
- `GET /api/device` — device info captured during the initial sync: `{ myNodeNum, firmwareVersion?, metadata?, localConfig: {<section>: ...}, moduleConfig: {<module>: ...} }`. Key material is never exposed (security publicKey/privateKey/adminKey and network wifiPsk are replaced with `"REDACTED"`); in-memory only, reset on every bridge reconnect
|
||||||
- `GET /api/messages` — message history, newest first: inbound text (`dir:'rx'`, with `from`) and our sends (`dir:'tx'`, with `to` + `status`). tx records start `pending` and move to `delivered`/`failed` (with human-readable `ackError`) when the routing ACK/NACK arrives; broadcasts stay `pending` because firmware strips want_ack before TX. Backed by SQLite: the in-memory buffer (last 100) is seeded from the database on startup and re-upserted every second, so history survives process restarts and bridge reconnects; the database keeps the newest 1000 rows
|
- `GET /api/messages` — message history, newest first: inbound text (`dir:'rx'`, with `from` and `to`) and our sends (`dir:'tx'`, with `to` + `status`). tx records start `pending` and move to `delivered`/`failed` (with human-readable `ackError`) when the routing ACK/NACK arrives; broadcasts stay `pending` because firmware strips want_ack before TX. Backed by SQLite: the in-memory buffer (last 100) is seeded from the database on startup and re-upserted every second, so history survives process restarts and bridge reconnects; the database keeps the newest 1000 rows
|
||||||
- `POST /api/messages` — body `{ "text": "...", "from"?: <node number> }`, returns `{ id }`. Synthetic inbox injection for external triggers: records an rx entry in the history as if received on the mesh (channel 0) so external systems can push messages to trigger communication later. NOT transmitted over RF; appears in `GET /api/messages` like any other rx message
|
- `POST /api/messages` — body `{ "text": "...", "from"?: <node number> }`, returns `{ id }`. Synthetic inbox injection for external triggers: records an rx entry in the history as if received on the mesh (channel 0) so external systems can push messages to trigger communication later. NOT transmitted over RF; appears in `GET /api/messages` like any other rx message
|
||||||
|
- `GET /api/forwarded` — the last 100 rx texts that passed the notify gate and were forwarded to opencode, newest first as `{ id, from?, text, channel, at }[]`: channel in the `MESH_NOTIFY_CHANNEL` list (ch0: directed DMs only), not a self-echo. The id is the packet id (real rx) or generated record id (injected); `from` omitted when there is no sender. In-memory only — reset on restart
|
||||||
- `GET /api/telemetry` — telemetry history, newest first: live `TELEMETRY_APP` packets from any node as `{ from, at /* epoch ms */, kind, data }[]`. `kind` is the `meshtastic.Telemetry` oneof case name (`deviceMetrics`, `environmentMetrics`, `airQualityMetrics`, `powerMetrics`, `localStats`, `healthMetrics`, `hostMetrics` or `trafficManagementStats`) and `data` carries that variant's payload (proto uint64 fields as decimal strings; unset optional fields omitted). In-memory only, last 100, reset on every bridge reconnect
|
- `GET /api/telemetry` — telemetry history, newest first: live `TELEMETRY_APP` packets from any node as `{ from, at /* epoch ms */, kind, data }[]`. `kind` is the `meshtastic.Telemetry` oneof case name (`deviceMetrics`, `environmentMetrics`, `airQualityMetrics`, `powerMetrics`, `localStats`, `healthMetrics`, `hostMetrics` or `trafficManagementStats`) and `data` carries that variant's payload (proto uint64 fields as decimal strings; unset optional fields omitted). In-memory only, last 100, reset on every bridge reconnect
|
||||||
- `GET /api/nodes` — known mesh nodes as `{ num, longName?, shortName?, hwModel?, batteryLevel?, lastHeard: number|null, position?: { lat, lon, alt? }, snr?, hopsAway?, viaMqtt? }[]`, sorted by node number. Collected during the initial sync plus live position updates; names/hwModel/battery appear only when reported, `lastHeard` is epoch seconds (null = never heard), `position` only when both coordinates are known, and snr/hopsAway/viaMqtt only when carried by the NodeInfo
|
- `GET /api/nodes` — known mesh nodes as `{ num, longName?, shortName?, hwModel?, batteryLevel?, lastHeard: number|null, position?: { lat, lon, alt? }, snr?, hopsAway?, viaMqtt? }[]`, sorted by node number. Collected during the initial sync plus live position updates; names/hwModel/battery appear only when reported, `lastHeard` is epoch seconds (null = never heard), `position` only when both coordinates are known, and snr/hopsAway/viaMqtt only when carried by the NodeInfo
|
||||||
- `GET /api/nodes/:id` — one node looked up by exact node number (numbers or numeric strings), then case-insensitive exact long/short name, else the unique case-insensitive substring match; 404 when nothing or more than one node matches
|
- `GET /api/nodes/:id` — one node looked up by exact node number (numbers or numeric strings), then case-insensitive exact long/short name, else the unique case-insensitive substring match; 404 when nothing or more than one node matches
|
||||||
@@ -42,10 +44,12 @@ Interactive API docs (Scalar) are served at `/`, with the OpenAPI JSON at
|
|||||||
curl http://localhost:3000/api/status
|
curl http://localhost:3000/api/status
|
||||||
curl -X POST http://localhost:3000/api/send -H 'content-type: application/json' -d '{"text":"hi"}'
|
curl -X POST http://localhost:3000/api/send -H 'content-type: application/json' -d '{"text":"hi"}'
|
||||||
curl -X POST http://localhost:3000/api/send -H 'content-type: application/json' -d '{"to":123456789,"text":"hello"}'
|
curl -X POST http://localhost:3000/api/send -H 'content-type: application/json' -d '{"to":123456789,"text":"hello"}'
|
||||||
|
curl -X POST http://localhost:3000/api/respond -H 'content-type: application/json' -d '{"messageId":123456789,"content":"on my way"}'
|
||||||
curl http://localhost:3000/api/channels
|
curl http://localhost:3000/api/channels
|
||||||
curl http://localhost:3000/api/device
|
curl http://localhost:3000/api/device
|
||||||
curl http://localhost:3000/api/messages
|
curl http://localhost:3000/api/messages
|
||||||
curl -X POST http://localhost:3000/api/messages -H 'content-type: application/json' -d '{"text":"external trigger"}'
|
curl -X POST http://localhost:3000/api/messages -H 'content-type: application/json' -d '{"text":"external trigger"}'
|
||||||
|
curl http://localhost:3000/api/forwarded
|
||||||
curl http://localhost:3000/api/telemetry
|
curl http://localhost:3000/api/telemetry
|
||||||
curl http://localhost:3000/api/nodes
|
curl http://localhost:3000/api/nodes
|
||||||
curl http://localhost:3000/api/nodes/kamil
|
curl http://localhost:3000/api/nodes/kamil
|
||||||
@@ -64,10 +68,12 @@ channel. Override with `MESH_SEND_CHANNEL`.
|
|||||||
The bot also exposes an MCP (Model Context Protocol) endpoint at
|
The bot also exposes an MCP (Model Context Protocol) endpoint at
|
||||||
`POST /mcp` (outside the `/api` prefix), served in-process over the SDK's
|
`POST /mcp` (outside the `/api` prefix), served in-process over the SDK's
|
||||||
Streamable HTTP transport in stateless mode. It maps 1:1 to the REST
|
Streamable HTTP transport in stateless mode. It maps 1:1 to the REST
|
||||||
endpoints — no new logic, same channel pinning:
|
endpoints — no new logic; sends ride the pinned channel like their REST
|
||||||
|
counterparts (`respond` rides the original message's channel):
|
||||||
|
|
||||||
- `mesh_status` — bridge connection state (`{ connected, myNodeNum, host, port }`)
|
- `mesh_status` — bridge connection state (`{ connected, myNodeNum, host, port }`)
|
||||||
- `send_message(text, to?, replyId?)` — send a text message; `to` resolves like `POST /api/send` (omitted/""/"!b"/"broadcast" → broadcast, number or numeric string → node number, else name lookup); optional `replyId` makes the message render as a threaded reply/quote of that packet id from `get_messages`; returns `{ id }`; unknown/ambiguous targets are tool errors
|
- `send_message(text, to?, replyId?)` — send a text message; `to` resolves like `POST /api/send` (omitted/""/"!b"/"broadcast" → broadcast, number or numeric string → node number, else name lookup); optional `replyId` makes the message render as a threaded reply/quote of that packet id from `get_messages`; returns `{ id }`; unknown/ambiguous targets are tool errors
|
||||||
|
- `respond(messageId, content)` — reply to an earlier message by packet id (from `get_messages`) with automatic routing: rx → DM back to the sender unless the original was a broadcast, tx → its destination, no-sender injected records → broadcast; rides the record's channel with `replyId = messageId` (threaded quote); returns `{ id }`; invalid args or an unknown id are tool errors
|
||||||
- `list_channels` — device channels (keys redacted)
|
- `list_channels` — device channels (keys redacted)
|
||||||
- `list_nodes` — known nodes as lean summaries
|
- `list_nodes` — known nodes as lean summaries
|
||||||
- `get_node(id)` — one node by number or name; tool error when missing/ambiguous
|
- `get_node(id)` — one node by number or name; tool error when missing/ambiguous
|
||||||
@@ -99,7 +105,7 @@ Hourly cron job (`src/weather`): fetches current conditions for Lublin from [Ope
|
|||||||
|
|
||||||
## Opencode notifier
|
## Opencode notifier
|
||||||
|
|
||||||
In-process service (`src/opencode`, no separate compose service): when an rx text message arrives on `MESH_NOTIFY_CHANNEL`, it pushes it to the mesh-bot folder's live opencode session (Basic auth). The opencode workspace UUID is regenerated on host restarts, so the notifier resolves it dynamically per request via the opencode API: `GET {OPENCODE_API}/api/workspaces` → match by `path == OPENCODE_WORKSPACE_PATH` (fallback name `mesh-bot`, status `ready` preferred when several match) → `GET {proxyPath}/session` → most recently updated session (`time.updated`; first entry if absent). No caching — messages are rare. The message POST body is exactly `{"parts":[{"type":"text","text":msg}]}` with msg = `New mesh message[ from node <n>]: "<text>" — please react to it.` (the `from node` part omitted when there is no sender). opencode accepts the message immediately but holds the HTTP response until the agent turn finishes, so a 15 s read timeout on that POST means **delivered** — treated as success, never retried; workspace/session GET failures are retried up to 3 times with backoff (2 s / 10 s / 30 s) before being dropped.
|
In-process service (`src/opencode`, no separate compose service): when an rx text message arrives on a channel in the `MESH_NOTIFY_CHANNEL` comma-separated list, it pushes it to the mesh-bot folder's live opencode session (Basic auth). On ch0 only directed DMs are pushed — broadcasts there are ignored. The opencode workspace UUID is regenerated on host restarts, so the notifier resolves it dynamically per request via the opencode API: `GET {OPENCODE_API}/api/workspaces` → match by `path == OPENCODE_WORKSPACE_PATH` (fallback name `mesh-bot`, status `ready` preferred when several match) → `GET {proxyPath}/session` → most recently updated session (`time.updated`; first entry if absent). No caching — messages are rare. The message POST body is exactly `{"parts":[{"type":"text","text":msg}]}` with msg = `New mesh message (id <packetId>)[ from node <n>]: "<text>" — please react to it.` (the `from node` part omitted when there is no sender; the packet id is the rx packet's id, or the generated record id for injected messages). opencode accepts the message immediately but holds the HTTP response until the agent turn finishes, so a 15 s read timeout on that POST means **delivered** — treated as success, never retried; workspace/session GET failures are retried up to 3 times with backoff (2 s / 10 s / 30 s) before being dropped.
|
||||||
|
|
||||||
Config lives in `.env` (gitignored) and is passed via compose environment — credentials are never committed to the repo:
|
Config lives in `.env` (gitignored) and is passed via compose environment — credentials are never committed to the repo:
|
||||||
|
|
||||||
@@ -114,10 +120,14 @@ Config lives in `.env` (gitignored) and is passed via compose environment — cr
|
|||||||
- `MESH_PORT` (default `4403`) — bridge port
|
- `MESH_PORT` (default `4403`) — bridge port
|
||||||
- `MESH_RECONNECT_MS` (default `5000`) — reconnect interval in ms
|
- `MESH_RECONNECT_MS` (default `5000`) — reconnect interval in ms
|
||||||
- `MESH_SEND_CHANNEL` (default `3`) — channel index all sends target (`test`; never the primary channel)
|
- `MESH_SEND_CHANNEL` (default `3`) — channel index all sends target (`test`; never the primary channel)
|
||||||
- `MESH_NOTIFY_CHANNEL` (default `3`) — channel index whose rx texts trigger the opencode notifier (see "Opencode notifier"; synthetic injected messages, channel 0, trigger it too when set to match; messages from our own node are never notified)
|
- `MESH_NOTIFY_CHANNEL` (default `3`) — comma-separated list of channel indices whose rx texts trigger the opencode notifier (see "Opencode notifier"; on ch0 only directed DMs notify, broadcasts ignored; synthetic injected messages, channel 0, are exempt and trigger it when `0` is in the list; messages from our own node are never notified)
|
||||||
|
- `COMMAND_CHANNEL` (default `2`) — channel index of the auto-responder: exact `#command` texts on that channel get an automatic reply (directed back to the sender, else broadcast); currently only `#ping` → `#pong!`
|
||||||
- `MESH_DB_PATH` (default `./data/mesh-bot.db`) — SQLite file backing the message history (parent dir created if missing; in Docker, mounted at `/app/data` via a named volume so it survives container recreation)
|
- `MESH_DB_PATH` (default `./data/mesh-bot.db`) — SQLite file backing the message history (parent dir created if missing; in Docker, mounted at `/app/data` via a named volume so it survives container recreation)
|
||||||
- `MESH_POLL_MS` (default `1000`) — how often the poller re-upserts the message history into SQLite and prunes rows beyond the newest 1000
|
- `MESH_POLL_MS` (default `1000`) — how often the poller re-upserts the message history into SQLite and prunes rows beyond the newest 1000
|
||||||
- `PORT` (default `3000`) — HTTP listen port
|
- `PORT` (default `3000`) — HTTP listen port
|
||||||
|
- `LLM_API_BASE` (default `http://192.168.1.70:1111/v1`) — OpenAI-compatible LLM server base URL used by the in-process `LlmService` (`src/llm`; no auth)
|
||||||
|
- `LLM_MODEL` (default `qwen3.8-27b`) — model id sent to `/chat/completions`
|
||||||
|
- `LLM_TIMEOUT_MS` (default `60000`) — per-request timeout for LLM calls (the local 27B model can be slow)
|
||||||
|
|
||||||
Note: the serial bridge accepts only ONE client at a time — if another app is
|
Note: the serial bridge accepts only ONE client at a time — if another app is
|
||||||
connected to the radio, this bot will not get a connection.
|
connected to the radio, this bot will not get a connection.
|
||||||
|
|||||||
+1
-1
@@ -1,6 +1,6 @@
|
|||||||
{
|
{
|
||||||
"name": "mesh-bot",
|
"name": "mesh-bot",
|
||||||
"version": "0.14.0",
|
"version": "0.19.0",
|
||||||
"description": "",
|
"description": "",
|
||||||
"author": "",
|
"author": "",
|
||||||
"private": true,
|
"private": true,
|
||||||
|
|||||||
+9
-1
@@ -1,9 +1,17 @@
|
|||||||
import { Module } from '@nestjs/common';
|
import { Module } from '@nestjs/common';
|
||||||
import { BatteryAlertModule } from './battery/battery.module.js';
|
import { BatteryAlertModule } from './battery/battery.module.js';
|
||||||
|
import { CommandModule } from './commands/command.module.js';
|
||||||
|
import { LlmModule } from './llm/llm.module.js';
|
||||||
import { MeshModule } from './mesh/mesh.module.js';
|
import { MeshModule } from './mesh/mesh.module.js';
|
||||||
import { WeatherModule } from './weather/weather.module.js';
|
import { WeatherModule } from './weather/weather.module.js';
|
||||||
|
|
||||||
@Module({
|
@Module({
|
||||||
imports: [MeshModule, WeatherModule, BatteryAlertModule],
|
imports: [
|
||||||
|
MeshModule,
|
||||||
|
WeatherModule,
|
||||||
|
BatteryAlertModule,
|
||||||
|
CommandModule,
|
||||||
|
LlmModule,
|
||||||
|
],
|
||||||
})
|
})
|
||||||
export class AppModule {}
|
export class AppModule {}
|
||||||
|
|||||||
@@ -0,0 +1,22 @@
|
|||||||
|
import { Module } from '@nestjs/common';
|
||||||
|
import { MeshModule } from '../mesh/mesh.module.js';
|
||||||
|
import { MeshService } from '../mesh/mesh.service.js';
|
||||||
|
import { CommandService } from './command.service.js';
|
||||||
|
|
||||||
|
@Module({
|
||||||
|
imports: [MeshModule], // one-way only — the reverse edge is wired in the factory below, not via DI
|
||||||
|
providers: [
|
||||||
|
{
|
||||||
|
provide: CommandService,
|
||||||
|
useFactory: (mesh: MeshService) => {
|
||||||
|
const commands = new CommandService(mesh);
|
||||||
|
// break the cycle: MeshService can't inject us (its own factory would deadlock on this edge), so attach ourselves once we exist — mesh is guaranteed created here because it's our injected dependency
|
||||||
|
mesh.attachCommands(commands);
|
||||||
|
return commands;
|
||||||
|
},
|
||||||
|
inject: [MeshService],
|
||||||
|
},
|
||||||
|
],
|
||||||
|
exports: [CommandService],
|
||||||
|
})
|
||||||
|
export class CommandModule {}
|
||||||
@@ -0,0 +1,250 @@
|
|||||||
|
import { beforeEach, describe, expect, it, vi } from 'vitest';
|
||||||
|
import { BROADCAST_ADDR } from '../mesh/codec.js';
|
||||||
|
import {
|
||||||
|
startBridge,
|
||||||
|
textPacketFrame,
|
||||||
|
waitFor,
|
||||||
|
outboundPackets,
|
||||||
|
KAMIL_NUM,
|
||||||
|
} from '../mesh/fake-bridge.js';
|
||||||
|
import type { MeshService } from '../mesh/mesh.service.js';
|
||||||
|
import { MeshService as RealMeshService } from '../mesh/mesh.service.js';
|
||||||
|
import { CommandService } from './command.service.js';
|
||||||
|
|
||||||
|
function makeService(
|
||||||
|
sendText?: ReturnType<typeof vi.fn>,
|
||||||
|
respond?: ReturnType<typeof vi.fn>,
|
||||||
|
): [CommandService, MeshService] {
|
||||||
|
const mesh = {
|
||||||
|
sendText: sendText ?? vi.fn(),
|
||||||
|
respond: respond ?? vi.fn().mockResolvedValue({ id: 1 }),
|
||||||
|
} as unknown as MeshService;
|
||||||
|
return [new CommandService(mesh), mesh];
|
||||||
|
}
|
||||||
|
|
||||||
|
beforeEach(() => {
|
||||||
|
delete process.env.COMMAND_CHANNEL; // default channel 2 under test
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('CommandService.onRx', () => {
|
||||||
|
it('replies #ping via respond() — threaded quote of the trigger packet, no direct sendText', async () => {
|
||||||
|
const [svc, mesh] = makeService();
|
||||||
|
await svc.onRx(2, '#ping', 42, 7);
|
||||||
|
expect(mesh.respond).toHaveBeenCalledWith(7, '#pong!');
|
||||||
|
expect(mesh.sendText).not.toHaveBeenCalled();
|
||||||
|
});
|
||||||
|
|
||||||
|
it('falls back to a directed sendText on COMMAND_CHANNEL when the trigger has no packet id (DM)', async () => {
|
||||||
|
const [svc, mesh] = makeService();
|
||||||
|
await svc.onRx(2, '#ping', 42); // from present but no id — defensive path
|
||||||
|
expect(mesh.respond).not.toHaveBeenCalled();
|
||||||
|
expect(mesh.sendText).toHaveBeenCalledWith(42, '#pong!', undefined, 2);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('falls back to a broadcast sendText on COMMAND_CHANNEL when the trigger has no packet id (no sender)', async () => {
|
||||||
|
const [svc, mesh] = makeService();
|
||||||
|
await svc.onRx(2, '#ping'); // no from, no id — defensive path
|
||||||
|
expect(mesh.respond).not.toHaveBeenCalled();
|
||||||
|
expect(mesh.sendText).toHaveBeenCalledWith(
|
||||||
|
BROADCAST_ADDR,
|
||||||
|
'#pong!',
|
||||||
|
undefined,
|
||||||
|
2,
|
||||||
|
);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('ignores the same text on other channels (ch0 and ch3)', async () => {
|
||||||
|
const [svc, mesh] = makeService();
|
||||||
|
await svc.onRx(0, '#ping', 42);
|
||||||
|
await svc.onRx(3, '#ping', 42);
|
||||||
|
expect(mesh.respond).not.toHaveBeenCalled();
|
||||||
|
expect(mesh.sendText).not.toHaveBeenCalled();
|
||||||
|
});
|
||||||
|
|
||||||
|
it('ignores non-command text on the command channel', async () => {
|
||||||
|
const [svc, mesh] = makeService();
|
||||||
|
await svc.onRx(2, 'hello there', 42);
|
||||||
|
await svc.onRx(2, 'ping', 42); // no leading # — not a command trigger
|
||||||
|
expect(mesh.respond).not.toHaveBeenCalled();
|
||||||
|
expect(mesh.sendText).not.toHaveBeenCalled();
|
||||||
|
});
|
||||||
|
|
||||||
|
it('matches command names exactly and case-sensitively', async () => {
|
||||||
|
const [svc, mesh] = makeService();
|
||||||
|
await svc.onRx(2, '#Ping', 42);
|
||||||
|
await svc.onRx(2, '#ping!', 42); // extra char — no partial matches
|
||||||
|
expect(mesh.respond).not.toHaveBeenCalled();
|
||||||
|
expect(mesh.sendText).not.toHaveBeenCalled();
|
||||||
|
});
|
||||||
|
|
||||||
|
it('trims surrounding whitespace before matching', async () => {
|
||||||
|
const [svc, mesh] = makeService();
|
||||||
|
await svc.onRx(2, ' #ping ', 42, 9);
|
||||||
|
expect(mesh.respond).toHaveBeenCalledWith(9, '#pong!');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('honors the COMMAND_CHANNEL env override', async () => {
|
||||||
|
process.env.COMMAND_CHANNEL = '5';
|
||||||
|
const [svc, mesh] = makeService();
|
||||||
|
await svc.onRx(2, '#ping', 42); // old default no longer triggers
|
||||||
|
expect(mesh.respond).not.toHaveBeenCalled();
|
||||||
|
expect(mesh.sendText).not.toHaveBeenCalled();
|
||||||
|
await svc.onRx(5, '#ping', 42, 8);
|
||||||
|
expect(mesh.respond).toHaveBeenCalledWith(8, '#pong!');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('sends nothing when a handler returns void', async () => {
|
||||||
|
const [svc, mesh] = makeService();
|
||||||
|
svc.register('silent', () => undefined);
|
||||||
|
await svc.onRx(2, '#silent', 42);
|
||||||
|
expect(mesh.respond).not.toHaveBeenCalled();
|
||||||
|
expect(mesh.sendText).not.toHaveBeenCalled();
|
||||||
|
});
|
||||||
|
|
||||||
|
it('is extensible: a second registered command dispatches through the same path', async () => {
|
||||||
|
const [svc, mesh] = makeService();
|
||||||
|
svc.register('status', (ctx) => `up from ${ctx.from ?? 'broadcast'}`);
|
||||||
|
await svc.onRx(2, '#status', 99, 5);
|
||||||
|
expect(mesh.respond).toHaveBeenCalledWith(5, 'up from 99');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('swallows a failing handler (a bad command must not crash the app)', async () => {
|
||||||
|
const [svc, mesh] = makeService();
|
||||||
|
svc.register('boom', () => {
|
||||||
|
throw new Error('kaboom');
|
||||||
|
});
|
||||||
|
await expect(svc.onRx(2, '#boom', 42)).resolves.toBeUndefined();
|
||||||
|
expect(mesh.respond).not.toHaveBeenCalled();
|
||||||
|
expect(mesh.sendText).not.toHaveBeenCalled();
|
||||||
|
});
|
||||||
|
|
||||||
|
it('swallows a failing respond (unknown id / bridge down) without throwing', async () => {
|
||||||
|
const [svc] = makeService(
|
||||||
|
undefined,
|
||||||
|
vi.fn().mockRejectedValue(new Error('no message with id 7')),
|
||||||
|
);
|
||||||
|
await expect(svc.onRx(2, '#ping', 42, 7)).resolves.toBeUndefined();
|
||||||
|
});
|
||||||
|
|
||||||
|
it('swallows a failing send (mesh down) without throwing', async () => {
|
||||||
|
const [svc] = makeService(
|
||||||
|
vi.fn().mockRejectedValue(new Error('no bridge')),
|
||||||
|
);
|
||||||
|
await expect(svc.onRx(2, '#ping', 42)).resolves.toBeUndefined(); // no id → legacy path
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('MeshService wiring (event-driven trigger)', () => {
|
||||||
|
it('answers a #ping DM on ch2 with a directed #pong! back to the sender, same channel, threaded quote', async () => {
|
||||||
|
const bridge = await startBridge();
|
||||||
|
process.env.MESH_HOST = '127.0.0.1';
|
||||||
|
process.env.MESH_PORT = String(bridge.port);
|
||||||
|
const svc = new RealMeshService();
|
||||||
|
try {
|
||||||
|
// wire the responder exactly like command.module.ts does in production
|
||||||
|
svc.attachCommands(new CommandService(svc));
|
||||||
|
svc.onModuleInit();
|
||||||
|
await waitFor(
|
||||||
|
() => bridge.sockets.length === 1 && svc.status().connected,
|
||||||
|
);
|
||||||
|
|
||||||
|
const out: Uint8Array[] = [];
|
||||||
|
bridge.sockets[0].on('data', (c) => out.push(c));
|
||||||
|
|
||||||
|
// rx DM from KAMIL to node 42 on channel 2 (packet id 1)
|
||||||
|
bridge.sockets[0].write(textPacketFrame(KAMIL_NUM, 42, '#ping', 2));
|
||||||
|
|
||||||
|
// rx record + the directed #pong! reply on channel 2 (newest first — the reply is [0])
|
||||||
|
await waitFor(() => svc.messages().length === 2);
|
||||||
|
expect(svc.messages()[0]).toMatchObject({
|
||||||
|
dir: 'tx',
|
||||||
|
to: KAMIL_NUM,
|
||||||
|
text: '#pong!',
|
||||||
|
channel: 2,
|
||||||
|
});
|
||||||
|
|
||||||
|
// wire-level: DM back to the sender on ch2 with replyId = the ping packet id (threaded quote)
|
||||||
|
await waitFor(() => outboundPackets(out).length >= 1);
|
||||||
|
const pkt = outboundPackets(out)[0]!;
|
||||||
|
expect(pkt.to).toBe(KAMIL_NUM);
|
||||||
|
expect(pkt.channel).toBe(2);
|
||||||
|
const data =
|
||||||
|
pkt.payloadVariant?.case === 'decoded'
|
||||||
|
? pkt.payloadVariant.value
|
||||||
|
: undefined;
|
||||||
|
expect(data?.replyId).toBe(1);
|
||||||
|
} finally {
|
||||||
|
svc.onModuleDestroy();
|
||||||
|
bridge.close();
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|
||||||
|
it('answers a #ping broadcast on ch2 with a #pong! broadcast, same channel, threaded quote', async () => {
|
||||||
|
const bridge = await startBridge();
|
||||||
|
process.env.MESH_HOST = '127.0.0.1';
|
||||||
|
process.env.MESH_PORT = String(bridge.port);
|
||||||
|
const svc = new RealMeshService();
|
||||||
|
try {
|
||||||
|
svc.attachCommands(new CommandService(svc));
|
||||||
|
svc.onModuleInit();
|
||||||
|
await waitFor(
|
||||||
|
() => bridge.sockets.length === 1 && svc.status().connected,
|
||||||
|
);
|
||||||
|
|
||||||
|
const out: Uint8Array[] = [];
|
||||||
|
bridge.sockets[0].on('data', (c) => out.push(c));
|
||||||
|
|
||||||
|
// rx broadcast from KAMIL on channel 2 (packet id 1)
|
||||||
|
bridge.sockets[0].write(
|
||||||
|
textPacketFrame(KAMIL_NUM, BROADCAST_ADDR, '#ping', 2),
|
||||||
|
);
|
||||||
|
|
||||||
|
await waitFor(() => svc.messages().length === 2);
|
||||||
|
expect(svc.messages()[0]).toMatchObject({
|
||||||
|
dir: 'tx',
|
||||||
|
to: BROADCAST_ADDR, // broadcast original → broadcast reply
|
||||||
|
text: '#pong!',
|
||||||
|
channel: 2,
|
||||||
|
});
|
||||||
|
|
||||||
|
await waitFor(() => outboundPackets(out).length >= 1);
|
||||||
|
const pkt = outboundPackets(out)[0]!;
|
||||||
|
expect(pkt.to).toBe(BROADCAST_ADDR);
|
||||||
|
expect(pkt.channel).toBe(2);
|
||||||
|
const data =
|
||||||
|
pkt.payloadVariant?.case === 'decoded'
|
||||||
|
? pkt.payloadVariant.value
|
||||||
|
: undefined;
|
||||||
|
expect(data?.replyId).toBe(1); // threaded quote of the ping packet (id 1)
|
||||||
|
} finally {
|
||||||
|
svc.onModuleDestroy();
|
||||||
|
bridge.close();
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|
||||||
|
it('does not answer #ping arriving on a non-command channel', async () => {
|
||||||
|
const bridge = await startBridge();
|
||||||
|
process.env.MESH_HOST = '127.0.0.1';
|
||||||
|
process.env.MESH_PORT = String(bridge.port);
|
||||||
|
const svc = new RealMeshService();
|
||||||
|
try {
|
||||||
|
svc.attachCommands(new CommandService(svc));
|
||||||
|
svc.onModuleInit();
|
||||||
|
await waitFor(
|
||||||
|
() => bridge.sockets.length === 1 && svc.status().connected,
|
||||||
|
);
|
||||||
|
|
||||||
|
bridge.sockets[0].write(textPacketFrame(KAMIL_NUM, 42, '#ping', 3));
|
||||||
|
|
||||||
|
await waitFor(() => svc.messages().length === 1); // only the rx record — no reply
|
||||||
|
expect(svc.messages()[0]).toMatchObject({
|
||||||
|
dir: 'rx',
|
||||||
|
text: '#ping',
|
||||||
|
channel: 3,
|
||||||
|
});
|
||||||
|
} finally {
|
||||||
|
svc.onModuleDestroy();
|
||||||
|
bridge.close();
|
||||||
|
}
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -0,0 +1,82 @@
|
|||||||
|
import { Injectable, Logger } from '@nestjs/common';
|
||||||
|
import { BROADCAST_ADDR } from '../mesh/codec.js';
|
||||||
|
// type-only: the instance comes from DI (command.module.ts factory) or direct construction in tests — no runtime import cycle with src/mesh
|
||||||
|
import type { MeshService } from '../mesh/mesh.service.js';
|
||||||
|
|
||||||
|
/** Context handed to a command handler: the trimmed text plus sender/packet id when present. */
|
||||||
|
export interface CommandContext {
|
||||||
|
/** the trimmed rx text, e.g. `#ping` */
|
||||||
|
text: string;
|
||||||
|
/** sender node num — omitted for broadcasts/unknown senders */
|
||||||
|
from?: number;
|
||||||
|
/** packet id of the triggering message */
|
||||||
|
id?: number;
|
||||||
|
}
|
||||||
|
|
||||||
|
/** A command handler: returns the reply text to send back, or void/undefined for no reply. */
|
||||||
|
export type CommandHandler = (
|
||||||
|
ctx: CommandContext,
|
||||||
|
) => string | undefined | Promise<string | undefined>;
|
||||||
|
|
||||||
|
@Injectable()
|
||||||
|
export class CommandService {
|
||||||
|
private readonly logger = new Logger(CommandService.name);
|
||||||
|
// read at construction, like other services' env config
|
||||||
|
private readonly commandChannel = parseInt(
|
||||||
|
process.env.COMMAND_CHANNEL ?? '2',
|
||||||
|
10,
|
||||||
|
);
|
||||||
|
// single registration point: the constructor registers every built-in command — add the next one there (or via register())
|
||||||
|
private readonly commands = new Map<string, CommandHandler>();
|
||||||
|
|
||||||
|
/** mesh is optional so tests can construct without a bridge; production DI always passes one. */
|
||||||
|
constructor(private readonly mesh?: MeshService) {
|
||||||
|
this.register('ping', () => '#pong!');
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Register a command handler (names are case-sensitive; the leading `#` is stripped before lookup). */
|
||||||
|
register(name: string, fn: CommandHandler): void {
|
||||||
|
this.commands.set(name, fn);
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Event-driven entry point called by MeshService for every decoded rx text.
|
||||||
|
* No-op unless on COMMAND_CHANNEL with an exact `#command` match (case-sensitive).
|
||||||
|
* Replies go through MeshService.respond(id, reply): auto-routed to the original message's
|
||||||
|
* destination and channel as a threaded quote (replyId = id). Only when the trigger has no packet
|
||||||
|
* id does it fall back to legacy sendText routing on COMMAND_CHANNEL. Never throws — a failed
|
||||||
|
* command must not crash the app.
|
||||||
|
*/
|
||||||
|
async onRx(
|
||||||
|
channel: number,
|
||||||
|
text: string,
|
||||||
|
from?: number,
|
||||||
|
id?: number,
|
||||||
|
): Promise<void> {
|
||||||
|
if (channel !== this.commandChannel) return;
|
||||||
|
const trimmed = text.trim();
|
||||||
|
if (!trimmed.startsWith('#')) return; // only `#command` texts trigger handlers
|
||||||
|
const handler = this.commands.get(trimmed.slice(1));
|
||||||
|
if (!handler) return; // exact, case-sensitive match — no partials
|
||||||
|
try {
|
||||||
|
const reply = await handler({ text: trimmed, from, id });
|
||||||
|
if (reply === undefined || reply === null) return; // void = no reply
|
||||||
|
if (id !== undefined && this.mesh) {
|
||||||
|
// respond() auto-routes the reply: rides the original record's channel with replyId = id (threaded quote)
|
||||||
|
await this.mesh.respond(id, reply);
|
||||||
|
} else {
|
||||||
|
// defensive fallback when the trigger has no packet id: legacy routing on COMMAND_CHANNEL
|
||||||
|
await this.mesh?.sendText(
|
||||||
|
from ?? BROADCAST_ADDR,
|
||||||
|
reply,
|
||||||
|
undefined,
|
||||||
|
this.commandChannel,
|
||||||
|
);
|
||||||
|
}
|
||||||
|
} catch (err) {
|
||||||
|
this.logger.warn(
|
||||||
|
`[commands] '${trimmed}' failed: ${(err as Error).message}`,
|
||||||
|
);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -0,0 +1,31 @@
|
|||||||
|
import { Test } from '@nestjs/testing';
|
||||||
|
import { describe, expect, it } from 'vitest';
|
||||||
|
import { MeshService } from '../mesh/mesh.service.js';
|
||||||
|
import { CommandModule } from './command.module.js';
|
||||||
|
import { CommandService } from './command.service.js';
|
||||||
|
|
||||||
|
describe('DI wiring (module graph)', () => {
|
||||||
|
// compile() instantiates providers but does not run lifecycle hooks, so no TCP connection is opened.
|
||||||
|
it('resolves CommandService with MeshService provided by MeshModule', async () => {
|
||||||
|
process.env.MESH_DB_PATH = ':memory:'; // keep openMessageDb from touching the repo's ./data
|
||||||
|
const moduleRef = await Test.createTestingModule({
|
||||||
|
imports: [CommandModule],
|
||||||
|
}).compile();
|
||||||
|
expect(moduleRef.get(CommandService)).toBeInstanceOf(CommandService);
|
||||||
|
expect(moduleRef.get(MeshService)).toBeInstanceOf(MeshService);
|
||||||
|
});
|
||||||
|
|
||||||
|
// the MeshService <-> CommandService cycle must resolve to live references on both sides, not undefined
|
||||||
|
it('wires both sides of the circular dependency with real instances', async () => {
|
||||||
|
process.env.MESH_DB_PATH = ':memory:';
|
||||||
|
const moduleRef = await Test.createTestingModule({
|
||||||
|
imports: [CommandModule],
|
||||||
|
}).compile();
|
||||||
|
const mesh = moduleRef.get(MeshService);
|
||||||
|
const commands = moduleRef.get(CommandService);
|
||||||
|
expect((commands as unknown as { mesh?: MeshService }).mesh).toBe(mesh);
|
||||||
|
expect((mesh as unknown as { commands?: CommandService }).commands).toBe(
|
||||||
|
commands,
|
||||||
|
);
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -0,0 +1,8 @@
|
|||||||
|
import { Module } from '@nestjs/common';
|
||||||
|
import { LlmService } from './llm.service.js';
|
||||||
|
|
||||||
|
@Module({
|
||||||
|
providers: [LlmService],
|
||||||
|
exports: [LlmService],
|
||||||
|
})
|
||||||
|
export class LlmModule {}
|
||||||
@@ -0,0 +1,104 @@
|
|||||||
|
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
|
||||||
|
import type { ChatMessage } from './llm.service.js';
|
||||||
|
import { LlmService } from './llm.service.js';
|
||||||
|
|
||||||
|
const BASE = 'http://192.168.1.70:1111/v1';
|
||||||
|
|
||||||
|
function json(body: unknown): Response {
|
||||||
|
return { ok: true, status: 200, json: async () => body } as Response;
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Fresh service with a clean env (explicit base/model/timeout). */
|
||||||
|
function makeService(): LlmService {
|
||||||
|
process.env.LLM_API_BASE = BASE;
|
||||||
|
process.env.LLM_MODEL = 'qwen3.8-27b';
|
||||||
|
process.env.LLM_TIMEOUT_MS = '60000';
|
||||||
|
return new LlmService();
|
||||||
|
}
|
||||||
|
|
||||||
|
describe('LlmService', () => {
|
||||||
|
let fetchMock: ReturnType<typeof vi.fn>;
|
||||||
|
|
||||||
|
beforeEach(() => {
|
||||||
|
fetchMock = vi.fn();
|
||||||
|
vi.stubGlobal('fetch', fetchMock);
|
||||||
|
});
|
||||||
|
|
||||||
|
afterEach(() => {
|
||||||
|
vi.unstubAllGlobals();
|
||||||
|
for (const k of ['LLM_API_BASE', 'LLM_MODEL', 'LLM_TIMEOUT_MS'])
|
||||||
|
delete process.env[k];
|
||||||
|
});
|
||||||
|
|
||||||
|
it('listModels returns the data[].id strings from GET /models', async () => {
|
||||||
|
const svc = makeService();
|
||||||
|
fetchMock.mockResolvedValueOnce(
|
||||||
|
json({
|
||||||
|
data: [
|
||||||
|
{ id: 'qwen3.8-27b' },
|
||||||
|
{ id: 'text-embedding-nomic-embed-text-v1.5' },
|
||||||
|
],
|
||||||
|
}),
|
||||||
|
);
|
||||||
|
|
||||||
|
await expect(svc.listModels()).resolves.toEqual([
|
||||||
|
'qwen3.8-27b',
|
||||||
|
'text-embedding-nomic-embed-text-v1.5',
|
||||||
|
]);
|
||||||
|
expect(fetchMock).toHaveBeenCalledTimes(1);
|
||||||
|
expect(fetchMock.mock.calls[0][0]).toBe(`${BASE}/models`);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('chat posts model+messages and returns choices[0].message.content', async () => {
|
||||||
|
const svc = makeService();
|
||||||
|
fetchMock.mockResolvedValueOnce(
|
||||||
|
json({ choices: [{ message: { content: 'hello back' } }] }),
|
||||||
|
);
|
||||||
|
|
||||||
|
const messages: ChatMessage[] = [
|
||||||
|
{ role: 'system', content: 'be brief' },
|
||||||
|
{ role: 'user', content: 'hi' },
|
||||||
|
];
|
||||||
|
await expect(
|
||||||
|
svc.chat(messages, { maxTokens: 50, temperature: 0.2 }),
|
||||||
|
).resolves.toBe('hello back');
|
||||||
|
|
||||||
|
const [url, init] = fetchMock.mock.calls[0];
|
||||||
|
expect(url).toBe(`${BASE}/chat/completions`);
|
||||||
|
expect(init.method).toBe('POST');
|
||||||
|
expect(JSON.parse(init.body)).toEqual({
|
||||||
|
model: 'qwen3.8-27b',
|
||||||
|
messages,
|
||||||
|
maxTokens: 50,
|
||||||
|
temperature: 0.2,
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
it('chat throws on non-2xx with the HTTP status in the message', async () => {
|
||||||
|
const svc = makeService();
|
||||||
|
fetchMock.mockResolvedValueOnce({
|
||||||
|
ok: false,
|
||||||
|
status: 503,
|
||||||
|
text: async () => 'upstream down',
|
||||||
|
} as Response);
|
||||||
|
|
||||||
|
await expect(svc.chat([{ role: 'user', content: 'hi' }])).rejects.toThrow(
|
||||||
|
/HTTP 503.*upstream down/,
|
||||||
|
);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('summarize calls chat with the system prompt plus the user text', async () => {
|
||||||
|
const svc = makeService();
|
||||||
|
fetchMock.mockResolvedValueOnce(
|
||||||
|
json({ choices: [{ message: { content: 'the summary' } }] }),
|
||||||
|
);
|
||||||
|
|
||||||
|
await expect(svc.summarize('a long text')).resolves.toBe('the summary');
|
||||||
|
|
||||||
|
const [, init] = fetchMock.mock.calls[0];
|
||||||
|
expect(JSON.parse(init.body).messages).toEqual([
|
||||||
|
{ role: 'system', content: 'Summarize the following text concisely.' },
|
||||||
|
{ role: 'user', content: 'a long text' },
|
||||||
|
]);
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -0,0 +1,68 @@
|
|||||||
|
import { Injectable } from '@nestjs/common';
|
||||||
|
|
||||||
|
/** A single chat message in OpenAI chat-completions shape. */
|
||||||
|
export interface ChatMessage {
|
||||||
|
role: string;
|
||||||
|
content: string;
|
||||||
|
}
|
||||||
|
|
||||||
|
@Injectable()
|
||||||
|
export class LlmService {
|
||||||
|
// read at construction, like other services' env config
|
||||||
|
private readonly apiBase =
|
||||||
|
process.env.LLM_API_BASE ?? 'http://192.168.1.70:1111/v1';
|
||||||
|
private readonly model = process.env.LLM_MODEL ?? 'qwen3.8-27b';
|
||||||
|
// local 27B model can be slow — generous default
|
||||||
|
private readonly timeoutMs = parseInt(
|
||||||
|
process.env.LLM_TIMEOUT_MS ?? '60000',
|
||||||
|
10,
|
||||||
|
);
|
||||||
|
|
||||||
|
/** GET {base}/models → the `data[].id` strings. */
|
||||||
|
async listModels(): Promise<string[]> {
|
||||||
|
const res = await fetch(`${this.apiBase}/models`, {
|
||||||
|
signal: AbortSignal.timeout(this.timeoutMs),
|
||||||
|
});
|
||||||
|
if (!res.ok) {
|
||||||
|
throw new Error(
|
||||||
|
`listModels failed: HTTP ${res.status} ${(await res.text()).slice(0, 200)}`,
|
||||||
|
);
|
||||||
|
}
|
||||||
|
const body = (await res.json()) as { data?: { id: string }[] };
|
||||||
|
return (body.data ?? []).map((m) => m.id);
|
||||||
|
}
|
||||||
|
|
||||||
|
/** POST {base}/chat/completions → `choices[0].message.content`. */
|
||||||
|
async chat(
|
||||||
|
messages: ChatMessage[],
|
||||||
|
opts?: { maxTokens?: number; temperature?: number },
|
||||||
|
): Promise<string> {
|
||||||
|
const res = await fetch(`${this.apiBase}/chat/completions`, {
|
||||||
|
method: 'POST',
|
||||||
|
headers: { 'content-type': 'application/json' },
|
||||||
|
body: JSON.stringify({ model: this.model, messages, ...opts }),
|
||||||
|
signal: AbortSignal.timeout(this.timeoutMs),
|
||||||
|
});
|
||||||
|
if (!res.ok) {
|
||||||
|
throw new Error(
|
||||||
|
`chat failed: HTTP ${res.status} ${(await res.text()).slice(0, 200)}`,
|
||||||
|
);
|
||||||
|
}
|
||||||
|
const body = (await res.json()) as {
|
||||||
|
choices?: { message?: { content?: string } }[];
|
||||||
|
};
|
||||||
|
const content = body.choices?.[0]?.message?.content;
|
||||||
|
if (typeof content !== 'string') {
|
||||||
|
throw new Error('chat failed: no choices[0].message.content in response');
|
||||||
|
}
|
||||||
|
return content;
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Thin wrapper over chat(): the stated primary use of this service. */
|
||||||
|
async summarize(text: string): Promise<string> {
|
||||||
|
return this.chat([
|
||||||
|
{ role: 'system', content: 'Summarize the following text concisely.' },
|
||||||
|
{ role: 'user', content: text },
|
||||||
|
]);
|
||||||
|
}
|
||||||
|
}
|
||||||
+45
-2
@@ -1,8 +1,8 @@
|
|||||||
import { create, toBinary } from '@bufbuild/protobuf';
|
import { create, fromBinary, toBinary } from '@bufbuild/protobuf';
|
||||||
import * as P from '@meshtastic/protobufs';
|
import * as P from '@meshtastic/protobufs';
|
||||||
import * as net from 'node:net';
|
import * as net from 'node:net';
|
||||||
import type { AddressInfo } from 'node:net';
|
import type { AddressInfo } from 'node:net';
|
||||||
import { frame } from './codec.js';
|
import { extractFrames, frame } from './codec.js';
|
||||||
|
|
||||||
/** In-process TCP stand-in for the meshtastic-serial-bridge; hands out accepted sockets. */
|
/** In-process TCP stand-in for the meshtastic-serial-bridge; hands out accepted sockets. */
|
||||||
export function startBridge(
|
export function startBridge(
|
||||||
@@ -148,6 +148,49 @@ export function telemetryPacketFrame(
|
|||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/** Inbound text message: TEXT_MESSAGE_APP packet with UTF-8 in Data.payload (fixed packet id 1). */
|
||||||
|
export function textPacketFrame(
|
||||||
|
from: number,
|
||||||
|
to: number,
|
||||||
|
text: string,
|
||||||
|
channel = 0,
|
||||||
|
): Uint8Array {
|
||||||
|
const data = create(P.Mesh.DataSchema, {
|
||||||
|
portnum: P.Portnums.PortNum.TEXT_MESSAGE_APP,
|
||||||
|
payload: new TextEncoder().encode(text),
|
||||||
|
});
|
||||||
|
const pkt = create(P.Mesh.MeshPacketSchema, {
|
||||||
|
from,
|
||||||
|
to,
|
||||||
|
id: 1,
|
||||||
|
channel,
|
||||||
|
payloadVariant: { case: 'decoded', value: data },
|
||||||
|
});
|
||||||
|
return frame(
|
||||||
|
toBinary(
|
||||||
|
P.Mesh.FromRadioSchema,
|
||||||
|
create(P.Mesh.FromRadioSchema, {
|
||||||
|
payloadVariant: { case: 'packet', value: pkt },
|
||||||
|
}),
|
||||||
|
),
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Outbound text packets written to the bridge, in order (want_config frames skipped). */
|
||||||
|
export function outboundPackets(out: Uint8Array[]): P.Mesh.MeshPacket[] {
|
||||||
|
const merged = new Uint8Array(out.reduce((n, c) => n + c.length, 0));
|
||||||
|
let off = 0;
|
||||||
|
for (const c of out) {
|
||||||
|
merged.set(c, off);
|
||||||
|
off += c.length;
|
||||||
|
}
|
||||||
|
return extractFrames(merged).packets.flatMap((p) => {
|
||||||
|
const tr = fromBinary(P.Mesh.ToRadioSchema, p);
|
||||||
|
if (tr.payloadVariant?.case === 'packet') return [tr.payloadVariant.value];
|
||||||
|
return [];
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
export const KAMIL_NUM = 123456789;
|
export const KAMIL_NUM = 123456789;
|
||||||
|
|
||||||
export function kamilNodeInfo(): NodeInfoFields {
|
export function kamilNodeInfo(): NodeInfoFields {
|
||||||
|
|||||||
@@ -11,6 +11,7 @@ import {
|
|||||||
nodeInfoFrame,
|
nodeInfoFrame,
|
||||||
startBridge,
|
startBridge,
|
||||||
telemetryPacketFrame,
|
telemetryPacketFrame,
|
||||||
|
textPacketFrame,
|
||||||
waitFor,
|
waitFor,
|
||||||
} from './fake-bridge.js';
|
} from './fake-bridge.js';
|
||||||
import { createMeshMcpServer } from './mcp.controller.js';
|
import { createMeshMcpServer } from './mcp.controller.js';
|
||||||
@@ -67,7 +68,7 @@ async function connectMcp(svc: MeshService): Promise<{
|
|||||||
}
|
}
|
||||||
|
|
||||||
describe('MCP server tools', () => {
|
describe('MCP server tools', () => {
|
||||||
it('lists all nine tools with descriptions and input schemas', async () => {
|
it('lists all ten tools with descriptions and input schemas', async () => {
|
||||||
const env = await connectedService();
|
const env = await connectedService();
|
||||||
try {
|
try {
|
||||||
const mcp = await connectMcp(env.svc);
|
const mcp = await connectMcp(env.svc);
|
||||||
@@ -82,6 +83,7 @@ describe('MCP server tools', () => {
|
|||||||
'list_channels',
|
'list_channels',
|
||||||
'list_nodes',
|
'list_nodes',
|
||||||
'mesh_status',
|
'mesh_status',
|
||||||
|
'respond',
|
||||||
'send_message',
|
'send_message',
|
||||||
]);
|
]);
|
||||||
for (const t of tools) expect(t.description?.length).toBeGreaterThan(0);
|
for (const t of tools) expect(t.description?.length).toBeGreaterThan(0);
|
||||||
@@ -100,6 +102,13 @@ describe('MCP server tools', () => {
|
|||||||
'text',
|
'text',
|
||||||
'from',
|
'from',
|
||||||
]);
|
]);
|
||||||
|
|
||||||
|
const respond = tools.find((t) => t.name === 'respond')!;
|
||||||
|
expect(respond.inputSchema.required).toEqual(['messageId', 'content']);
|
||||||
|
expect(Object.keys(respond.inputSchema.properties ?? {})).toEqual([
|
||||||
|
'messageId',
|
||||||
|
'content',
|
||||||
|
]);
|
||||||
} finally {
|
} finally {
|
||||||
await mcp.close();
|
await mcp.close();
|
||||||
}
|
}
|
||||||
@@ -196,6 +205,57 @@ describe('MCP server tools', () => {
|
|||||||
}
|
}
|
||||||
});
|
});
|
||||||
|
|
||||||
|
it('respond routes the reply automatically and surfaces failures as tool errors', async () => {
|
||||||
|
const env = await connectedService();
|
||||||
|
try {
|
||||||
|
// rx DM from KAMIL on channel 3 (packet id 1)
|
||||||
|
env.sockets[0].write(textPacketFrame(KAMIL_NUM, 42, 'ping', 3));
|
||||||
|
await waitFor(() => env.svc.messages().length === 1);
|
||||||
|
|
||||||
|
const mcp = await connectMcp(env.svc);
|
||||||
|
try {
|
||||||
|
const r1 = await mcp.client.callTool({
|
||||||
|
name: 'respond',
|
||||||
|
arguments: { messageId: 1, content: 'pong' },
|
||||||
|
});
|
||||||
|
expect(r1.isError).not.toBe(true);
|
||||||
|
const reply = JSON.parse(toolText(r1)) as { id: number };
|
||||||
|
expect(reply.id).toBeGreaterThan(0);
|
||||||
|
// DM back to the original sender on the original channel
|
||||||
|
expect(env.svc.messages()[0]).toMatchObject({
|
||||||
|
dir: 'tx',
|
||||||
|
to: KAMIL_NUM,
|
||||||
|
text: 'pong',
|
||||||
|
channel: 3,
|
||||||
|
});
|
||||||
|
|
||||||
|
const r2 = await mcp.client.callTool({
|
||||||
|
name: 'respond',
|
||||||
|
arguments: { messageId: 999, content: 'x' },
|
||||||
|
});
|
||||||
|
expect(r2.isError).toBe(true);
|
||||||
|
expect(toolText(r2)).toContain('no message with id 999');
|
||||||
|
|
||||||
|
const r3 = await mcp.client.callTool({
|
||||||
|
name: 'respond',
|
||||||
|
arguments: { messageId: 0, content: 'x' },
|
||||||
|
});
|
||||||
|
expect(r3.isError).toBe(true); // out-of-range rejected before the service sees it
|
||||||
|
|
||||||
|
const r4 = await mcp.client.callTool({
|
||||||
|
name: 'respond',
|
||||||
|
arguments: { messageId: 1, content: '' },
|
||||||
|
});
|
||||||
|
expect(r4.isError).toBe(true);
|
||||||
|
expect(toolText(r4)).toContain('content must be a non-empty string');
|
||||||
|
} finally {
|
||||||
|
await mcp.close();
|
||||||
|
}
|
||||||
|
} finally {
|
||||||
|
env.close();
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|
||||||
it('inject_message records an rx entry without sending over RF', async () => {
|
it('inject_message records an rx entry without sending over RF', async () => {
|
||||||
const env = await connectedService();
|
const env = await connectedService();
|
||||||
try {
|
try {
|
||||||
|
|||||||
@@ -46,6 +46,19 @@ export function createMeshMcpServer(mesh: MeshService): McpServer {
|
|||||||
}),
|
}),
|
||||||
);
|
);
|
||||||
|
|
||||||
|
server.registerTool(
|
||||||
|
'respond',
|
||||||
|
{
|
||||||
|
description: `Reply to an earlier message by its packet id (from get_messages); returns { id } — the Meshtastic packet id of the reply. Routing is automatic: rx records are answered as a DM back to the original sender, tx records go to their destination; broadcast originals and injected messages without a sender get a broadcast. The reply always rides the record's channel and carries replyId = messageId (threaded quote in the recipient app). Invalid messageId/content or an unknown id are tool errors.`,
|
||||||
|
inputSchema: {
|
||||||
|
messageId: z.number().int().min(1).max(0xffffffff),
|
||||||
|
content: z.string(),
|
||||||
|
},
|
||||||
|
},
|
||||||
|
async ({ messageId, content }) =>
|
||||||
|
jsonResult(await mesh.respond(messageId, content)),
|
||||||
|
);
|
||||||
|
|
||||||
server.registerTool(
|
server.registerTool(
|
||||||
'list_channels',
|
'list_channels',
|
||||||
{
|
{
|
||||||
|
|||||||
@@ -29,6 +29,17 @@ export class InjectMessageDto {
|
|||||||
from?: number;
|
from?: number;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
export class RespondDto {
|
||||||
|
@ApiProperty({
|
||||||
|
description:
|
||||||
|
'Packet id of the earlier message (from GET /api/messages) that this one replies to. Integer in 1..0xffffffff.',
|
||||||
|
example: 456789,
|
||||||
|
})
|
||||||
|
messageId!: number;
|
||||||
|
@ApiProperty({ description: 'Reply text', example: 'on my way' })
|
||||||
|
content!: string;
|
||||||
|
}
|
||||||
|
|
||||||
export class SendTextDto {
|
export class SendTextDto {
|
||||||
@ApiProperty({ description: 'Message text', example: 'hello' })
|
@ApiProperty({ description: 'Message text', example: 'hello' })
|
||||||
text!: string;
|
text!: string;
|
||||||
@@ -111,6 +122,24 @@ export class MeshController {
|
|||||||
return { id: await this.mesh.sendText(to, body.text, replyId) };
|
return { id: await this.mesh.sendText(to, body.text, replyId) };
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@Post('respond')
|
||||||
|
@ApiOperation({
|
||||||
|
summary: 'Reply to an earlier message by packet id',
|
||||||
|
description:
|
||||||
|
"Routing is automatic — the caller never thinks about where it goes: rx records are answered as a DM back to the original sender, tx records go to their destination; broadcast originals (and injected messages without a sender) get a broadcast. The reply always rides the record's channel and carries replyId = messageId, so the recipient app renders it as a threaded quote of that packet. Returns { id } with the new packet id.",
|
||||||
|
})
|
||||||
|
@ApiResponse({
|
||||||
|
status: 200,
|
||||||
|
description: 'Packet queued',
|
||||||
|
example: { id: 123456789 },
|
||||||
|
})
|
||||||
|
@ApiResponse({ status: 400, description: 'Invalid messageId or content' })
|
||||||
|
@ApiResponse({ status: 404, description: 'No message with the given id' })
|
||||||
|
@ApiResponse({ status: 503, description: 'Bridge not connected' })
|
||||||
|
async respond(@Body() body: RespondDto) {
|
||||||
|
return this.mesh.respond(body?.messageId, body?.content);
|
||||||
|
}
|
||||||
|
|
||||||
@Get('channels')
|
@Get('channels')
|
||||||
@ApiOperation({
|
@ApiOperation({
|
||||||
summary: "The device's Meshtastic channels (keys redacted)",
|
summary: "The device's Meshtastic channels (keys redacted)",
|
||||||
@@ -212,6 +241,29 @@ export class MeshController {
|
|||||||
return this.mesh.messages();
|
return this.mesh.messages();
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@Get('forwarded')
|
||||||
|
@ApiOperation({
|
||||||
|
summary: 'Forwarded message history (last 100)',
|
||||||
|
description:
|
||||||
|
'The last 100 rx texts that passed the notify gate and were forwarded to opencode, newest first as { id, from?, text, channel, at }[] — channel in the MESH_NOTIFY_CHANNEL comma-separated list (ch0: directed DMs only), not a self-echo, notifier wired. The id is the packet id (real rx) or generated record id (injected); `from` is omitted when there is no sender. In-memory only — reset on restart.',
|
||||||
|
})
|
||||||
|
@ApiResponse({
|
||||||
|
status: 200,
|
||||||
|
description: 'Forwarded messages newest first',
|
||||||
|
example: [
|
||||||
|
{
|
||||||
|
id: 456789,
|
||||||
|
from: 987654321,
|
||||||
|
text: 'ping',
|
||||||
|
channel: 3,
|
||||||
|
at: 1758000000000,
|
||||||
|
},
|
||||||
|
],
|
||||||
|
})
|
||||||
|
forwarded() {
|
||||||
|
return this.mesh.forwarded();
|
||||||
|
}
|
||||||
|
|
||||||
@Post('messages')
|
@Post('messages')
|
||||||
@ApiOperation({
|
@ApiOperation({
|
||||||
summary: 'Inject a synthetic inbound message into the history',
|
summary: 'Inject a synthetic inbound message into the history',
|
||||||
|
|||||||
+521
-38
@@ -1,5 +1,6 @@
|
|||||||
import { create, fromBinary, toBinary } from '@bufbuild/protobuf';
|
import { create, fromBinary, toBinary } from '@bufbuild/protobuf';
|
||||||
import * as P from '@meshtastic/protobufs';
|
import * as P from '@meshtastic/protobufs';
|
||||||
|
import { BadRequestException, NotFoundException } from '@nestjs/common';
|
||||||
import { DatabaseSync } from 'node:sqlite';
|
import { DatabaseSync } from 'node:sqlite';
|
||||||
import { beforeEach, describe, expect, it, vi } from 'vitest';
|
import { beforeEach, describe, expect, it, vi } from 'vitest';
|
||||||
import { BROADCAST_ADDR, extractFrames, frame } from './codec.js';
|
import { BROADCAST_ADDR, extractFrames, frame } from './codec.js';
|
||||||
@@ -10,8 +11,10 @@ import {
|
|||||||
metadataFrame,
|
metadataFrame,
|
||||||
moduleConfigSectionFrame,
|
moduleConfigSectionFrame,
|
||||||
nodeInfoFrame,
|
nodeInfoFrame,
|
||||||
|
outboundPackets,
|
||||||
startBridge,
|
startBridge,
|
||||||
telemetryPacketFrame,
|
telemetryPacketFrame,
|
||||||
|
textPacketFrame,
|
||||||
waitFor,
|
waitFor,
|
||||||
} from './fake-bridge.js';
|
} from './fake-bridge.js';
|
||||||
import { OpencodeService } from '../opencode/opencode.service.js';
|
import { OpencodeService } from '../opencode/opencode.service.js';
|
||||||
@@ -74,34 +77,6 @@ function nodeInfoPacketFrame(
|
|||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
// inbound text message: TEXT_MESSAGE_APP packet with UTF-8 in Data.payload
|
|
||||||
function textPacketFrame(
|
|
||||||
from: number,
|
|
||||||
to: number,
|
|
||||||
text: string,
|
|
||||||
channel = 0,
|
|
||||||
): Uint8Array {
|
|
||||||
const data = create(P.Mesh.DataSchema, {
|
|
||||||
portnum: P.Portnums.PortNum.TEXT_MESSAGE_APP,
|
|
||||||
payload: new TextEncoder().encode(text),
|
|
||||||
});
|
|
||||||
const pkt = create(P.Mesh.MeshPacketSchema, {
|
|
||||||
from,
|
|
||||||
to,
|
|
||||||
id: 1,
|
|
||||||
channel,
|
|
||||||
payloadVariant: { case: 'decoded', value: data },
|
|
||||||
});
|
|
||||||
return frame(
|
|
||||||
toBinary(
|
|
||||||
P.Mesh.FromRadioSchema,
|
|
||||||
create(P.Mesh.FromRadioSchema, {
|
|
||||||
payloadVariant: { case: 'packet', value: pkt },
|
|
||||||
}),
|
|
||||||
),
|
|
||||||
);
|
|
||||||
}
|
|
||||||
|
|
||||||
// ACK/NACK for our sends: ROUTING_APP packet with Data.requestId = original id and a serialized Routing in the payload
|
// ACK/NACK for our sends: ROUTING_APP packet with Data.requestId = original id and a serialized Routing in the payload
|
||||||
function routingFrame(
|
function routingFrame(
|
||||||
requestId: number,
|
requestId: number,
|
||||||
@@ -594,6 +569,7 @@ describe('MeshService message history', () => {
|
|||||||
id: 1,
|
id: 1,
|
||||||
dir: 'rx',
|
dir: 'rx',
|
||||||
from: KAMIL_NUM,
|
from: KAMIL_NUM,
|
||||||
|
to: 42, // destination persisted on rx records (broadcast addr for broadcasts)
|
||||||
text: 'ping',
|
text: 'ping',
|
||||||
channel: 2,
|
channel: 2,
|
||||||
at: expect.any(Number),
|
at: expect.any(Number),
|
||||||
@@ -692,13 +668,222 @@ describe('MeshService message history', () => {
|
|||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
describe('MeshService respond', () => {
|
||||||
|
it('replies to an rx DM as a directed send back to the sender on the original channel with replyId = messageId', async () => {
|
||||||
|
const bridge = await startBridge();
|
||||||
|
process.env.MESH_HOST = '127.0.0.1';
|
||||||
|
process.env.MESH_PORT = String(bridge.port);
|
||||||
|
const svc = new MeshService();
|
||||||
|
try {
|
||||||
|
svc.onModuleInit();
|
||||||
|
await waitFor(
|
||||||
|
() => bridge.sockets.length === 1 && svc.status().connected,
|
||||||
|
);
|
||||||
|
|
||||||
|
// rx DM from KAMIL to our node on channel 2 (packet id 1)
|
||||||
|
bridge.sockets[0].write(textPacketFrame(KAMIL_NUM, 42, 'ping', 2));
|
||||||
|
await waitFor(() => svc.messages().length === 1);
|
||||||
|
|
||||||
|
const out: Uint8Array[] = [];
|
||||||
|
bridge.sockets[0].on('data', (c) => out.push(c));
|
||||||
|
const { id } = await svc.respond(1, 'pong');
|
||||||
|
|
||||||
|
expect(id).toBeGreaterThan(0);
|
||||||
|
// DM back to the original sender on the original channel
|
||||||
|
expect(svc.messages()[0]).toMatchObject({
|
||||||
|
id,
|
||||||
|
dir: 'tx',
|
||||||
|
to: KAMIL_NUM,
|
||||||
|
text: 'pong',
|
||||||
|
channel: 2,
|
||||||
|
status: 'pending',
|
||||||
|
});
|
||||||
|
|
||||||
|
await waitFor(() => outboundPackets(out).length === 1);
|
||||||
|
const pkt = outboundPackets(out)[0]!;
|
||||||
|
expect(pkt.to).toBe(KAMIL_NUM);
|
||||||
|
expect(pkt.channel).toBe(2);
|
||||||
|
const data =
|
||||||
|
pkt.payloadVariant?.case === 'decoded'
|
||||||
|
? pkt.payloadVariant.value
|
||||||
|
: undefined;
|
||||||
|
expect(data?.replyId).toBe(1); // threaded quote of the original packet
|
||||||
|
} finally {
|
||||||
|
svc.onModuleDestroy();
|
||||||
|
bridge.close();
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|
||||||
|
it('replies to a broadcast original as a broadcast on the original channel with replyId = messageId', async () => {
|
||||||
|
const bridge = await startBridge();
|
||||||
|
process.env.MESH_HOST = '127.0.0.1';
|
||||||
|
process.env.MESH_PORT = String(bridge.port);
|
||||||
|
const svc = new MeshService();
|
||||||
|
try {
|
||||||
|
svc.onModuleInit();
|
||||||
|
await waitFor(
|
||||||
|
() => bridge.sockets.length === 1 && svc.status().connected,
|
||||||
|
);
|
||||||
|
|
||||||
|
// rx broadcast from KAMIL on channel 2 (packet id 1)
|
||||||
|
bridge.sockets[0].write(
|
||||||
|
textPacketFrame(KAMIL_NUM, BROADCAST_ADDR, 'hello all', 2),
|
||||||
|
);
|
||||||
|
await waitFor(() => svc.messages().length === 1);
|
||||||
|
|
||||||
|
const out: Uint8Array[] = [];
|
||||||
|
bridge.sockets[0].on('data', (c) => out.push(c));
|
||||||
|
const { id } = await svc.respond(1, 'pong');
|
||||||
|
|
||||||
|
expect(id).toBeGreaterThan(0);
|
||||||
|
expect(svc.messages()[0]).toMatchObject({
|
||||||
|
dir: 'tx',
|
||||||
|
to: BROADCAST_ADDR, // broadcast original → broadcast reply
|
||||||
|
text: 'pong',
|
||||||
|
channel: 2,
|
||||||
|
});
|
||||||
|
|
||||||
|
await waitFor(() => outboundPackets(out).length === 1);
|
||||||
|
const pkt = outboundPackets(out)[0]!;
|
||||||
|
expect(pkt.to).toBe(BROADCAST_ADDR);
|
||||||
|
expect(pkt.channel).toBe(2);
|
||||||
|
const data =
|
||||||
|
pkt.payloadVariant?.case === 'decoded'
|
||||||
|
? pkt.payloadVariant.value
|
||||||
|
: undefined;
|
||||||
|
expect(data?.replyId).toBe(1);
|
||||||
|
} finally {
|
||||||
|
svc.onModuleDestroy();
|
||||||
|
bridge.close();
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|
||||||
|
it('replies to a tx record targeting its destination on its channel with replyId = messageId', async () => {
|
||||||
|
const bridge = await startBridge();
|
||||||
|
process.env.MESH_HOST = '127.0.0.1';
|
||||||
|
process.env.MESH_PORT = String(bridge.port);
|
||||||
|
const svc = new MeshService();
|
||||||
|
try {
|
||||||
|
svc.onModuleInit();
|
||||||
|
await waitFor(
|
||||||
|
() => bridge.sockets.length === 1 && svc.status().connected,
|
||||||
|
);
|
||||||
|
|
||||||
|
const origId = await svc.sendText(42, 'orig'); // tx record: to=42, default channel 3
|
||||||
|
const out: Uint8Array[] = [];
|
||||||
|
bridge.sockets[0].on('data', (c) => out.push(c));
|
||||||
|
const { id } = await svc.respond(origId, 'reply');
|
||||||
|
|
||||||
|
expect(id).toBeGreaterThan(0);
|
||||||
|
expect(svc.messages()[0]).toMatchObject({
|
||||||
|
dir: 'tx',
|
||||||
|
to: 42, // the tx record's own destination
|
||||||
|
text: 'reply',
|
||||||
|
channel: 3,
|
||||||
|
});
|
||||||
|
|
||||||
|
// the orig send may share a chunk with the reply — take the newest packet
|
||||||
|
await waitFor(() => outboundPackets(out).length >= 1);
|
||||||
|
const pkts = outboundPackets(out);
|
||||||
|
const pkt = pkts[pkts.length - 1]!;
|
||||||
|
expect(pkt.to).toBe(42);
|
||||||
|
const data =
|
||||||
|
pkt.payloadVariant?.case === 'decoded'
|
||||||
|
? pkt.payloadVariant.value
|
||||||
|
: undefined;
|
||||||
|
expect(data?.replyId).toBe(origId);
|
||||||
|
} finally {
|
||||||
|
svc.onModuleDestroy();
|
||||||
|
bridge.close();
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|
||||||
|
it('throws NotFoundException when no message has the given id (memory or SQLite)', async () => {
|
||||||
|
const svc = new MeshService();
|
||||||
|
await expect(svc.respond(999, 'hi')).rejects.toBeInstanceOf(
|
||||||
|
NotFoundException,
|
||||||
|
);
|
||||||
|
await expect(svc.respond(999, 'hi')).rejects.toThrow(
|
||||||
|
'no message with id 999',
|
||||||
|
);
|
||||||
|
|
||||||
|
const db = new DatabaseSync(':memory:'); // empty table — the DB lookup path also misses
|
||||||
|
initMessagesTable(db);
|
||||||
|
const svc2 = new MeshService(db);
|
||||||
|
await expect(svc2.respond(999, 'hi')).rejects.toBeInstanceOf(
|
||||||
|
NotFoundException,
|
||||||
|
);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('falls back to SQLite when the record is not in the in-memory buffer', async () => {
|
||||||
|
const db = new DatabaseSync(':memory:');
|
||||||
|
initMessagesTable(db);
|
||||||
|
// 150 rows — onModuleInit seeds only the newest 100 into the buffer (ids 2050..2149)
|
||||||
|
const ins = db.prepare(
|
||||||
|
'INSERT INTO messages(id, dir, to_node, from_node, text, channel, at, status, ack_error) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?)',
|
||||||
|
);
|
||||||
|
for (let i = 0; i < 150; i++)
|
||||||
|
ins.run(
|
||||||
|
2000 + i,
|
||||||
|
'rx',
|
||||||
|
42,
|
||||||
|
KAMIL_NUM,
|
||||||
|
`old-${i}`,
|
||||||
|
2,
|
||||||
|
1_700_000_000_000 + i * 1000,
|
||||||
|
null,
|
||||||
|
null,
|
||||||
|
);
|
||||||
|
|
||||||
|
const bridge = await startBridge();
|
||||||
|
process.env.MESH_HOST = '127.0.0.1';
|
||||||
|
process.env.MESH_PORT = String(bridge.port);
|
||||||
|
const svc = new MeshService(db);
|
||||||
|
try {
|
||||||
|
svc.onModuleInit();
|
||||||
|
await waitFor(
|
||||||
|
() => bridge.sockets.length === 1 && svc.status().connected,
|
||||||
|
);
|
||||||
|
|
||||||
|
// id 2000 is in SQLite but outside the seeded buffer
|
||||||
|
const { id } = await svc.respond(2000, 'pong');
|
||||||
|
expect(id).toBeGreaterThan(0);
|
||||||
|
expect(svc.messages()[0]).toMatchObject({
|
||||||
|
dir: 'tx',
|
||||||
|
to: KAMIL_NUM, // DM back to the sender of the old rx record
|
||||||
|
text: 'pong',
|
||||||
|
channel: 2, // the record's channel
|
||||||
|
});
|
||||||
|
} finally {
|
||||||
|
svc.onModuleDestroy();
|
||||||
|
bridge.close();
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|
||||||
|
it('rejects invalid messageId and empty content with BadRequestException', async () => {
|
||||||
|
const svc = new MeshService();
|
||||||
|
for (const bad of [0, BROADCAST_ADDR + 1, 42.5, 'x' as unknown as number])
|
||||||
|
await expect(svc.respond(bad, 'hi')).rejects.toBeInstanceOf(
|
||||||
|
BadRequestException,
|
||||||
|
);
|
||||||
|
await expect(svc.respond(1, '')).rejects.toThrow(
|
||||||
|
'content must be a non-empty string',
|
||||||
|
);
|
||||||
|
await expect(svc.respond(1, undefined)).rejects.toBeInstanceOf(
|
||||||
|
BadRequestException,
|
||||||
|
);
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
describe('MeshService opencode notifier', () => {
|
describe('MeshService opencode notifier', () => {
|
||||||
// our own node number for the self-echo filter specs (distinct from KAMIL_NUM, an external user)
|
// our own node number for the self-echo filter specs (distinct from KAMIL_NUM, an external user)
|
||||||
const MY_NODE = 987654321;
|
const MY_NODE = 987654321;
|
||||||
let notifyMock: ReturnType<typeof vi.fn>;
|
let notifyMock: ReturnType<typeof vi.fn>;
|
||||||
|
|
||||||
beforeEach(() => {
|
beforeEach(() => {
|
||||||
notifyMock = vi.fn(async (_text: string, _from?: number) => {});
|
notifyMock = vi.fn(
|
||||||
|
async (_id: number, _text: string, _from?: number) => {},
|
||||||
|
);
|
||||||
});
|
});
|
||||||
|
|
||||||
// myInfo frame as streamed during the initial sync — sets svc.myNodeNum
|
// myInfo frame as streamed during the initial sync — sets svc.myNodeNum
|
||||||
@@ -715,10 +900,9 @@ describe('MeshService opencode notifier', () => {
|
|||||||
|
|
||||||
// MeshService with a mocked OpencodeService wired in (structural cast — only notify() is used)
|
// MeshService with a mocked OpencodeService wired in (structural cast — only notify() is used)
|
||||||
function makeSvc(): MeshService {
|
function makeSvc(): MeshService {
|
||||||
return new MeshService(
|
return new MeshService(undefined, {
|
||||||
undefined,
|
notify: notifyMock,
|
||||||
{ notify: notifyMock } as unknown as OpencodeService,
|
} as unknown as OpencodeService);
|
||||||
);
|
|
||||||
}
|
}
|
||||||
|
|
||||||
it('notifies via the opencode service when an rx text lands on the notify channel (default 3)', async () => {
|
it('notifies via the opencode service when an rx text lands on the notify channel (default 3)', async () => {
|
||||||
@@ -737,7 +921,7 @@ describe('MeshService opencode notifier', () => {
|
|||||||
|
|
||||||
await waitFor(() => notifyMock.mock.calls.length === 1);
|
await waitFor(() => notifyMock.mock.calls.length === 1);
|
||||||
expect(notifyMock).toHaveBeenCalledTimes(1);
|
expect(notifyMock).toHaveBeenCalledTimes(1);
|
||||||
expect(notifyMock).toHaveBeenCalledWith('ping', KAMIL_NUM);
|
expect(notifyMock).toHaveBeenCalledWith(1, 'ping', KAMIL_NUM); // packet id threaded through
|
||||||
} finally {
|
} finally {
|
||||||
delete process.env.MESH_NOTIFY_CHANNEL;
|
delete process.env.MESH_NOTIFY_CHANNEL;
|
||||||
svc.onModuleDestroy();
|
svc.onModuleDestroy();
|
||||||
@@ -773,10 +957,10 @@ describe('MeshService opencode notifier', () => {
|
|||||||
process.env.MESH_NOTIFY_CHANNEL = '0';
|
process.env.MESH_NOTIFY_CHANNEL = '0';
|
||||||
const svc = makeSvc();
|
const svc = makeSvc();
|
||||||
try {
|
try {
|
||||||
svc.injectMessage('hi', 42);
|
const r = svc.injectMessage('hi', 42);
|
||||||
|
|
||||||
expect(notifyMock).toHaveBeenCalledTimes(1);
|
expect(notifyMock).toHaveBeenCalledTimes(1);
|
||||||
expect(notifyMock).toHaveBeenCalledWith('hi', 42);
|
expect(notifyMock).toHaveBeenCalledWith(r.id, 'hi', 42); // generated record id threaded through
|
||||||
} finally {
|
} finally {
|
||||||
delete process.env.MESH_NOTIFY_CHANNEL;
|
delete process.env.MESH_NOTIFY_CHANNEL;
|
||||||
}
|
}
|
||||||
@@ -786,10 +970,10 @@ describe('MeshService opencode notifier', () => {
|
|||||||
process.env.MESH_NOTIFY_CHANNEL = '0';
|
process.env.MESH_NOTIFY_CHANNEL = '0';
|
||||||
const svc = makeSvc();
|
const svc = makeSvc();
|
||||||
try {
|
try {
|
||||||
svc.injectMessage('hi');
|
const r = svc.injectMessage('hi');
|
||||||
|
|
||||||
expect(notifyMock).toHaveBeenCalledTimes(1);
|
expect(notifyMock).toHaveBeenCalledTimes(1);
|
||||||
expect(notifyMock).toHaveBeenCalledWith('hi', undefined);
|
expect(notifyMock).toHaveBeenCalledWith(r.id, 'hi', undefined);
|
||||||
} finally {
|
} finally {
|
||||||
delete process.env.MESH_NOTIFY_CHANNEL;
|
delete process.env.MESH_NOTIFY_CHANNEL;
|
||||||
}
|
}
|
||||||
@@ -848,6 +1032,267 @@ describe('MeshService opencode notifier', () => {
|
|||||||
bridge.close();
|
bridge.close();
|
||||||
}
|
}
|
||||||
});
|
});
|
||||||
|
|
||||||
|
it('notifies for rx texts on any channel in a comma-separated MESH_NOTIFY_CHANNEL list, and not for others', async () => {
|
||||||
|
const bridge = await startBridge();
|
||||||
|
process.env.MESH_HOST = '127.0.0.1';
|
||||||
|
process.env.MESH_PORT = String(bridge.port);
|
||||||
|
process.env.MESH_NOTIFY_CHANNEL = '2,5';
|
||||||
|
const svc = makeSvc();
|
||||||
|
try {
|
||||||
|
svc.onModuleInit();
|
||||||
|
await waitFor(
|
||||||
|
() => bridge.sockets.length === 1 && svc.status().connected,
|
||||||
|
);
|
||||||
|
|
||||||
|
// channel 5 is in the list — notified
|
||||||
|
bridge.sockets[0].write(textPacketFrame(KAMIL_NUM, 42, 'on-list', 5));
|
||||||
|
|
||||||
|
await waitFor(() => notifyMock.mock.calls.length === 1);
|
||||||
|
expect(notifyMock).toHaveBeenCalledWith(1, 'on-list', KAMIL_NUM);
|
||||||
|
|
||||||
|
// channel 3 is not in the list — captured in history but no notification
|
||||||
|
bridge.sockets[0].write(textPacketFrame(KAMIL_NUM, 42, 'off-list', 3));
|
||||||
|
|
||||||
|
await waitFor(() => svc.messages().length === 2);
|
||||||
|
expect(notifyMock).toHaveBeenCalledTimes(1);
|
||||||
|
} finally {
|
||||||
|
delete process.env.MESH_NOTIFY_CHANNEL;
|
||||||
|
svc.onModuleDestroy();
|
||||||
|
bridge.close();
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|
||||||
|
it('ignores ch0 broadcasts even when 0 is in the list, but notifies for directed DMs', async () => {
|
||||||
|
const bridge = await startBridge();
|
||||||
|
process.env.MESH_HOST = '127.0.0.1';
|
||||||
|
process.env.MESH_PORT = String(bridge.port);
|
||||||
|
process.env.MESH_NOTIFY_CHANNEL = '3,0';
|
||||||
|
const svc = makeSvc();
|
||||||
|
try {
|
||||||
|
svc.onModuleInit();
|
||||||
|
await waitFor(
|
||||||
|
() => bridge.sockets.length === 1 && svc.status().connected,
|
||||||
|
);
|
||||||
|
|
||||||
|
// ch0 broadcast: shared default channel noise — no notification
|
||||||
|
bridge.sockets[0].write(
|
||||||
|
textPacketFrame(KAMIL_NUM, BROADCAST_ADDR, 'hello all', 0),
|
||||||
|
);
|
||||||
|
|
||||||
|
await waitFor(() => svc.messages().length === 1);
|
||||||
|
expect(notifyMock).not.toHaveBeenCalled();
|
||||||
|
|
||||||
|
// ch0 directed DM: both sender and recipient present — notified
|
||||||
|
bridge.sockets[0].write(textPacketFrame(KAMIL_NUM, 42, 'dm', 0));
|
||||||
|
|
||||||
|
await waitFor(() => notifyMock.mock.calls.length === 1);
|
||||||
|
expect(notifyMock).toHaveBeenCalledWith(1, 'dm', KAMIL_NUM);
|
||||||
|
} finally {
|
||||||
|
delete process.env.MESH_NOTIFY_CHANNEL;
|
||||||
|
svc.onModuleDestroy();
|
||||||
|
bridge.close();
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|
||||||
|
it('notifies for a ch0 injection when 0 is in the list (multi-list)', () => {
|
||||||
|
process.env.MESH_NOTIFY_CHANNEL = '3,0';
|
||||||
|
const svc = makeSvc();
|
||||||
|
try {
|
||||||
|
const r = svc.injectMessage('hi', 42);
|
||||||
|
|
||||||
|
// injected records are exempt from the ch0 DM-only rule
|
||||||
|
expect(notifyMock).toHaveBeenCalledTimes(1);
|
||||||
|
expect(notifyMock).toHaveBeenCalledWith(r.id, 'hi', 42);
|
||||||
|
} finally {
|
||||||
|
delete process.env.MESH_NOTIFY_CHANNEL;
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|
||||||
|
it('ignores empty and invalid entries in MESH_NOTIFY_CHANNEL', async () => {
|
||||||
|
const bridge = await startBridge();
|
||||||
|
process.env.MESH_HOST = '127.0.0.1';
|
||||||
|
process.env.MESH_PORT = String(bridge.port);
|
||||||
|
process.env.MESH_NOTIFY_CHANNEL = 'abc, ,5,-2,x7';
|
||||||
|
const svc = makeSvc();
|
||||||
|
try {
|
||||||
|
svc.onModuleInit();
|
||||||
|
await waitFor(
|
||||||
|
() => bridge.sockets.length === 1 && svc.status().connected,
|
||||||
|
);
|
||||||
|
|
||||||
|
// only the valid entry (5) survives parsing — notified
|
||||||
|
bridge.sockets[0].write(textPacketFrame(KAMIL_NUM, 42, 'ping', 5));
|
||||||
|
|
||||||
|
await waitFor(() => notifyMock.mock.calls.length === 1);
|
||||||
|
expect(notifyMock).toHaveBeenCalledWith(1, 'ping', KAMIL_NUM);
|
||||||
|
|
||||||
|
// channel 7 only appears inside the invalid entry "x7" — must not match
|
||||||
|
bridge.sockets[0].write(textPacketFrame(KAMIL_NUM, 42, 'nope', 7));
|
||||||
|
|
||||||
|
await waitFor(() => svc.messages().length === 2);
|
||||||
|
expect(notifyMock).toHaveBeenCalledTimes(1);
|
||||||
|
} finally {
|
||||||
|
delete process.env.MESH_NOTIFY_CHANNEL;
|
||||||
|
svc.onModuleDestroy();
|
||||||
|
bridge.close();
|
||||||
|
}
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('MeshService forwarded ring', () => {
|
||||||
|
const MY_NODE = 987654321;
|
||||||
|
let notifyMock: ReturnType<typeof vi.fn>;
|
||||||
|
|
||||||
|
beforeEach(() => {
|
||||||
|
notifyMock = vi.fn(
|
||||||
|
async (_id: number, _text: string, _from?: number) => {},
|
||||||
|
);
|
||||||
|
});
|
||||||
|
|
||||||
|
// myInfo frame as streamed during the initial sync — sets svc.myNodeNum
|
||||||
|
function myInfoFrame(num: number): Uint8Array {
|
||||||
|
return frame(
|
||||||
|
toBinary(
|
||||||
|
P.Mesh.FromRadioSchema,
|
||||||
|
create(P.Mesh.FromRadioSchema, {
|
||||||
|
payloadVariant: { case: 'myInfo', value: { myNodeNum: num } },
|
||||||
|
}),
|
||||||
|
),
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
// MeshService with a mocked OpencodeService wired in (structural cast — only notify() is used)
|
||||||
|
function makeSvc(): MeshService {
|
||||||
|
return new MeshService(undefined, {
|
||||||
|
notify: notifyMock,
|
||||||
|
} as unknown as OpencodeService);
|
||||||
|
}
|
||||||
|
|
||||||
|
it('records an entry when an rx text passes the gate and is handed off (channel match)', async () => {
|
||||||
|
const bridge = await startBridge();
|
||||||
|
process.env.MESH_HOST = '127.0.0.1';
|
||||||
|
process.env.MESH_PORT = String(bridge.port);
|
||||||
|
delete process.env.MESH_NOTIFY_CHANNEL; // default 3
|
||||||
|
const svc = makeSvc();
|
||||||
|
try {
|
||||||
|
svc.onModuleInit();
|
||||||
|
await waitFor(
|
||||||
|
() => bridge.sockets.length === 1 && svc.status().connected,
|
||||||
|
);
|
||||||
|
|
||||||
|
bridge.sockets[0].write(textPacketFrame(KAMIL_NUM, 42, 'ping', 3));
|
||||||
|
|
||||||
|
await waitFor(() => notifyMock.mock.calls.length === 1);
|
||||||
|
expect(svc.forwarded()).toEqual([
|
||||||
|
{
|
||||||
|
id: 1,
|
||||||
|
from: KAMIL_NUM,
|
||||||
|
text: 'ping',
|
||||||
|
channel: 3,
|
||||||
|
at: expect.any(Number),
|
||||||
|
},
|
||||||
|
]);
|
||||||
|
} finally {
|
||||||
|
delete process.env.MESH_NOTIFY_CHANNEL;
|
||||||
|
svc.onModuleDestroy();
|
||||||
|
bridge.close();
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|
||||||
|
it('does not record on channel mismatch', async () => {
|
||||||
|
const bridge = await startBridge();
|
||||||
|
process.env.MESH_HOST = '127.0.0.1';
|
||||||
|
process.env.MESH_PORT = String(bridge.port);
|
||||||
|
delete process.env.MESH_NOTIFY_CHANNEL; // default 3
|
||||||
|
const svc = makeSvc();
|
||||||
|
try {
|
||||||
|
svc.onModuleInit();
|
||||||
|
await waitFor(
|
||||||
|
() => bridge.sockets.length === 1 && svc.status().connected,
|
||||||
|
);
|
||||||
|
|
||||||
|
bridge.sockets[0].write(textPacketFrame(KAMIL_NUM, 42, 'ping', 2));
|
||||||
|
|
||||||
|
// the message is captured in history — but off-channel it never reaches the ring
|
||||||
|
await waitFor(() => svc.messages().length === 1);
|
||||||
|
expect(notifyMock).not.toHaveBeenCalled();
|
||||||
|
expect(svc.forwarded()).toEqual([]);
|
||||||
|
} finally {
|
||||||
|
delete process.env.MESH_NOTIFY_CHANNEL;
|
||||||
|
svc.onModuleDestroy();
|
||||||
|
bridge.close();
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|
||||||
|
it('does not record a self-echo (rx from our own node on the notify channel)', async () => {
|
||||||
|
const bridge = await startBridge();
|
||||||
|
process.env.MESH_HOST = '127.0.0.1';
|
||||||
|
process.env.MESH_PORT = String(bridge.port);
|
||||||
|
delete process.env.MESH_NOTIFY_CHANNEL; // default 3
|
||||||
|
const svc = makeSvc();
|
||||||
|
try {
|
||||||
|
svc.onModuleInit();
|
||||||
|
await waitFor(
|
||||||
|
() => bridge.sockets.length === 1 && svc.status().connected,
|
||||||
|
);
|
||||||
|
|
||||||
|
bridge.sockets[0].write(myInfoFrame(MY_NODE));
|
||||||
|
await waitFor(() => svc.status().myNodeNum === MY_NODE);
|
||||||
|
|
||||||
|
bridge.sockets[0].write(textPacketFrame(MY_NODE, 42, 'ping', 3));
|
||||||
|
|
||||||
|
// history capture proves the packet was processed (notifyRx runs right after it)
|
||||||
|
await waitFor(() => svc.messages().length === 1);
|
||||||
|
expect(notifyMock).not.toHaveBeenCalled();
|
||||||
|
expect(svc.forwarded()).toEqual([]);
|
||||||
|
} finally {
|
||||||
|
delete process.env.MESH_NOTIFY_CHANNEL;
|
||||||
|
svc.onModuleDestroy();
|
||||||
|
bridge.close();
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|
||||||
|
it('does not record when no notifier is wired', () => {
|
||||||
|
process.env.MESH_NOTIFY_CHANNEL = '0'; // injected records ride channel 0 — the gate would pass
|
||||||
|
const svc = new MeshService(); // unwired — pinned semantics: nothing forwarded, nothing recorded
|
||||||
|
try {
|
||||||
|
svc.injectMessage('hi');
|
||||||
|
|
||||||
|
expect(svc.forwarded()).toEqual([]);
|
||||||
|
} finally {
|
||||||
|
delete process.env.MESH_NOTIFY_CHANNEL;
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|
||||||
|
it('counts injected messages that pass the gate and omits `from` when there is no sender', () => {
|
||||||
|
process.env.MESH_NOTIFY_CHANNEL = '0';
|
||||||
|
const svc = makeSvc();
|
||||||
|
try {
|
||||||
|
const r = svc.injectMessage('hi'); // no from
|
||||||
|
|
||||||
|
expect(svc.forwarded()).toEqual([
|
||||||
|
{ id: r.id, text: 'hi', channel: 0, at: expect.any(Number) },
|
||||||
|
]);
|
||||||
|
expect('from' in svc.forwarded()[0]!).toBe(false);
|
||||||
|
} finally {
|
||||||
|
delete process.env.MESH_NOTIFY_CHANNEL;
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|
||||||
|
it('caps at 100 (oldest evicted), newest first', () => {
|
||||||
|
process.env.MESH_NOTIFY_CHANNEL = '0';
|
||||||
|
const svc = makeSvc();
|
||||||
|
try {
|
||||||
|
for (let i = 0; i < 101; i++) svc.injectMessage(`m-${i}`);
|
||||||
|
|
||||||
|
expect(svc.forwarded()).toHaveLength(100);
|
||||||
|
expect(svc.forwarded()[0]!.text).toBe('m-100'); // newest first
|
||||||
|
expect(svc.forwarded()[99]!.text).toBe('m-1'); // m-0 evicted
|
||||||
|
} finally {
|
||||||
|
delete process.env.MESH_NOTIFY_CHANNEL;
|
||||||
|
}
|
||||||
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
describe('MeshService injectMessage', () => {
|
describe('MeshService injectMessage', () => {
|
||||||
@@ -1318,6 +1763,44 @@ describe('MeshService SQLite persistence', () => {
|
|||||||
}
|
}
|
||||||
});
|
});
|
||||||
|
|
||||||
|
it('persists the destination (to) of captured rx packets on poller tick', async () => {
|
||||||
|
const bridge = await startBridge();
|
||||||
|
process.env.MESH_HOST = '127.0.0.1';
|
||||||
|
process.env.MESH_PORT = String(bridge.port);
|
||||||
|
process.env.MESH_POLL_MS = '50';
|
||||||
|
const db = new DatabaseSync(':memory:');
|
||||||
|
initMessagesTable(db);
|
||||||
|
const svc = new MeshService(db);
|
||||||
|
try {
|
||||||
|
svc.onModuleInit();
|
||||||
|
await waitFor(
|
||||||
|
() => bridge.sockets.length === 1 && svc.status().connected,
|
||||||
|
);
|
||||||
|
|
||||||
|
bridge.sockets[0].write(textPacketFrame(KAMIL_NUM, 42, 'ping', 3));
|
||||||
|
|
||||||
|
// the poller tick must pick it up — no flushHistory() call here
|
||||||
|
await waitFor(
|
||||||
|
() =>
|
||||||
|
(
|
||||||
|
db.prepare('SELECT COUNT(*) AS n FROM messages').get() as {
|
||||||
|
n: number;
|
||||||
|
}
|
||||||
|
).n === 1,
|
||||||
|
);
|
||||||
|
const row = db
|
||||||
|
.prepare('SELECT * FROM messages WHERE id = ?')
|
||||||
|
.get(1) as Record<string, unknown>;
|
||||||
|
expect(row.dir).toBe('rx');
|
||||||
|
expect(row.from_node).toBe(KAMIL_NUM);
|
||||||
|
expect(row.to_node).toBe(42); // rx rows carry the destination now (no schema change — to_node existed for tx)
|
||||||
|
} finally {
|
||||||
|
delete process.env.MESH_POLL_MS;
|
||||||
|
svc.onModuleDestroy();
|
||||||
|
bridge.close();
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|
||||||
it('reflects the ACK status update in the database after the next tick', async () => {
|
it('reflects the ACK status update in the database after the next tick', async () => {
|
||||||
const bridge = await startBridge();
|
const bridge = await startBridge();
|
||||||
process.env.MESH_HOST = '127.0.0.1';
|
process.env.MESH_HOST = '127.0.0.1';
|
||||||
|
|||||||
+147
-26
@@ -1,6 +1,8 @@
|
|||||||
import {
|
import {
|
||||||
|
BadRequestException,
|
||||||
Injectable,
|
Injectable,
|
||||||
Logger,
|
Logger,
|
||||||
|
NotFoundException,
|
||||||
OnModuleDestroy,
|
OnModuleDestroy,
|
||||||
OnModuleInit,
|
OnModuleInit,
|
||||||
ServiceUnavailableException,
|
ServiceUnavailableException,
|
||||||
@@ -9,6 +11,8 @@ import * as net from 'node:net';
|
|||||||
// type-only import: node:sqlite is only required at runtime by whoever opens a database (mesh.module.ts / tests)
|
// type-only import: node:sqlite is only required at runtime by whoever opens a database (mesh.module.ts / tests)
|
||||||
import type { DatabaseSync } from 'node:sqlite';
|
import type { DatabaseSync } from 'node:sqlite';
|
||||||
import type * as Proto from '@meshtastic/protobufs';
|
import type * as Proto from '@meshtastic/protobufs';
|
||||||
|
// type-only: the instance arrives via attachCommands() in production (command.module.ts) or the constructor in tests — no runtime import cycle with src/commands
|
||||||
|
import type { CommandService } from '../commands/command.service.js';
|
||||||
import { OpencodeService } from '../opencode/opencode.service.js';
|
import { OpencodeService } from '../opencode/opencode.service.js';
|
||||||
import {
|
import {
|
||||||
BROADCAST_ADDR,
|
BROADCAST_ADDR,
|
||||||
@@ -37,7 +41,7 @@ export interface MessageRecord {
|
|||||||
dir: 'rx' | 'tx';
|
dir: 'rx' | 'tx';
|
||||||
/** sender node num — rx only */
|
/** sender node num — rx only */
|
||||||
from?: number;
|
from?: number;
|
||||||
/** destination node num (broadcast addr for broadcasts) — tx only */
|
/** destination node num (broadcast addr for broadcasts) — captured rx packets and all tx records */
|
||||||
to?: number;
|
to?: number;
|
||||||
text: string;
|
text: string;
|
||||||
channel: number;
|
channel: number;
|
||||||
@@ -49,6 +53,18 @@ export interface MessageRecord {
|
|||||||
ackError?: string;
|
ackError?: string;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/** One entry in the forwarded ring: an rx text that passed the notify gate and was handed off to opencode. */
|
||||||
|
export interface ForwardedRecord {
|
||||||
|
/** packet id (real rx) or generated record id (injected) */
|
||||||
|
id: number;
|
||||||
|
/** sender node num — omitted when there is no sender */
|
||||||
|
from?: number;
|
||||||
|
text: string;
|
||||||
|
channel: number;
|
||||||
|
/** epoch ms */
|
||||||
|
at: number;
|
||||||
|
}
|
||||||
|
|
||||||
/** One entry in the telemetry history: a TELEMETRY_APP packet from some node. */
|
/** One entry in the telemetry history: a TELEMETRY_APP packet from some node. */
|
||||||
export interface TelemetryRecord {
|
export interface TelemetryRecord {
|
||||||
/** sender node num */
|
/** sender node num */
|
||||||
@@ -84,6 +100,22 @@ export function initMessagesTable(db: DatabaseSync): void {
|
|||||||
db.exec(MESSAGES_DDL);
|
db.exec(MESSAGES_DDL);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/** Map a messages-table row to a MessageRecord (NULLs → omitted optionals). */
|
||||||
|
function recordFromRow(row: Record<string, unknown>): MessageRecord {
|
||||||
|
const rec: MessageRecord = {
|
||||||
|
id: Number(row.id),
|
||||||
|
dir: row.dir === 'tx' ? 'tx' : 'rx',
|
||||||
|
text: String(row.text),
|
||||||
|
channel: Number(row.channel),
|
||||||
|
at: Number(row.at),
|
||||||
|
};
|
||||||
|
if (row.to_node != null) rec.to = Number(row.to_node);
|
||||||
|
if (row.from_node != null) rec.from = Number(row.from_node);
|
||||||
|
if (row.status != null) rec.status = row.status as MessageRecord['status'];
|
||||||
|
if (row.ack_error != null) rec.ackError = String(row.ack_error);
|
||||||
|
return rec;
|
||||||
|
}
|
||||||
|
|
||||||
/** What we know about a node so far: full NodeInfo after sync, possibly just {num}+position for live-only nodes. */
|
/** What we know about a node so far: full NodeInfo after sync, possibly just {num}+position for live-only nodes. */
|
||||||
type NodeEntry = Pick<Proto.Mesh.NodeInfo, 'num'> &
|
type NodeEntry = Pick<Proto.Mesh.NodeInfo, 'num'> &
|
||||||
Partial<Omit<Proto.Mesh.NodeInfo, 'num'>>;
|
Partial<Omit<Proto.Mesh.NodeInfo, 'num'>>;
|
||||||
@@ -131,6 +163,15 @@ function jsonSafe<T>(value: T): T {
|
|||||||
return value; // primitives + undefined pass through
|
return value; // primitives + undefined pass through
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/** MESH_NOTIFY_CHANNEL is a comma-separated list of channel indices; empty/invalid entries are ignored. */
|
||||||
|
function parseNotifyChannels(raw: string): number[] {
|
||||||
|
return raw
|
||||||
|
.split(',')
|
||||||
|
.map((s) => s.trim())
|
||||||
|
.filter((s) => /^\d+$/.test(s))
|
||||||
|
.map((s) => parseInt(s, 10));
|
||||||
|
}
|
||||||
|
|
||||||
// key material must never leave the process — replaced with a marker so callers can see the field exists
|
// key material must never leave the process — replaced with a marker so callers can see the field exists
|
||||||
const REDACTED = 'REDACTED';
|
const REDACTED = 'REDACTED';
|
||||||
/** Config sections that carry secrets: security (PKI keys) and network (wifi psk). */
|
/** Config sections that carry secrets: security (PKI keys) and network (wifi psk). */
|
||||||
@@ -160,11 +201,10 @@ export class MeshService implements OnModuleInit, OnModuleDestroy {
|
|||||||
process.env.MESH_SEND_CHANNEL ?? '3',
|
process.env.MESH_SEND_CHANNEL ?? '3',
|
||||||
10,
|
10,
|
||||||
);
|
);
|
||||||
// outbound notification: fire-and-forget push to the opencode notifier when an rx text lands on the notify channel;
|
// outbound notification: fire-and-forget push to the opencode notifier when an rx text lands on one of the notify channels;
|
||||||
// disabled state (missing credentials) lives in OpencodeService itself
|
// disabled state (missing credentials) lives in OpencodeService itself
|
||||||
private readonly notifyChannel = parseInt(
|
private readonly notifyChannels = parseNotifyChannels(
|
||||||
process.env.MESH_NOTIFY_CHANNEL ?? '3',
|
process.env.MESH_NOTIFY_CHANNEL ?? '3',
|
||||||
10,
|
|
||||||
);
|
);
|
||||||
// how often the poller re-upserts the history buffer into SQLite (ms)
|
// how often the poller re-upserts the history buffer into SQLite (ms)
|
||||||
private readonly pollMs = parseInt(process.env.MESH_POLL_MS ?? '1000', 10);
|
private readonly pollMs = parseInt(process.env.MESH_POLL_MS ?? '1000', 10);
|
||||||
@@ -173,11 +213,23 @@ export class MeshService implements OnModuleInit, OnModuleDestroy {
|
|||||||
private db: DatabaseSync | null = null;
|
private db: DatabaseSync | null = null;
|
||||||
/** In-process opencode notifier for rx texts on the notify channel; null in tests that don't wire one. */
|
/** In-process opencode notifier for rx texts on the notify channel; null in tests that don't wire one. */
|
||||||
private readonly opencode: OpencodeService | null;
|
private readonly opencode: OpencodeService | null;
|
||||||
|
/** Event-driven `#command` auto-responder (COMMAND_CHANNEL); null until wired — via the constructor (tests) or attachCommands() (DI). */
|
||||||
|
private commands: CommandService | null = null;
|
||||||
private pollTimer: NodeJS.Timeout | null = null;
|
private pollTimer: NodeJS.Timeout | null = null;
|
||||||
|
|
||||||
constructor(db?: DatabaseSync, opencode?: OpencodeService) {
|
constructor(
|
||||||
|
db?: DatabaseSync,
|
||||||
|
opencode?: OpencodeService,
|
||||||
|
commands?: CommandService,
|
||||||
|
) {
|
||||||
this.db = db ?? null;
|
this.db = db ?? null;
|
||||||
this.opencode = opencode ?? null;
|
this.opencode = opencode ?? null;
|
||||||
|
this.commands = commands ?? null;
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Wire the `#command` auto-responder after construction — used by command.module.ts to break the DI cycle (a constructor-level MeshService <-> CommandService cycle leaves one side null in NestJS's injector). */
|
||||||
|
attachCommands(commands: CommandService): void {
|
||||||
|
this.commands = commands;
|
||||||
}
|
}
|
||||||
|
|
||||||
private socket: net.Socket | null = null;
|
private socket: net.Socket | null = null;
|
||||||
@@ -197,6 +249,8 @@ export class MeshService implements OnModuleInit, OnModuleDestroy {
|
|||||||
private moduleConfigSections = new Map<string, Record<string, unknown>>();
|
private moduleConfigSections = new Map<string, Record<string, unknown>>();
|
||||||
// message history (newest kept, capped at HISTORY_LIMIT) + pending tx records awaiting their routing ACK/NACK
|
// message history (newest kept, capped at HISTORY_LIMIT) + pending tx records awaiting their routing ACK/NACK
|
||||||
private history: MessageRecord[] = [];
|
private history: MessageRecord[] = [];
|
||||||
|
// rx texts handed off to the opencode notifier (newest first, capped at HISTORY_LIMIT); in-memory only
|
||||||
|
private forwardedHistory: ForwardedRecord[] = [];
|
||||||
private pendingTx = new Map<number, MessageRecord>();
|
private pendingTx = new Map<number, MessageRecord>();
|
||||||
// telemetry history (newest kept, capped at HISTORY_LIMIT)
|
// telemetry history (newest kept, capped at HISTORY_LIMIT)
|
||||||
private telemetryHistory: TelemetryRecord[] = [];
|
private telemetryHistory: TelemetryRecord[] = [];
|
||||||
@@ -358,6 +412,14 @@ export class MeshService implements OnModuleInit, OnModuleDestroy {
|
|||||||
return [...this.history].reverse();
|
return [...this.history].reverse();
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* The last HISTORY_LIMIT rx texts that passed the notify gate and were handed off to opencode, newest first:
|
||||||
|
* channel matched MESH_NOTIFY_CHANNEL, not a self-echo, and a notifier is wired. In-memory only — reset on restart.
|
||||||
|
*/
|
||||||
|
forwarded(): ForwardedRecord[] {
|
||||||
|
return [...this.forwardedHistory];
|
||||||
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Re-upsert the entire in-memory history buffer into SQLite (INSERT OR REPLACE per row) and enforce
|
* Re-upsert the entire in-memory history buffer into SQLite (INSERT OR REPLACE per row) and enforce
|
||||||
* retention: only the newest DB_RETENTION rows survive. Called by the poller every MESH_POLL_MS;
|
* retention: only the newest DB_RETENTION rows survive. Called by the poller every MESH_POLL_MS;
|
||||||
@@ -393,21 +455,55 @@ export class MeshService implements OnModuleInit, OnModuleDestroy {
|
|||||||
'SELECT id, dir, to_node, from_node, text, channel, at, status, ack_error FROM messages ORDER BY at DESC LIMIT ?',
|
'SELECT id, dir, to_node, from_node, text, channel, at, status, ack_error FROM messages ORDER BY at DESC LIMIT ?',
|
||||||
).all(HISTORY_LIMIT) as Array<Record<string, unknown>>;
|
).all(HISTORY_LIMIT) as Array<Record<string, unknown>>;
|
||||||
// rows come back newest first — the buffer is oldest-first
|
// rows come back newest first — the buffer is oldest-first
|
||||||
for (const row of [...rows].reverse()) {
|
for (const row of [...rows].reverse())
|
||||||
const rec: MessageRecord = {
|
this.history.push(recordFromRow(row));
|
||||||
id: Number(row.id),
|
|
||||||
dir: row.dir === 'tx' ? 'tx' : 'rx',
|
|
||||||
text: String(row.text),
|
|
||||||
channel: Number(row.channel),
|
|
||||||
at: Number(row.at),
|
|
||||||
};
|
|
||||||
if (row.to_node != null) rec.to = Number(row.to_node);
|
|
||||||
if (row.from_node != null) rec.from = Number(row.from_node);
|
|
||||||
if (row.status != null)
|
|
||||||
rec.status = row.status as MessageRecord['status'];
|
|
||||||
if (row.ack_error != null) rec.ackError = String(row.ack_error);
|
|
||||||
this.history.push(rec);
|
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/** Look up a history record by packet id: in-memory buffer first, then SQLite (newest 1000). */
|
||||||
|
private findRecord(id: number): MessageRecord | undefined {
|
||||||
|
const hit = this.history.find((r) => r.id === id);
|
||||||
|
if (hit) return hit;
|
||||||
|
const db = this.db;
|
||||||
|
if (!db) return undefined;
|
||||||
|
const row = db
|
||||||
|
.prepare(
|
||||||
|
'SELECT id, dir, to_node, from_node, text, channel, at, status, ack_error FROM messages WHERE id = ?',
|
||||||
|
)
|
||||||
|
.get(id) as Record<string, unknown> | undefined;
|
||||||
|
return row ? recordFromRow(row) : undefined;
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Reply to an earlier message by packet id — the caller never thinks about where it goes:
|
||||||
|
* rx records are answered as a DM back to the original sender, tx records go to their destination;
|
||||||
|
* broadcast originals (and injected messages without a sender) get a broadcast. The reply always
|
||||||
|
* rides the record's channel and carries replyId = messageId, so the recipient app renders it as a
|
||||||
|
* threaded quote of that packet. Returns { id } with the new packet id. Throws BadRequest on invalid
|
||||||
|
* arguments, NotFound when no message has the given id (in memory or in SQLite), 503 when the bridge is down.
|
||||||
|
*/
|
||||||
|
async respond(messageId: number, content: string): Promise<{ id: number }> {
|
||||||
|
if (
|
||||||
|
!Number.isInteger(messageId) ||
|
||||||
|
messageId < 1 ||
|
||||||
|
messageId > BROADCAST_ADDR
|
||||||
|
)
|
||||||
|
throw new BadRequestException(
|
||||||
|
'messageId must be an integer in 1..0xffffffff',
|
||||||
|
);
|
||||||
|
if (typeof content !== 'string' || content.length === 0)
|
||||||
|
throw new BadRequestException('content must be a non-empty string');
|
||||||
|
const rec = this.findRecord(messageId);
|
||||||
|
if (!rec) throw new NotFoundException(`no message with id ${messageId}`);
|
||||||
|
// rx → DM back to the sender unless the original was a broadcast (then reply as a broadcast — that's what the stored destination is for);
|
||||||
|
// tx → its own destination; injected records without a sender → broadcast
|
||||||
|
const target =
|
||||||
|
rec.dir === 'rx'
|
||||||
|
? rec.to === BROADCAST_ADDR
|
||||||
|
? BROADCAST_ADDR
|
||||||
|
: rec.from
|
||||||
|
: rec.to;
|
||||||
|
const to = target ?? BROADCAST_ADDR;
|
||||||
|
return { id: await this.sendText(to, content, messageId, rec.channel) };
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
@@ -432,20 +528,42 @@ export class MeshService implements OnModuleInit, OnModuleDestroy {
|
|||||||
at: Date.now(),
|
at: Date.now(),
|
||||||
};
|
};
|
||||||
this.pushHistory(rec);
|
this.pushHistory(rec);
|
||||||
// injected records ride channel 0 — the notifier fires only when MESH_NOTIFY_CHANNEL is set to match
|
// injected records ride channel 0 — the notifier fires only when 0 is in MESH_NOTIFY_CHANNEL (injections are exempt from the ch0 DM-only rule)
|
||||||
this.notifyRx(0, text, from);
|
this.notifyRx(0, text, from, rec.id, undefined, true);
|
||||||
return { id: rec.id };
|
return { id: rec.id };
|
||||||
}
|
}
|
||||||
|
|
||||||
/** Fire-and-forget opencode notifier push for an rx text on `channel` (no-op unless channels match and a notifier is wired). */
|
/** Fire-and-forget opencode notifier push for an rx text on `channel` (no-op unless the channel is in the notify list and a notifier is wired). Both call sites pass the packet id; `injected` marks synthetic records that ride ch0 by design. */
|
||||||
private notifyRx(channel: number, text: string, from?: number): void {
|
private notifyRx(
|
||||||
if (!this.opencode || channel !== this.notifyChannel) return;
|
channel: number,
|
||||||
|
text: string,
|
||||||
|
from?: number,
|
||||||
|
id?: number,
|
||||||
|
to?: number,
|
||||||
|
injected = false,
|
||||||
|
): void {
|
||||||
|
if (!this.opencode || !this.notifyChannels.includes(channel)) return;
|
||||||
|
// ch0 is the shared default channel where other users talk — only directed DMs (a real destination) are notified there; broadcasts and undirected traffic are noise. Injected records ride ch0 by design, so they're exempt.
|
||||||
|
if (
|
||||||
|
channel === 0 &&
|
||||||
|
!injected &&
|
||||||
|
(to === undefined || to === BROADCAST_ADDR)
|
||||||
|
)
|
||||||
|
return;
|
||||||
// self-echo filter: our own node must never trigger a notification of itself
|
// self-echo filter: our own node must never trigger a notification of itself
|
||||||
if (from !== undefined && from === this.myNodeNum) {
|
if (from !== undefined && from === this.myNodeNum) {
|
||||||
this.logger.debug(`notify skipped: rx from our own node ${from}`);
|
this.logger.debug(`notify skipped: rx from our own node ${from}`);
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
void this.opencode.notify(text, from);
|
// record the forward at hand-off — the ring holds exactly what a wired notifier receives (newest first).
|
||||||
|
// Pinned semantics: an unwired notifier records nothing (early return above); a notifier disabled internally
|
||||||
|
// (empty credentials) still counts — MeshService cannot see its enabled flag.
|
||||||
|
const entry: ForwardedRecord = { id: id!, text, channel, at: Date.now() };
|
||||||
|
if (from !== undefined) entry.from = from;
|
||||||
|
this.forwardedHistory.unshift(entry);
|
||||||
|
if (this.forwardedHistory.length > HISTORY_LIMIT)
|
||||||
|
this.forwardedHistory.pop(); // oldest evicted
|
||||||
|
void this.opencode.notify(id!, text, from); // both call sites always pass the packet id
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
@@ -626,11 +744,14 @@ export class MeshService implements OnModuleInit, OnModuleDestroy {
|
|||||||
id: pkt.id,
|
id: pkt.id,
|
||||||
dir: 'rx',
|
dir: 'rx',
|
||||||
from: pkt.from,
|
from: pkt.from,
|
||||||
|
to: pkt.to, // destination (broadcast addr for broadcasts) — lets a later reply tell DM vs broadcast apart
|
||||||
text,
|
text,
|
||||||
channel: pkt.channel ?? 0,
|
channel: pkt.channel ?? 0,
|
||||||
at: Date.now(),
|
at: Date.now(),
|
||||||
});
|
});
|
||||||
this.notifyRx(pkt.channel ?? 0, text, pkt.from);
|
this.notifyRx(pkt.channel ?? 0, text, pkt.from, pkt.id, pkt.to);
|
||||||
|
// event-driven #command auto-responder (COMMAND_CHANNEL) — fire-and-forget like the notifier
|
||||||
|
void this.commands?.onRx(pkt.channel ?? 0, text, pkt.from, pkt.id);
|
||||||
} else if (decoded && decoded.portnum === PORT_POSITION_APP) {
|
} else if (decoded && decoded.portnum === PORT_POSITION_APP) {
|
||||||
// live position update: the Position is serialized in Data.payload
|
// live position update: the Position is serialized in Data.payload
|
||||||
let pos: Proto.Mesh.Position | undefined;
|
let pos: Proto.Mesh.Position | undefined;
|
||||||
|
|||||||
@@ -68,7 +68,7 @@ describe('OpencodeService.notify', () => {
|
|||||||
.mockResolvedValueOnce(json([WORKSPACE]))
|
.mockResolvedValueOnce(json([WORKSPACE]))
|
||||||
.mockResolvedValueOnce(json({}));
|
.mockResolvedValueOnce(json({}));
|
||||||
|
|
||||||
await svc.notify('hi', 42);
|
await svc.notify(7, 'hi', 42);
|
||||||
|
|
||||||
expect(fetchMock).toHaveBeenCalledTimes(2);
|
expect(fetchMock).toHaveBeenCalledTimes(2);
|
||||||
const [url, init] = fetchMock.mock.calls[1];
|
const [url, init] = fetchMock.mock.calls[1];
|
||||||
@@ -89,7 +89,7 @@ describe('OpencodeService.notify', () => {
|
|||||||
parts: [
|
parts: [
|
||||||
{
|
{
|
||||||
type: 'text',
|
type: 'text',
|
||||||
text: 'New mesh message from node 42: "hi" — please react to it.',
|
text: 'New mesh message (id 7) from node 42: "hi" — please react to it.',
|
||||||
},
|
},
|
||||||
],
|
],
|
||||||
}),
|
}),
|
||||||
@@ -106,7 +106,7 @@ describe('OpencodeService.notify', () => {
|
|||||||
.mockResolvedValueOnce(json([WORKSPACE]))
|
.mockResolvedValueOnce(json([WORKSPACE]))
|
||||||
.mockResolvedValueOnce(json({}));
|
.mockResolvedValueOnce(json({}));
|
||||||
|
|
||||||
await svc.notify('hi');
|
await svc.notify(7, 'hi');
|
||||||
|
|
||||||
const [, init] = fetchMock.mock.calls[1];
|
const [, init] = fetchMock.mock.calls[1];
|
||||||
expect(String((init as { body?: string }).body)).toBe(
|
expect(String((init as { body?: string }).body)).toBe(
|
||||||
@@ -114,7 +114,7 @@ describe('OpencodeService.notify', () => {
|
|||||||
parts: [
|
parts: [
|
||||||
{
|
{
|
||||||
type: 'text',
|
type: 'text',
|
||||||
text: 'New mesh message: "hi" — please react to it.',
|
text: 'New mesh message (id 7): "hi" — please react to it.',
|
||||||
},
|
},
|
||||||
],
|
],
|
||||||
}),
|
}),
|
||||||
@@ -146,7 +146,7 @@ describe('OpencodeService.notify', () => {
|
|||||||
);
|
);
|
||||||
fetchMock.mockResolvedValueOnce(json({}));
|
fetchMock.mockResolvedValueOnce(json({}));
|
||||||
|
|
||||||
await svc.notify('hi');
|
await svc.notify(7, 'hi');
|
||||||
|
|
||||||
expect(fetchMock.mock.calls[1][0]).toBe(
|
expect(fetchMock.mock.calls[1][0]).toBe(
|
||||||
`${API}/proxy/abc/session/ses_pinned/message`,
|
`${API}/proxy/abc/session/ses_pinned/message`,
|
||||||
@@ -179,7 +179,7 @@ describe('OpencodeService.notify', () => {
|
|||||||
);
|
);
|
||||||
fetchMock.mockResolvedValueOnce(json({}));
|
fetchMock.mockResolvedValueOnce(json({}));
|
||||||
|
|
||||||
await svc.notify('hi');
|
await svc.notify(7, 'hi');
|
||||||
|
|
||||||
expect(fetchMock.mock.calls[1][0]).toBe(
|
expect(fetchMock.mock.calls[1][0]).toBe(
|
||||||
`${API}/proxy/b/session/ses_pinned/message`,
|
`${API}/proxy/b/session/ses_pinned/message`,
|
||||||
@@ -198,7 +198,7 @@ describe('OpencodeService.notify', () => {
|
|||||||
)
|
)
|
||||||
.mockResolvedValueOnce(json({}));
|
.mockResolvedValueOnce(json({}));
|
||||||
|
|
||||||
await svc.notify('hi');
|
await svc.notify(7, 'hi');
|
||||||
|
|
||||||
expect(fetchMock.mock.calls[1][0]).toBe(`${API}/proxy/abc/session`);
|
expect(fetchMock.mock.calls[1][0]).toBe(`${API}/proxy/abc/session`);
|
||||||
expect(fetchMock.mock.calls[2][0]).toBe(
|
expect(fetchMock.mock.calls[2][0]).toBe(
|
||||||
@@ -213,7 +213,7 @@ describe('OpencodeService.notify', () => {
|
|||||||
.mockResolvedValueOnce(json([{ id: 'ses_a' }, { id: 'ses_b', time: {} }]))
|
.mockResolvedValueOnce(json([{ id: 'ses_a' }, { id: 'ses_b', time: {} }]))
|
||||||
.mockResolvedValueOnce(json({}));
|
.mockResolvedValueOnce(json({}));
|
||||||
|
|
||||||
await svc.notify('hi');
|
await svc.notify(7, 'hi');
|
||||||
|
|
||||||
expect(fetchMock.mock.calls[2][0]).toBe(
|
expect(fetchMock.mock.calls[2][0]).toBe(
|
||||||
`${API}/proxy/abc/session/ses_a/message`,
|
`${API}/proxy/abc/session/ses_a/message`,
|
||||||
@@ -230,7 +230,7 @@ describe('OpencodeService.notify', () => {
|
|||||||
.mockResolvedValueOnce(json([WORKSPACE]))
|
.mockResolvedValueOnce(json([WORKSPACE]))
|
||||||
.mockResolvedValueOnce(json({}));
|
.mockResolvedValueOnce(json({}));
|
||||||
|
|
||||||
await svc.notify('hi');
|
await svc.notify(7, 'hi');
|
||||||
|
|
||||||
// workspaces GET + message POST only — no /session discovery GET
|
// workspaces GET + message POST only — no /session discovery GET
|
||||||
expect(fetchMock).toHaveBeenCalledTimes(2);
|
expect(fetchMock).toHaveBeenCalledTimes(2);
|
||||||
@@ -309,7 +309,7 @@ describe('OpencodeService.notify', () => {
|
|||||||
string
|
string
|
||||||
>[]) {
|
>[]) {
|
||||||
const svc = makeService(env);
|
const svc = makeService(env);
|
||||||
await expect(svc.notify('hi', 42)).resolves.toBeUndefined();
|
await expect(svc.notify(7, 'hi', 42)).resolves.toBeUndefined();
|
||||||
expect(fetchMock).not.toHaveBeenCalled();
|
expect(fetchMock).not.toHaveBeenCalled();
|
||||||
}
|
}
|
||||||
});
|
});
|
||||||
|
|||||||
@@ -49,10 +49,10 @@ export class OpencodeService {
|
|||||||
* up to RETRY_DELAYS_MS.length + 1 attempts total; the last failure logs `opencode notify dropped
|
* up to RETRY_DELAYS_MS.length + 1 attempts total; the last failure logs `opencode notify dropped
|
||||||
* after N attempts`. No-op when disabled (no credentials).
|
* after N attempts`. No-op when disabled (no credentials).
|
||||||
*/
|
*/
|
||||||
async notify(text: string, from?: number): Promise<void> {
|
async notify(id: number, text: string, from?: number): Promise<void> {
|
||||||
if (!this.enabled) return;
|
if (!this.enabled) return;
|
||||||
const msg =
|
const msg =
|
||||||
'New mesh message' +
|
`New mesh message (id ${id})` +
|
||||||
(from != null ? ` from node ${from}` : '') +
|
(from != null ? ` from node ${from}` : '') +
|
||||||
`: "${text}" — please react to it.`;
|
`: "${text}" — please react to it.`;
|
||||||
const maxAttempts = RETRY_DELAYS_MS.length + 1;
|
const maxAttempts = RETRY_DELAYS_MS.length + 1;
|
||||||
|
|||||||
Reference in New Issue
Block a user