OpenCode/Flight-Ops
2
0
Fork 0
Code Issues Pull Requests Actions Activity

I just bought second plane - now game is broken, i can't load cargo if both planes are on same airport. #55

New Issue
Closed
opened 2026-09-20 15:19:18 +02:00 by kamilkrzywda · 1 comment
kamilkrzywda commented 2026-09-20 15:19:18 +02:00
Owner
Copy Link
Copy Source

Add e2e tests for all gameplay funcions that may be affected by having 2 planes and fix errors that appears becouse of that.

Add e2e tests for all gameplay funcions that may be affected by having 2 planes and fix errors that appears becouse of that.
kamilkrzywda changed title from I just bought second plane - now game is broken, i can't load cargo. to I just bought second plane - now game is broken, i can't load cargo if both planes are on same airport. 2026-09-20 15:20:39 +02:00
kamilkrzywda commented 2026-09-21 01:19:58 +02:00
Author
Owner
Copy Link
Copy Source

Fixed and shipped as v0.31.0 (PR #62, merge commit bf2c46b95975dbe752d922b393c78e737cee4d1b), deployed to https://flight.dev.kkhost.pl.

What changed:

  • Load is now one-click with several grounded planes at the origin — the plane picker preselects the first eligible plane (you can still pick another via the dropdown). The reported "can't load cargo" was this unselected-picker state: with 2+ eligible planes the Load button stayed disabled until a selection existed.
  • Queue testids scoped by plane id (queue-leg-{plane.id}-{i}, queue-cancel-{plane.id}-{i}, queue-add-{plane.id}) — the old unscoped ids duplicated across on-board blocks and would break any two-plane interaction.
  • New e2e coverage for 2-plane gameplay: serial spec e2e/two-planes.spec.ts with 6 tests covering load / fly (incl. ISS-057 slow-to-1× + resume semantics) / refuel / relocate / queue / sell, each buying a second ATR through the real UI and resetting the fleet to one plane afterwards.
  • New test hook POST /api/test/add-cash (FLIGHT_TEST_HOOKS=1 only, outside the public API) so e2e can afford a second plane deterministically.

Verification: full unit suite green (327 tests), all 52 e2e specs pass in CI against the isolated stack; prod verified at v0.31.0 (/api/version + root page).

Fixed and shipped as **v0.31.0** (PR #62, merge commit `bf2c46b95975dbe752d922b393c78e737cee4d1b`), deployed to https://flight.dev.kkhost.pl. What changed: - **Load is now one-click with several grounded planes at the origin** — the plane picker preselects the first eligible plane (you can still pick another via the dropdown). The reported "can't load cargo" was this unselected-picker state: with 2+ eligible planes the Load button stayed disabled until a selection existed. - **Queue testids scoped by plane id** (`queue-leg-{plane.id}-{i}`, `queue-cancel-{plane.id}-{i}`, `queue-add-{plane.id}`) — the old unscoped ids duplicated across on-board blocks and would break any two-plane interaction. - **New e2e coverage for 2-plane gameplay**: serial spec `e2e/two-planes.spec.ts` with 6 tests covering load / fly (incl. ISS-057 slow-to-1× + resume semantics) / refuel / relocate / queue / sell, each buying a second ATR through the real UI and resetting the fleet to one plane afterwards. - **New test hook** `POST /api/test/add-cash` (FLIGHT_TEST_HOOKS=1 only, outside the public API) so e2e can afford a second plane deterministically. Verification: full unit suite green (327 tests), all 52 e2e specs pass in CI against the isolated stack; prod verified at v0.31.0 (`/api/version` + root page).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
kamilkrzywda (Kamil Krzywda) smysakowski
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenCode/Flight-Ops#55